[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48052047 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java --- @@ -97,7 +101,7 @@ public

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48052644 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/SchedulingResult.java --- @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/921#issuecomment-165874443 @d2r again thanks for your review. I think I have addressed all of your comments --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48054747 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/921#issuecomment-165880798 @d2r thanks! @revans2 @harshach @hustfxj @rfarivar @HeartSaVioR @knusbaum @redsanket do you have any additional concerns? --- If your project is set up

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48057662 --- Diff: storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java --- @@ -489,17 +489,63 @@ public void validateField(String name, Object o

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48058248 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48058088 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/User.java --- @@ -0,0 +1,345 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-18 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48057606 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/priority/ISchedulingPriorityStrategy.java --- @@ -16,22 +16,26

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47948394 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47956261 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47962084 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47966400 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47963491 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r4797 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996002 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996336 --- Diff: storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java --- @@ -489,17 +489,63 @@ public void validateField(String name, Object o

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996885 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997537 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998998 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,227 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/921#issuecomment-165702815 If there no slots left on a node, the DefaultResourceAwareStrategy will not schedule on that node. The number of slots should not effect the default eviction/priority

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996525 --- Diff: storm-core/test/jvm/backtype/storm/TestConfigValidate.java --- @@ -628,9 +628,89 @@ public void TestImpersonationAclUserEntryValidator() throws

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997034 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997006 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997239 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997596 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998401 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998805 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java --- @@ -0,0 +1,290 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48000168 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/SchedulingResult.java --- @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r48000453 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -128,56 +308,121 @@ private void

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996124 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/priority/ISchedulingPriorityStrategy.java --- @@ -16,22 +16,26

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996648 --- Diff: storm-core/test/jvm/backtype/storm/TestConfigValidate.java --- @@ -628,9 +628,89 @@ public void TestImpersonationAclUserEntryValidator() throws

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997302 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998460 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998726 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998771 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestUser.java --- @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998792 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java --- @@ -0,0 +1,290 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r4792 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/921#issuecomment-165703496 @d2r thank you so much for your detailed review! Few people are will to take this much time and effort to review someone else's code. Big thanks again! much

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996047 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/priority/DefaultSchedulingPriorityStrategy.java --- @@ -0,0 +1,85

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996840 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996829 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47996761 --- Diff: storm-core/test/jvm/backtype/storm/TestConfigValidate.java --- @@ -628,9 +628,89 @@ public void TestImpersonationAclUserEntryValidator() throws

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997169 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997212 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997185 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47997668 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998594 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestResourceAwareScheduler.java --- @@ -0,0 +1,1166 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47998913 --- Diff: storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java --- @@ -0,0 +1,290 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47999139 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,227 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47999760 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java --- @@ -430,12 +457,44 @@ public SupervisorDetails getSupervisorById(String nodeId

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47972424 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47972838 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -128,56 +308,121 @@ private void

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47972634 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -28,94 +32,270 @@ import

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47972750 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/SchedulingResult.java --- @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47991939 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java --- @@ -97,7 +101,7 @@ public

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992186 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -128,56 +308,121 @@ private void

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992259 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -128,56 +308,121 @@ private void

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992667 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -128,56 +308,121 @@ private void

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992737 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -128,56 +308,121 @@ private void

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992746 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java --- @@ -130,4 +137,57 @@ private static void debugMessage(String

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992825 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java --- @@ -130,4 +137,57 @@ private static void debugMessage(String

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992974 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/User.java --- @@ -0,0 +1,346 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47992997 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/User.java --- @@ -0,0 +1,346 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47993443 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47993642 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47993566 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/IEvictionStrategy.java --- @@ -0,0 +1,47 @@ +/** + * Licensed

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47995263 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-17 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47995488 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/eviction/DefaultEvictionStrategy.java --- @@ -0,0 +1,109

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47825137 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -396,34 +410,50 @@ public void addResourcesForExec(ExecutorDetails exec

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47825469 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java --- @@ -193,17 +199,21 @@ public void freeAllSlots(Cluster cluster

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47834447 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Nodes.java --- @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47832364 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Nodes.java --- @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-1373] Blobstore API sample example usag...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/934#issuecomment-165216534 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47804939 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -396,34 +410,50 @@ public void addResourcesForExec(ExecutorDetails exec

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47835243 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -396,34 +410,50 @@ public void addResourcesForExec(ExecutorDetails exec

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47840133 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -396,34 +410,50 @@ public void addResourcesForExec(ExecutorDetails exec

[GitHub] storm pull request: [STORM-1377] Correct timeouts for milliseconds

2015-12-16 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/941#issuecomment-165164975 +1 and verified nimbus auth unit tests have no failures running on a machine with 1 core --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-1372] Merging design and usage document...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/945#discussion_r47667733 --- Diff: docs/documentation/distcache-blobstore.md --- @@ -0,0 +1,736 @@ +# Storm Distributed Cache API + +The distributed cache feature

[GitHub] storm pull request: [STORM-1372] Merging design and usage document...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/945#discussion_r47667287 --- Diff: docs/documentation/distcache-blobstore.md --- @@ -0,0 +1,736 @@ +# Storm Distributed Cache API + +The distributed cache feature

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47665654 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -540,12 +540,16 @@ topology (read-storm-topology-as-nimbus storm-id blob

[GitHub] storm pull request: [STORM-1372] Merging design and usage document...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/945#discussion_r47667869 --- Diff: docs/documentation/distcache-blobstore.md --- @@ -0,0 +1,736 @@ +# Storm Distributed Cache API + +The distributed cache feature

[GitHub] storm pull request: [STORM-1372] Merging design and usage document...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/945#discussion_r47667610 --- Diff: docs/documentation/distcache-blobstore.md --- @@ -0,0 +1,732 @@ +# Storm Distributed Cache API + +The distributed cache feature

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47687409 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47690649 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java --- @@ -430,12 +457,44 @@ public SupervisorDetails getSupervisorById(String nodeId

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47680796 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47687578 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47690181 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47690382 --- Diff: examples/storm-starter/src/jvm/storm/starter/ResourceAwareExampleTopology.java --- @@ -84,6 +82,12 @@ public static void main(String[] args

[GitHub] storm pull request: [STORM-1372] Merging design and usage document...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/945#discussion_r47668508 --- Diff: docs/documentation/distcache-blobstore.md --- @@ -0,0 +1,736 @@ +# Storm Distributed Cache API + +The distributed cache feature

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47689800 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47680985 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47679946 --- Diff: conf/defaults.yaml --- @@ -251,10 +251,14 @@ topology.disruptor.batch.timeout.millis: 1 topology.disable.loadaware: false # Configs

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47691373 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -403,13 +415,23 @@ public void addResourcesForExec(ExecutorDetails exec

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47691122 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java --- @@ -90,6 +92,21 @@ public Cluster(INimbus nimbus, Map<String, SupervisorDeta

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47680553 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47691769 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java --- @@ -193,17 +199,21 @@ public void freeAllSlots(Cluster cluster

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47689183 --- Diff: docs/documentation/Resource_Aware_Scheduler_overview.md --- @@ -0,0 +1,224 @@ +# Introduction + +The purpose of this document

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47691646 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -1847,6 +1858,13 @@ public static final String TOPOLOGY_LOGGING_SENSITIVITY

[GitHub] storm pull request: [STORM-898] - Add priorities and per user reso...

2015-12-15 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/921#discussion_r47691611 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -403,13 +415,23 @@ public void addResourcesForExec(ExecutorDetails exec

<    1   2   3   4   5   6   7   >