Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2597
Requested changes incorporated. Thanks for the review.
---
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2597#discussion_r177723827
--- Diff:
examples/storm-mqtt-examples/src/main/java/org/apache/storm/mqtt/examples/CustomMessageMapper.java
---
@@ -15,35 +15,77 @@
* See the
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2596
Last comments incorporated.
---
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2596#discussion_r177086700
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/bolt/EsIndexTopology.java
---
@@ -92,20 +173,37 @@ public
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2596#discussion_r177086661
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/bolt/EsIndexTopology.java
---
@@ -34,52 +39,128
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2596
I agree with all your comments and removed the
`TridentEsTopology.get/setMaxBatchSize`. The noisy comments are required (see
comment above). Thanks for the review.
---
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2596#discussion_r176943570
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/bolt/EsIndexTopology.java
---
@@ -34,52 +39,128
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2596
> Thanks for the fixes. I'll review this as soon as I can. In the meantime,
could you raise issues on https://issues.apache.org/jira to track your changes?
Nice. Done.
---
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2595
Forget that. The last `git rm --cached -r . && git add .` deleted (!) the
binary files which the test tries to load. I didn't pay attention, my bad.
---
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2595
[Adding `*.[extension] binary` seems to cause the tests to fail regardless
of the order](https://travis-ci.org/krichter722/storm/jobs/357184158). The
question is why. Maybe asking a question on
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2595
[`*.png binary` seems to cause tests to fail because of unavailable test
resources](https://travis-ci.org/krichter722/storm/builds/356601827?utm_source=email&utm_medium=notification).
Omi
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2595
> Some other changes were made to these files. Could you fix up eol again?
Done.
> Regarding the text=auto for all paths, I'm mentioning it because googling
text=aut
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2595
I don't seem to understand how to get the GitHub diff view to make the
first change outdated instead of the second after an amended commit. Please
keep that in mind when reading my repli
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2595#discussion_r175918249
--- Diff: .gitattributes ---
@@ -1,2 +1,2 @@
# Some storm-webapp logviewer tests require input files to have LF line
endings due to byte counting
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2595#discussion_r175916989
--- Diff: .gitattributes ---
@@ -1,2 +1,2 @@
# Some storm-webapp logviewer tests require input files to have LF line
endings due to byte counting
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
> we can hold off if you want to clean up these unnecessary annotations.
Done.
---
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
I just realized that this PR makes a lot of `@SuppressWarning("rawtypes")`
unnecessary. What do you think about adding that as a second commit to this PR?
---
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/460
@d2r I rebased the branch, removed changes in classes generated by the
Thrift compiler and included all subprojects. Since checkstyle is now in place
I reviewed all `maxAllowedViolations` in POMs
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
> I would either rename that Jira and update the description a bit, or open
a new one. Once you've done that, add the jira number into the PR title - look
at other Storm PRs for
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/2598
storm-kafka: added ExponentialBackoffMsgRetryManagerSpoutConfig
Only `ExponentialBackoffMsgRetryManager` uses
`SpoutConfig.retryInitialDelayMs`, `retryDelayMultiplier`, `retryDelayMaxMs`
and
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/2597
storm-mqtt-examples: fixed all checkstyle warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krichter722/storm checkstyle-fix-mqtt
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/2596
storm-elasticsearch-examples: fixed all checkstyle warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krichter722/storm checkstyle
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/2595
set '* text=auto' in .gitattributes in order to avoid merge work because of
line feed changes
Unfortunately, `git` doesn't initialize repositories by default with this
`.git
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/2594
storm-kafka: encapsulated Broker.host and port
This satisfies the checkstyle check.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
> Is there a Jira issue associated with this pull request? If not, we can
make one.
I found https://issues.apache.org/jira/browse/STORM-1048 in issues reported
by me which I forgot un
Github user krichter722 commented on a diff in the pull request:
https://github.com/apache/storm/pull/459#discussion_r175236914
--- Diff: external/storm-kafka/pom.xml ---
@@ -57,7 +57,7 @@
maven-checkstyle-plugin
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
> It would probably be preferable to do as you suggest, regarding a
configuration class, but I'm not sure how much work there is to do there.
I wouldn't do it for all Maps,
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
> I checked a few of these, and it seems they have already been modified to
avoid the compile errors.
I seems like `IBolt.prepare`'s `topoConf` has been changed to `Map` everywhe
Github user krichter722 commented on the pull request:
https://github.com/apache/storm/pull/459#issuecomment-167631380
> @krichter722, what in particular does this fix?
Compiler warnings.
---
If your project is set up for it, you can reply to this email and have your
re
Github user krichter722 commented on the pull request:
https://github.com/apache/storm/pull/737#issuecomment-140576591
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user krichter722 commented on the pull request:
https://github.com/apache/storm/pull/737#issuecomment-140565438
> Btw, you can get Clojure failed whenever any clojure tests error occur,
so it doesn't tell you have an issue related to multilang.
You should open tar
Github user krichter722 commented on the pull request:
https://github.com/apache/storm/pull/737#issuecomment-140563170
> Btw, you can get Clojure failed whenever any clojure tests error occur,
so it doesn't tell you have an issue related to multilang.
You should open tar
Github user krichter722 commented on the pull request:
https://github.com/apache/storm/pull/737#issuecomment-140553259
Thanks for your feedback. I'm just getting started with (building) `storm`.
> Python doesn't have package manager so if you don't have py
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/737
added missing installation instructions for installation of rvm and nâ¦
â¦vm of DEVELOPER.md (without running \`mvn clean install\`) isn't
possible on an average system (like Ubuntu 15.04
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/460
added missing @Override annotations
help to detect inheritance issues when generics are used more intensively
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user krichter722 opened a pull request:
https://github.com/apache/storm/pull/459
avoiding rawtypes in IBold.prepare in order to allow usage without @Supp...
...ressWarnings("rawtypes") which can be quite annoying during intensive
usage of storm. Some classes which
36 matches
Mail list logo
