Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/1257#issuecomment-203471618
I have reviewed the PR, it is fine to me except several little problem, but
I haven't done any test. Suggest to do integrate test, both local mode and
distributed
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57900100
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -0,0 +1,626 @@
+/**
+ * Licensed to the Apache
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57896552
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -0,0 +1,626 @@
+/**
+ * Licensed to the Apache
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57887620
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -0,0 +1,626 @@
+/**
+ * Licensed to the Apache
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57883592
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHealthCheck.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57880994
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -0,0 +1,87 @@
+/**
+ * Licensed
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57880519
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -0,0 +1,271 @@
+/**
+ * Licensed to the Apache
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57879928
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/StandaloneSupervisor.java
---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57870832
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/DefaultUncaughtExceptionHandler.java
---
@@ -0,0 +1,31 @@
+/**
+ * Licensed
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1069#discussion_r54083889
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/Acker.java ---
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/1069#issuecomment-187230721
+1,
The acker logic is correct, come from JStorm.
In JStorm, it handle two more case:
Acker.ACKER_INIT_STREAM_ID's tuple is after
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/#issuecomment-185633860
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-185631768
+1, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/1113#issuecomment-184983036
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158033245
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
+1 as well.
(1) What we have been calling “0.11.0” will become the Storm 1.0
release.[Longda] Agree. we almost stop developing new feature after 0.11, so
0.11 is one big version of clojure core, I prefer we give it one big milestone
number 1.0 to this version. In fact, this version will
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/662#issuecomment-157686065
@priyank5485
I don't prefer switch storm.py from python to java. Because I often add
debug point in the storm.py, it is very easy to debug in online
system
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/849#issuecomment-155701669
+1
sorry for late response
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
+1
By the way, Tong(王桐) can work for this. Tong is responsible for the
automatically daily JStorm test, the only problem is that the automatically
daily JStorm test is basing on Alibaba testing framework. Some of the
components can't run on outside.
But we can share the test cases firstly. Then
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/849#issuecomment-153917289
the code is fine to me, but this is the first step to do health check:
(1) where put the script, we had better put the script under
$STORM_HOME/healthcheck
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-90834098
why indentation.size and tabulation.size are 2, normally they are 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user longdafeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/468#discussion_r27273285
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -533,4 +533,16 @@ private static SerializationDelegate
getSerializationDelegate(Map
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/354#issuecomment-85033376
@ptgoetz @revans2 @Parth-Brahmbhatt,
Sorry for late discuss the HA desgin.
Strongly recommend using JStorm's Nimbus HA Design. It is pretty stable
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/354#issuecomment-85341944
@Parth-Brahmbhatt , I don't suggest using
org.apache.curator.framework.recipes.leader
In fact, We had implemented HA
24 matches
Mail list logo
