Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik @harshach Can you help me in merging it. Unfortunately I am
not able to squash it :(
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@harshach I have already squash it in 8da34ca
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
Can someone merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik Thanks for document. Can you merge
8da34caf4938e8a8cc5ac9c745000ed5c6f82b2a? Then I will close PR.
---
If your project is set up for it, you can reply to this email and have
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik Can you help m in squash this? I am not able to do it :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
Can I squash my changes then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik My bad. I have corrected it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik I have added test case too. We have running this code in our
staging environment
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@harshach Done. Thanks for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
@roshannaik Can you again review it please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1957#discussion_r102632667
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -163,12 +164,19 @@ public HdfsSpout setClocksInSync
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1957
Can someone take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pasalkarsachin1 closed the pull request at:
https://github.com/apache/storm/pull/1939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
Thanks for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user pasalkarsachin1 opened a pull request:
https://github.com/apache/storm/pull/1957
STORM-2373: HDFS Spout should support multiple ignore extensions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pasalkarsachin1/storm
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Can you merge this so I will close this PR :) Thanks in
advance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
@HeartSaVioR @roshannaik @arunmahadevan are you OK with this approach?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Squashed into one commit. Commit sha is
7cc1bdbea562a48aa09cc6dc7fd29edd5bd4eb10
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR I have updated code as per your comment :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
@HeartSaVioR
> For point 2 I suggest adding shortcut, not removing previous one.
Providing FQDN is not easiest way to do so we can make some implementations
taking precedence
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101993619
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
> The current FileReader implementation is expected to have constructor
with a specific signature, which cannot be enforced at compile time. IMO, this
should also be fixed along with t
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
For points made by @HeartSaVioR
For point 2, I have various implementations in mind to add to open source
one of them is implemented by megha10 for ZipTextFileReader another can be
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
@roshannaik Like I said even on Jira STORM-2358. I don't see point having
code *just to specifically handle alias*. Code should be *generic* to handle
all cases. If you want to push to
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101951192
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Can you take a look at it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
@HeartSaVioR @roshannaik @arunmahadevan Can you review this? Let me know if
there is any issue you see with backward compatibility.
---
If your project is set up for it, you can reply to
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
I have reverted class renaming. Other than this I don't see break in
backward compatibility
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1942#discussion_r101704350
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HDFSSpout.java ---
@@ -105,87 +105,87 @@
private String
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1942#discussion_r101702796
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HDFSSpout.java ---
@@ -105,87 +105,87 @@
private String
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1942#discussion_r101699216
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HDFSSpout.java ---
@@ -105,87 +105,87 @@
private String
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1942#discussion_r101698425
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HDFSSpout.java ---
@@ -722,19 +703,10 @@ private FileReader createFileReader
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1942#discussion_r101698420
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HDFSSpout.java ---
@@ -409,9 +409,14 @@ public void open(Map conf
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
Can someone take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
Can someone take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR I did my best. Can you take a look at it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user pasalkarsachin1 opened a pull request:
https://github.com/apache/storm/pull/1942
STORM-2358: Update storm hdfs spout to remove specific implementation
handling
As part of this change I have removed specific handling in code for
TextFileReader & SequenceFileReader
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
I haven't changed anything it was I guess previous one had style. You can
ignore white space by appending ?w=1 to url. e.g.
https://github.com/apache/storm/pull/1939/files?w=1 This
GitHub user pasalkarsachin1 opened a pull request:
https://github.com/apache/storm/pull/1939
STORM-1363: TridentKafkaState should handle null values from
TridentTupleToKafkaMapper.getMessageFromTuple()
In case null value comes from the mapper it will print warning messages
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1928#discussion_r100880730
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/ZippedTextFileReader.java
---
@@ -0,0 +1,241 @@
+/**
+ * Licensed
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1878
I squashed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1878
Can someone merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1878
@HeartSaVioR
Done. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user pasalkarsachin1 opened a pull request:
https://github.com/apache/storm/pull/1878
Issue Fixed
I have just updated code to make sure sequence Fields should remains same
even its added in set. In old implementation because of HashSet it was
changing. Also added testcase
46 matches
Mail list logo
