Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2113
+1, though I'll admit to just skimming it this time. It would be easier to
tell what changed if the non-merge-conflict-resolution changes were in separate
commits.
It might make sense to drop
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2113
@srdo @kishorvpatil @jerrypeng
I just rebased this on the latest master and added in a few caches in some
of the internal data structures to help with performance issues we had seen in
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2113
@srdo I think I got the rest of them
@kishorvpatil could you take a look at let me know if the rework is good
for you?
---
If your project is set up for it, you can reply to this email and
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2113
I think I addressed all of the review comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2113
@kishorvpatil Could you look again. I had to rebase becase of a minor
conflict in the DefaultResourceAwareStrategy. It ended up resulting in only
some comment changes to this code, but I wanted to
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2113
cool feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
