[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2289 sure thanks. ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @roshannaik I merged this into master, but if you want any changes to it please just ask and I'll see what I can do. ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2289 +1 ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @knusbaum do you have any other comments? ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-01 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @roshannaik I think I have added in all of your feature requests so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-30 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2289 Another useful thing would be to kill to topo with a simple Ctrl-C on the cmd line using a shutdown handler. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-30 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2289 @revans2 sorry missed your msgs from here. - Yes would be nice to have the actual latency (as reported in UI) to also be included here. I also run TVL in modes where the topology cant keep

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-25 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @knusbaum I think I have addressed all of your review comments so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-25 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2289 Partial review done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-25 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 I think I am done with new features unless someone else comes up with something else that I missed out on. I really would appreciate some reviews. @knusbaum if you have the time I know you expressed

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-24 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @roshannaik I just added in support for a new default reporter that writes the data out in a fixed width format that should be much more human readable, with formatting, and it is added as a

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-24 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @roshannaik The latency reported is a simulation of kafka or something like it. The start time, is not when the message is emitted by the spout. The start time is when the message would have been

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-24 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2289 Would be nice if the latencies are trimmed off at 1 digit after decimal point --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-08-24 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2289 The latency reported in the TVL report differs from what is shown in the UI by a factor of 10k. Division error maybe ? Here is a sample report indicating mean latency of 84,246ms but the