Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2504
@revans2 Great news! Looking forward to new news about that.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2504
@HeartSaVioR not a problem. I often forget that others are not able to
read my thoughts and I sometimes forget to mention the context.
The code was not really a prototype. We intend it to
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2504
@revans2 Thanks a lot for sharing current status. Actually I have been
aware of the patch going through @abellina forked repo, so I expect HBase
plugin and UI patch would be adopted internally,
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2504
@HeartSaVioR sorry about that I think we probably were not clear enough on
this, what is covered and what is not currently covered by this pull request.
Reading through the description of
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2504
I left the questions because this PR looks like addressing only part of
STORM-2156.
The summary of issue STORM-2156 is:
```
Add RocksDB instance in Nimbus and write
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2504
Before looking into the patch in detail, I'd like to see which
functionalities the patch would want to bring.
1. As far as I read from MetricStore, it looks like providing an aggregated
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2504
Further metrics can be added to the database as desired. The intent of
this patch was to get the database functional. Given the patch size and
ongoing metrics work, I would suggest adding more
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2504
I think this patch (or following up patch, at least) should address
workers' metrics as well. Is it just waiting for Metrics V2? (#2203) Or to
avoid backward incompatibility between old workers?
