[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/972 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-11 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/972#issuecomment-170590438 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-05 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/972#issuecomment-169228054 comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-05 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/972#discussion_r48928397 --- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java --- @@ -33,20 +33,24 @@ import org.json.simple.JSONValue; import back

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-05 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/972#issuecomment-169015900 One very minor comment and then I am +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/972#discussion_r48849165 --- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java --- @@ -33,20 +33,24 @@ import org.json.simple.JSONValue; import back