Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/392#issuecomment-71864014
I agree that ZK is not the ideal place to storm most things, but it is by
far the most convenient. As such unless it is shown that it is causing a
significant load on ZK
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/392#issuecomment-71865651
Agreed, I would like a review from @Parth-Brahmbhatt first if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/392#issuecomment-71864756
The code looks fine to me +1. Although I want to wait for
@Parth-Brahmbhatt to finish his review before merging anything in.
---
If your project is set up for it, you
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/392#issuecomment-71706395
I did not know we only stored 10 errors, makes sense to not go with
pagination if its hardcoded to 10. I will take a look at the complete PR today.
Not
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/392#discussion_r23627700
--- Diff: storm-core/src/storm.thrift ---
@@ -243,6 +243,16 @@ struct SubmitOptions {
2: optional Credentials creds;
}
+enum NumErrorsChoice
GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/392
[STORM-636] Faster, optional retrieval of last component error
We want to speed up interactions with the topology that call
getTopologyInfo, including the Topology Page in the UI.
Before
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/392#discussion_r23393694
--- Diff: storm-core/src/storm.thrift ---
@@ -243,6 +243,16 @@ struct SubmitOptions {
2: optional Credentials creds;
}
+enum
