Github user prokopowicz commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-141141208
we've seen a related problem when a custom scheme returns an empty list of
lists via generateTuples. The code in partitionManager does not ack the offset
in that
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/405#issuecomment-123581897
Maybe you compile your project including the storm-kafka.
So, add {code}scopeprovided/scope{code} to POM(storm-kafka dependency).
And just try again.
---
If
Github user slora commented on the pull request:
https://github.com/apache/storm/pull/405#issuecomment-123578961
First of all, thanks @vesense for your work here!
Unfortunately , we're experiencing the same issues with 0.9.6 (includes
@vesense patch). The topology worked
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122858859
Minor complain, but [next time] it would be handy to keep commit messages
a bit more descriptive
img width=465 alt=storm 2015-07-20 14-42-47
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122872920
@lazyval Thank you for pointing out my mistake. I'm sorry for that. It
won't happen next time.
Thanks again.
---
If your project is set up for it, you can reply to
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122913837
@vesense Since it contains too many commits compared to changed lines, I
will try to squash commits into one and merge.
---
If your project is set up for it, you
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122917914
Forgot to give +1. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122919759
@vesense
Thanks for quick work! I merged this into master and 0.10.x-branch
respectively.
- master:
Github user vesense closed the pull request at:
https://github.com/apache/storm/pull/642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-123132069
@HeartSaVioR OK. thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122669976
@HeartSaVioR
I have completed the optimization. Could you take a look? Thx.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122625519
@vesense
Seems like your patch removes one invalid offset per each fill().
We may apply same optimization here.
When TopicOffsetOutOfRangeException
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/405#issuecomment-122193841
@HeartSaVioR
Could you take a look? Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122479359
@HeartSaVioR Yeah, you are right. We can reproduce the issue with 0.10.x
branch too. And I will make a new PR based on master branch.
---
If your project is set up for
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122479965
@HeartSaVioR
I have created a new PR(https://github.com/apache/storm/pull/642) based on
master branch. Could you take a look? Thx.
---
If your project is set up for
Github user 2new commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122485021
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/642
[STORM-643] KafkaUtils repeatedly fetches messages whose offset is out of
range
STORM-643 fixing based on master branch
You can merge this pull request into a Git repository by running:
$ git
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122468927
@vesense Though I don't know about storm-kafka deeply, seems like
ExponentialBackoffMsgRetryManager doesn't care about it. It just delays
retrying failed tuples, and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122480095
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122467741
Thanks for reminding. Yes, I'm working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/635#issuecomment-122462058
+1. I'll merge it.
Please note that we're considering only 0.9.x now, so we should try to
reproduce and fix from 0.10.x and master later.
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vesense closed the pull request at:
https://github.com/apache/storm/pull/405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/405#issuecomment-122466082
Will do. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/635
[STORM-643] KafkaUtils repeatedly fetches messages whose offset is out of
range
STORM-643 fixing for 0.9.x-branch
You can merge this pull request into a Git repository by running:
$ git pull
25 matches
Mail list logo
