Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45646317
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45646200
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslServerHandler.java
---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45646121
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -0,0 +1,124 @@
+;; Licensed to the Apache Software Foundation
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45642140
--- Diff: storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java ---
@@ -276,4 +313,26 @@ public static String get(Configuration configuration,
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45654094
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -1062,6 +1062,22 @@
(defn hashmap-to-persistent [^HashMap m]
(zipmap (.keySet m) (.values
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45655066
--- Diff: storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java ---
@@ -276,4 +312,39 @@ public static String get(Configuration configuration,
String
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/838
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45502326
--- Diff: bin/storm.py ---
@@ -263,6 +263,17 @@ def upload_credentials(*args):
jvmtype="-client",
extrajars=[USER_CONF_DIR,
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45506713
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45510787
--- Diff:
storm-core/src/jvm/backtype/storm/cluster/ClusterStateFactory.java ---
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45513090
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslMessageToken.java ---
@@ -63,7 +72,8 @@ public void setSaslToken(byte[] token) {
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45513199
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslMessageToken.java ---
@@ -74,20 +84,32 @@ int encodeLength() {
*
* @throws
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45513132
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslMessageToken.java ---
@@ -74,20 +84,32 @@ int encodeLength() {
*
* @throws
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515312
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/StormServerHandler.java ---
@@ -25,33 +26,39 @@
import
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45505380
--- Diff:
storm-core/src/clj/backtype/storm/cluster_state/zookeeper_state_factory.clj ---
@@ -0,0 +1,157 @@
+;; Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45505612
--- Diff: bin/storm.py ---
@@ -263,6 +263,17 @@ def upload_credentials(*args):
jvmtype="-client",
extrajars=[USER_CONF_DIR,
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45510058
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -778,6 +792,47 @@
public static final String UI_HTTPS_NEED_CLIENT_AUTH =
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45511484
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/ControlMessage.java ---
@@ -57,14 +57,19 @@ int encodeLength() {
* encode the current
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45511599
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/INettySerializable.java ---
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512204
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyServer.java
---
@@ -0,0 +1,223 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512711
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslServerHandler.java
---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45513302
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslMessageToken.java ---
@@ -74,20 +84,32 @@ int encodeLength() {
*
* @throws
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45513917
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslNettyServer.java ---
@@ -35,127 +35,124 @@
class SaslNettyServer {
-
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515660
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -0,0 +1,124 @@
+;; Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45505075
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -1062,6 +1062,22 @@
(defn hashmap-to-persistent [^HashMap m]
(zipmap (.keySet m) (.values
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45507897
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -0,0 +1,124 @@
+;; Licensed to the Apache Software Foundation (ASF)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45511827
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -0,0 +1,204 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512296
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyServer.java
---
@@ -0,0 +1,223 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512326
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyServer.java
---
@@ -0,0 +1,223 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45516340
--- Diff: storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java ---
@@ -276,4 +313,26 @@ public static String get(Configuration configuration,
String
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45504914
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -1062,6 +1062,22 @@
(defn hashmap-to-persistent [^HashMap m]
(zipmap (.keySet m) (.values
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45505939
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45506408
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45506483
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45507626
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -0,0 +1,124 @@
+;; Licensed to the Apache Software Foundation (ASF)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45510536
--- Diff: storm-core/src/jvm/backtype/storm/cluster/ClusterState.java ---
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45511278
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -243,7 +243,7 @@ public void send(Iterator msgs) {
if (closing) {
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512076
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyServer.java
---
@@ -0,0 +1,223 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512472
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslServerHandler.java
---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45514437
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslStormServerAuthorizeHandler.java
---
@@ -80,4 +80,4 @@ public void
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45514952
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslStormServerHandler.java
---
@@ -136,17 +135,19 @@ public void
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515366
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/StormServerHandler.java ---
@@ -25,33 +26,39 @@
import
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45507464
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45510242
--- Diff: storm-core/src/jvm/backtype/storm/cluster/ClusterState.java ---
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45512856
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslServerHandler.java
---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515115
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Server.java ---
@@ -17,6 +17,21 @@
*/
package backtype.storm.messaging.netty;
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515221
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/StormClientHandler.java ---
@@ -75,7 +75,7 @@ public void messageReceived(ChannelHandlerContext ctx,
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515426
--- Diff: storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java ---
@@ -32,12 +32,18 @@
import java.util.Collection;
import java.util.Set;
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45516042
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java ---
@@ -0,0 +1,252 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45517109
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java ---
@@ -0,0 +1,252 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45517334
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerServer.java ---
@@ -0,0 +1,158 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45517771
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/codec/ThriftEncoder.java ---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45517684
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/codec/ThriftEncoder.java ---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45517616
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/codec/ThriftDecoder.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45517541
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/codec/ThriftDecoder.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45518313
--- Diff: storm-core/test/clj/org/apache/storm/pacemaker_test.clj ---
@@ -0,0 +1,242 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
+;;
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-158523479
Some comments, mostly just code clean-up around new changes though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-158193770
@knusbaum Nice work on the documentation. Thank you.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-158120792
I'd like to wait for at least one more review and +1 before I merge, since
both Bobby and Kishor worked with me on the design of the system.
---
If your project is set
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-158120301
@ptgoetz
I've added a couple of sections for that stuff to the bottom of the
documentation.
---
If your project is set up for it, you can reply to this email and
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157862156
For the record, the netty messaging layer changes are only to achieve 2
things that were necessary to make the heartbeats work.
- Add Kerberos SASL plugin for the
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157914621
@knusbaum Nice documentation! Thank you.
Some thoughts on documentation improvements (please correct me if I'm
wrong):
1. Since pacemaker is a single
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157887515
I am +1. As part of full disclosure I didn't write any of this code, but I
did talk with @knusbaum and tested the feature.
---
If your project is set up for it,
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157542893
@ptgoetz I added some documentation at docs/documentation/Pacemaker.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45116436
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -778,6 +792,47 @@
public static final String UI_HTTPS_NEED_CLIENT_AUTH =
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45117066
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -778,6 +792,47 @@
public static final String UI_HTTPS_NEED_CLIENT_AUTH =
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45125877
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -778,6 +792,47 @@
public static final String UI_HTTPS_NEED_CLIENT_AUTH =
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45128439
--- Diff: docs/documentation/Pacemaker.md ---
@@ -0,0 +1,89 @@
+# Pacemaker
+
+### Introduction
+Pacemaker is a storm daemon designed to process
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45128428
--- Diff: docs/documentation/Pacemaker.md ---
@@ -0,0 +1,89 @@
+# Pacemaker
+
+### Introduction
+Pacemaker is a storm daemon designed to process
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45128342
--- Diff: docs/documentation/Pacemaker.md ---
@@ -0,0 +1,89 @@
+# Pacemaker
+
+### Introduction
+Pacemaker is a storm daemon designed to process
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157057138
@bastiliu There is a possibility of that. If you have a congested network
or if there are other issues around the pacemaker node that it could become a
bottleneck. We
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157059718
The code looks good to me and I am +1. As part of full disclosure I didn't
write any of this code, but I did talk with @knusbaum a few times about the
design of it and
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r44965169
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,239 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user bastiliu commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-157255819
@revans2 One of the reasons why we added topology master in JStorm is to
extend the hierarchy of the structrue of collection of HB & metrics to offload
Zookeepr &
Github user bastiliu commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-156904210
@knusbaum It seems all workers in cluster will connect to pacemaker to
update heartbeat. So, is it possible that pacemaker will become new bottleneck?
---
If your
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-156504222
@ptgoetz Sounds good. The good news is that Pacemaker is still off by
default, so aside from making ClusterState pluggable, there should be no
changes to the existing
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-156498367
I'm +1 for adding this functionality, but I would say that vote is
non-binding since this is new code/functionality I'm not that familiar with
yet. The code looks good
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-156172053
@knusbaum could you please rebase thrift version changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r44302695
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,248 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-155169071
revert storm-core/src/genthrift.sh 100644 â 100755 permissions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-155225503
@revans2 I'll wait to rebase until It's ready to merge. Others might want
to see the comment history.
---
If your project is set up for it, you can reply to this
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r44160889
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -0,0 +1,212 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-154474226
@knusbaum could you please rebase your patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43940458
--- Diff: storm-core/src/jvm/backtype/storm/cluster/ClusterState.java ---
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43941636
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -0,0 +1,212 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43952746
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -0,0 +1,212 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43940262
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -752,6 +759,54 @@
public static final String UI_HTTPS_NEED_CLIENT_AUTH =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43941560
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslClientHandler.java
---
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43942352
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -0,0 +1,212 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43952914
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Context.java ---
@@ -55,6 +54,7 @@ public void prepare(Map storm_conf) {
int
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43938663
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -0,0 +1,248 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r43802385
--- Diff: storm-core/test/clj/org/apache/storm/pacemaker_test.clj ---
@@ -0,0 +1,227 @@
+(ns org.apache.storm.pacemaker-test
+ (:require
92 matches
Mail list logo
