Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/836
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152676783
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152675912
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sureshms commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43554133
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -30,18 +31,20 @@
private HashMap>> bundles =
new HashMap();
Github user sureshms commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43553925
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java ---
@@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf) {
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/836#issuecomment-152646032
+1 LGTM. A few pinpoints only related with readability of the code that are
left to the discretion of the implementer.
---
If your project is set up for it, you can reply t
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549539
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -248,8 +250,9 @@ public StormTopology buildTopology() {
}
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549404
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -233,8 +234,9 @@ public StormTopology buildTopology() {
}
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549300
--- Diff:
storm-core/src/jvm/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java
---
@@ -162,9 +162,9 @@ public void commit(TransactionAttempt attempt
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548584
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -30,18 +31,20 @@
private HashMap>> bundles =
new HashMap();
pu
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548241
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java ---
@@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf) {
kryo
GitHub user sureshms opened a pull request:
https://github.com/apache/storm/pull/836
STORM-1152 Change map keySet iteration to entrySet iteration for effiâ¦
keySet to entrySet iteration changes along with other minor comments and
code cleanup.
You can merge this pull request into
12 matches
Mail list logo