Github user chuanlei commented on the pull request:
https://github.com/apache/storm/pull/1410#issuecomment-222044581
@vesense @HeartSaVioR
Thank you for the suggestion, I will fix it asap.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1410#discussion_r64682353
--- Diff:
external/sql/storm-sql-kafka/src/jvm/org/apache/storm/sql/kafka/CsvScheme.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1410#issuecomment-219603443
Btw, how about adding TSV? It's similar approach to CSV so easy to address.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1410#discussion_r63456723
--- Diff:
external/sql/storm-sql-kafka/src/jvm/org/apache/storm/sql/kafka/KafkaDataSourcesProvider.java
---
@@ -171,12 +171,23 @@ public
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1410#discussion_r63456612
--- Diff:
external/sql/storm-sql-kafka/src/jvm/org/apache/storm/sql/kafka/CsvScheme.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
GitHub user chuanlei opened a pull request:
https://github.com/apache/storm/pull/1410
STORM-1778: scheme extension framework for KafkaSourceProvider and csv sâ¦
feature: scheme extension framework for KafkaSourceProvider and csv scheme
support
You can merge this pull request into
Github user chuanlei closed the pull request at:
https://github.com/apache/storm/pull/1409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
