Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90522761
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90521664
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90522896
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90513444
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90510263
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90464031
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90198668
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90193679
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90195674
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90198469
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90196514
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r9024
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3729 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90192685
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3640 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r90191719
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -0,0 +1,3640 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89806015
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1672,11 +1672,12 @@ public void uncaughtException(Thread thread,
Throwable thrown) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89805725
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -963,11 +963,11 @@
"uptimeSeconds" uptime
"host" host
"port"
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89789081
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java
---
@@ -167,15 +175,21 @@ public static IPrincipalToLocal
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89782717
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -242,11 +297,12 @@
(.stop (:nimbus-thrift-server cluster-map))
Github user abellina commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89393503
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -963,11 +963,11 @@
"uptimeSeconds" uptime
"host" host
"port"
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89672579
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -171,7 +172,56 @@
;; local dir is always overridden in maps
;; can customize the
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89674443
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java
---
@@ -167,15 +175,21 @@ public static IPrincipalToLocal
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89672804
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -242,11 +297,12 @@
(.stop (:nimbus-thrift-server cluster-map))
(catch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89674074
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/nimbus/TopologyStateTransition.java
---
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89674623
--- Diff: storm-core/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1505,19 +1508,18 @@ public static ComponentPageInfo aggCompExecsStats(
*
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89673824
--- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -304,6 +307,41 @@ public void readBlobTo(String key, OutputStream out,
Subject
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89674891
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1672,11 +1672,12 @@ public void uncaughtException(Thread thread,
Throwable thrown) {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89674302
--- Diff: storm-core/src/jvm/org/apache/storm/nimbus/NimbusInfo.java ---
@@ -49,17 +51,17 @@ public static NimbusInfo parse(String nimbusInfo) {
}
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89673963
--- Diff:
storm-core/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
@@ -117,10 +128,60 @@
public ErrorInfo lastError(String
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1744#discussion_r89243737
--- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -304,6 +307,41 @@ public void readBlobTo(String key, OutputStream out,
Subject
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1744
STORM-1276: line for line translation of nimbus to java
There are some things I would like to refactor, but this is a function
tested translation that I would like to get it, at least as a starting
31 matches
Mail list logo
