Github user aandis closed the pull request at:
https://github.com/apache/storm/pull/1798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r93896589
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueStateIterator.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licens
Github user aandis commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r93878165
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueStateIterator.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r93876849
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueStateIterator.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licens
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r93877316
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueStateIterator.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licens
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r92644823
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -161,13 +153,19 @@ public V get(K key, V defau
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r92643170
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -52,4 +55,9 @@
* @param key the key
*/
V del
Github user aandis commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90408316
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping is foun
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90406354
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping is
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90406042
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping
Github user aandis commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90405070
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping is foun
Github user aandis commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90398126
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping is foun
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1798#discussion_r90301167
--- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java ---
@@ -45,4 +47,9 @@
* @return the value or defaultValue if no mapping
GitHub user aandis opened a pull request:
https://github.com/apache/storm/pull/1798
Storm 2203 Add a getAll method to KeyValueState interface
Adds a `getAll` to `InMemoryKeyValueState` and `RedisKeyValueState`. I'll
add tests once the changes are approved.
You can merge this pull r
14 matches
Mail list logo
