[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2390 ---

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r14772 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/FixedGroupsMapping.java --- @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r147775339 --- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java --- @@ -92,6 +93,19 @@ public static void

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r147774596 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -159,14 +159,6 @@ public static final String

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r147744419 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SimpleACLAuthorizer.java --- @@ -80,6 +80,7 @@ } protected

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r147744518 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/FixedGroupsMapping.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r147744169 --- Diff: storm-client/src/jvm/org/apache/storm/blobstore/BlobStoreAclHandler.java --- @@ -45,6 +47,7 @@ public class BlobStoreAclHandler {

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2390#discussion_r147744795 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -159,14 +159,6 @@ public static final String

[GitHub] storm pull request #2390: [STORM-2790] Add nimbus admins groups

2017-10-27 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2390 [STORM-2790] Add nimbus admins groups You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishorvpatil/incubator-storm add-admin-groups