[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148330545 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java --- @@ -249,6 +250,15 @@ public Object getState() { }

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148327252 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -451,6 +451,12 @@ public static final String TOPOLOGY_METRICS_CONSUMER_REGISTER =

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148328987 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148329501 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148330111 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148328743 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148328916 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148328186 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148330213 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java --- @@ -249,6 +250,15 @@ public Object getState() { }

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148327705 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package

[GitHub] storm pull request #2399: Track network data metrics STORM-2793

2017-11-01 Thread jmartell7
Github user jmartell7 commented on a diff in the pull request: https://github.com/apache/storm/pull/2399#discussion_r148328791 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java --- @@ -17,44 +17,102 @@ */ package