[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2538 ---

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165859312 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165859143 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165858606 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857516 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857829 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +460,37 @@ public Builder(String

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857620 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857949 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857479 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -142,7 +139,7 @@ public void open(Map

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857745 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857816 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -453,37 +460,37 @@ public Builder(String

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165857469 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -75,8 +75,9 @@ public boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854760 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854507 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -469,11 +437,14 @@ private boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854506 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854458 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854399 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854164 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165854105 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853833 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853784 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -142,7 +139,7 @@ public void open(Map

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853798 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853341 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852737 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -469,11 +437,14 @@ private boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852835 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852864 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853160 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852696 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853240 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -311,7 +273,10 @@ public void nextTuple() {

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852272 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -142,7 +139,7 @@ public void open(Map

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852670 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -396,7 +361,10 @@ private void

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165853046 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -469,11 +437,14 @@ private boolean

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2538#discussion_r165852989 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java --- @@ -0,0 +1,90 @@ +/* + *

[GitHub] storm pull request #2538: STORM-2913: Add metadata to at-most-once and at-le...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2538 STORM-2913: Add metadata to at-most-once and at-least-once commits https://issues.apache.org/jira/browse/STORM-2913 This builds on STORM-2914. I believe we can resolve STORM-2913 by