Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2704
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194145119
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194141182
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194140703
--- Diff: storm-client/pom.xml ---
@@ -172,7 +172,7 @@
**/generated/**
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194139729
--- Diff: storm-client/pom.xml ---
@@ -172,7 +172,7 @@
**/generated/**
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194139661
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193493524
--- Diff:
storm-client/src/jvm/org/apache/storm/pacemaker/codec/ThriftEncoder.java ---
@@ -12,59 +12,54 @@
package org.apache.storm.pacemaker.codec;
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193481874
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -135,19 +141,29 @@
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193463579
--- Diff:
storm-client/src/jvm/org/apache/storm/pacemaker/codec/ThriftEncoder.java ---
@@ -12,59 +12,54 @@
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193452701
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -135,19 +141,29 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193462962
--- Diff: storm-core/pom.xml ---
@@ -456,29 +456,29 @@
- org.apache.storm
-
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193462736
--- Diff: storm-core/pom.xml ---
@@ -365,17 +365,17 @@
${basedir}/src/resources
-
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193462295
--- Diff:
storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java ---
@@ -83,48 +88,51 @@ public PacemakerServer(IServerMessageHandler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193461968
--- Diff:
storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java ---
@@ -100,23 +99,25 @@ public PacemakerClient(Map config,
String host) {
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193438481
--- Diff:
storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java ---
@@ -83,48 +88,51 @@ public PacemakerServer(IServerMessageHandler
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193438066
--- Diff: storm-core/pom.xml ---
@@ -456,29 +456,29 @@
- org.apache.storm
-
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193437756
--- Diff: storm-core/pom.xml ---
@@ -140,7 +140,7 @@
data.codec
test
-
+
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193437909
--- Diff: storm-core/pom.xml ---
@@ -365,17 +365,17 @@
${basedir}/src/resources
-
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193437501
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java
---
@@ -40,94 +41,39 @@ public void add(TaskMessage taskMsg) {
}
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193437371
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java
---
@@ -40,94 +41,39 @@ public void add(TaskMessage taskMsg) {
}
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193436981
--- Diff:
storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java ---
@@ -100,23 +99,25 @@ public PacemakerClient(Map config,
String host) {
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193436151
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerPipelineFactory.java
---
@@ -12,28 +12,40 @@
package
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193434753
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/SaslStormClientHandler.java
---
@@ -41,80 +38,88 @@ public
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193270523
--- Diff: pom.xml ---
@@ -109,7 +109,7 @@
Committer
-
+
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193270487
--- Diff: pom.xml ---
@@ -82,7 +82,7 @@
Committer
-
+
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2704
STORM-1038: Upgrade to Netty 4
This is a continuation of the work done at
https://github.com/apache/storm/pull/728.
### Important changes:
* Split MessageEncoder into multiple encoders
26 matches
Mail list logo
