[GitHub] storm pull request #2744: [STORM-3132] Avoid NPE in the Values Constructor

2018-10-16 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2744#discussion_r225509252 --- Diff: storm-client/test/jvm/org/apache/storm/tuple/ValuesTest.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2744: [STORM-3132] Avoid NPE in the Values Constructor

2018-10-16 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2744#discussion_r225509106 --- Diff: storm-client/src/jvm/org/apache/storm/tuple/Values.java --- @@ -23,9 +23,13 @@ public Values() { } public

[GitHub] storm pull request #2744: [STORM-3132] Avoid NPE in the Values Constructor

2018-10-15 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2744#discussion_r225330762 --- Diff: storm-client/src/jvm/org/apache/storm/tuple/Values.java --- @@ -23,9 +23,13 @@ public Values() { } public Values(Object...

[GitHub] storm pull request #2744: [STORM-3132] Avoid NPE in the Values Constructor

2018-07-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2744#discussion_r202568702 --- Diff: storm-client/test/jvm/org/apache/storm/tuple/ValuesTest.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2744: [STORM-3132] Avoid NPE in the Values Constructor

2018-07-09 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2744#discussion_r201218268 --- Diff: storm-client/src/jvm/org/apache/storm/tuple/Values.java --- @@ -23,9 +23,13 @@ public Values() { } public

[GitHub] storm pull request #2744: [STORM-3132] Avoid NPE in the Values Constructor

2018-06-29 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2744 [STORM-3132] Avoid NPE in the Values Constructor `Values` construction could end up throwing NPE. You can merge this pull request into a Git repository by running: $ git pull