[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2762 ---

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202431877 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202431655 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,24 @@ public void

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202346634 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202345723 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,24 @@ public void

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202344217 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,24 @@ public void channelRead(ChannelHandlerContext

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202344011 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202343846 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202343054 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202342969 --- Diff: storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202342773 --- Diff: storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202341617 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202300189 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void channelRead(ChannelHandlerContext

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-13 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202299829 --- Diff: storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-12 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2762#discussion_r202196741 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java --- @@ -47,12 +47,20 @@ public void

[GitHub] storm pull request #2762: STORM-3148: Avoid threading issues with kryo

2018-07-12 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2762 STORM-3148: Avoid threading issues with kryo I am going to run some perf tests just to be sure, but the only real impact should be slightly more memory usage, and no more than we have to 1.x