[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209381686 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209367723 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209367613 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209367421 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209367121 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209366165 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209365696 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209363589 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209354005 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209348428 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4745,194 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209341987 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2865,16 +2890,14 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209337293 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209336348 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209335050 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209333494 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209333088 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209331742 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209312212 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209311621 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209311426 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209306763 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209305125 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209304885 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209303203 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209302512 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209154625 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-10 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209154387 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209100932 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209084882 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209083160 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209081264 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() { Cluster

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209064682 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() { Cluster

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209059400 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209048016 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209045056 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() { Cluster

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209044589 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() { Cluster

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209042043 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2918,6 +2943,10 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209041653 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209039674 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2918,6 +2943,10 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209034728 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209029787 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209029163 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209029068 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209028432 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2871,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209016305 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208965124 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208987159 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208984273 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2871,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r209007420 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208986783 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208965019 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2918,6 +2943,10 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208988762 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208991078 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208986545 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208998511 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208997165 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208987578 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208982864 --- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java --- @@ -39,6 +42,11 @@ public String getId() { return getNodeId()

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208976776 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208975129 --- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java --- @@ -39,6 +42,11 @@ public String getId() { return getNodeId() + ":"

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208972356 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208971197 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208970512 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208970103 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208970052 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208968787 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208968475 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() { Cluster

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208968113 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208967564 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208967428 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208966535 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-09 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208965327 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208748740 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208749692 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208751049 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208749524 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208749175 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208748414 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208749367 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2219,21 +2305,16 @@ private void mkAssignments(String

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208747514 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208746949 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2131,17 +2223,13 @@ private void mkAssignments(String

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208746736 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208746266 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208746090 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208745736 --- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java --- @@ -39,6 +42,11 @@ public String getId() { return getNodeId()

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208744273 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -,13 +2231,23 @@ private void mkAssignments(String

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread zd-project
Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208743919 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java --- @@ -52,6 +52,7 @@ public void

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208714291 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208704942 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2826,9 +2915,22 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208721202 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2219,21 +2305,16 @@ private void mkAssignments(String scratchTopoId)

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208699933 --- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java --- @@ -39,6 +42,11 @@ public String getId() { return getNodeId() + ":"

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208703156 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -780,15 +870,15 @@ private static int numUsedWorkers(SchedulerAssignment

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208707855 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2131,17 +2223,13 @@ private void mkAssignments(String scratchTopoId)

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208705728 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -1984,11 +2074,13 @@ private int fragmentedCpu() { Cluster

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208721916 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2807,16 +2897,15 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208703338 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -411,6 +431,10 @@ private final StormTimer timer;

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208720133 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208718858 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208709991 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

2018-08-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2764#discussion_r208714561 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -735,39 +756,108 @@ private static int

  1   2   >