Re: [RESULT] [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-29 Thread Julien Nioche
Hi Jungtaek, That's strange. It shows as sent but I can't see it in the archives indeed. Here is what I had reported *-1* *I've just compiled 1.1.0 and found that it has the same issue I found yesterday with 1.0.3 https://issues.apache.org/jira/browse/STORM-2428

Re: [RESULT] [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-29 Thread Jungtaek Lim
Julien, I can't see your post in RC3 thread, both my inbox and also mail archive. http://mail-archives.apache.org/mod_mbox/storm-dev/201703.mbox/%3C0F8C6435-28BA-4D89-9818-C438575EAC1E%40apache.org%3E Recently I experienced posting to storm-dev@ sometimes fails 'silently'. After that I check

Re: [RESULT] [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-29 Thread Julien Nioche
Hi, For the record and not that it changes the outcome of the vote but I had expressed a -1 on the 22th March. Julien On 28 March 2017 at 22:09, P. Taylor Goetz wrote: > This vote is now closed and passes with X binding +1 votes, X non-binding > +1 votes, and no -1 or 0

[RESULT] [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-28 Thread P. Taylor Goetz
This vote is now closed and passes with X binding +1 votes, X non-binding +1 votes, and no -1 or 0 votes. Vote tally (* indicates a binding vote): +1 Jungtaek Lim* Arun Mahadevan* Bobby Evans* Harsha Chintalapani* Hugo Da Cruz Louro* Satish Duggana* Alexandre Vermeerbergen P. Taylor Goetz* I

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-28 Thread P. Taylor Goetz
+1 (binding) - Verified distribution structure - Verified examples build as packaged - Set up a small cluster and deployed/tested examples -Taylor > On Mar 21, 2017, at 3:26 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.1.0 (rc3) > >

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-27 Thread Alexandre Vermeerbergen
Hello, +1: I have finally (after having understood how to generate the "external" .jar files) been able to test our Supervision topologies (10 topologies) on a small cluster: * 1 VM dedicated to Nimbus * 2 VM dedicated to Supervisor * 3 VM dedicated to Zookeeper * Connected to a Kafka

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-27 Thread Jungtaek Lim
Sorry I was not aware of the requirement of build for Flux. Unfortunately there seemed to be build error on Flux because Flux test case requires "node" (NodeJS). I think we would be better to remove the requirement since it might also blocks tests running on ASF Jenkins. You can do "mvn clean

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-27 Thread Alexandre Vermeerbergen
Hello, I finally found an explanation of why "flux-core.1.1.0.jar" in external/flux/README.md : it says that Node.js is required ; or it gives the following alternative: Building with unit tests disabled: If you would like to build Flux without installing Python or Node.js you can simply

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-27 Thread Jungtaek Lim
Hi Alexandre, If you build Storm code from root directory, Flux modules should be built and jars should be available in each target directory. - flux-core-1.1.0.jar: external/flux/flux-core/target - flux-wrappers-1.1.0.jar: external/flux/flux-wrappers/target Btw, with dependency management tool

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-27 Thread Alexandre Vermeerbergen
Hello, I was able to build storm-kakfa-1.1.0.jar using "mvn clean install" started from root directory of expanded archive of storm-1.1.0 RC3 source distribution. But now my tests are failing before I'm missing the following JAR file: flux-core-1.1.0.jar I am sure that it was part of Storm

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-26 Thread Jungtaek Lim
You can just build it with "mvn clean package". Btw, since we just removed shading from external libraries (previously some modules did, and some others didn't), it may not enough to just copy built jar. You also need to copy transitive dependencies too. That's why we recommend using dependency

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-26 Thread Alexandre Vermeerbergen
Hello, Where is the documentation explaining how to generate the .jar files that used to be in external/*/* directories? I haven't tested our apps with 1.1.0rc3, I would like to do it with using instructions for generating storm-kafka.jar / storm-hbase.jar / ... binary artifacts. Best regards,

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-26 Thread Jungtaek Lim
Since there's no -1 vote for binding/non-binding, please put opinions on what Arun stated. Personally I don't think it's blocker for release. The main reason of change - size issue for binary dist. - was discussed enough, and though we discussed shortly we were in consensus that we remove binary

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-24 Thread Hugo Da Cruz Louro
+1 (binding) - unzipped .zip sources and binaries - mvn clean install in unzipped sources - created uber jar for storm-solr and storm-kafka-client - tested storm-solr and storm-kafka-client in local cluster mode and remode cluster mode The issue

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-24 Thread Jungtaek Lim
1. I'm OK to contain uber jar only for storm-starter, as example for starter. The size should be smaller enough if we remove connector dependencies in storm-starter. Currently it depends on storm-hdfs, storm-hbase, storm-redis, and we could move out some topologies to remove dependencies. 2. Yeah

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-24 Thread Arun Mahadevan
>Could you cast your vote? If you are still not satisfied with excluding >jars you can cast -0 or even -1. I am not fully convinced with the current binary distribution. 1. Why do we expect users to build the examples source from the binary distribution? Since these are most likely to be used

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-24 Thread Satish Duggana
+1 for RC3 and minor release with recent major/critical bug fixes in few weeks time. Most of the storm-kafka-client issues are resolved. Hugo, You may want to vote again as you have changed your opinion mentioned in your earlier mail. Taylor, It seems Hugo said this issue can be considered as

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread Jungtaek Lim
I'm OK to continue release process if we plan to do bugfix release sooner. (say, within 1 month, or just after all opened storm-kafka-client issues will be addressed.) We have other storm-kafka-client issues which are all major or critical but not included to RC3 as well. Having them in 1.1.0 is

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread Harsha Chintalapani
I propose that we continue with the release and get this patch in next minor release (probably 1.1.1?). Users doesn't need to upgrade their cluster to get this change so I would say this is not a show-stopper for the release. -Harsha On Thu, Mar 23, 2017 at 9:18 AM P. Taylor Goetz

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread P. Taylor Goetz
Hugo, now that you are a PMC member your vote is binding. While releases can’t be vetoed (a release vote needs at least three +1s and more +1s than -1s), it’s typical to take negative votes under serious consideration. So considering Hugo’s -1 vote, do we want cancel in order to include the

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread Hugo Da Cruz Louro
Since this is an external module connector perhaps we can get this fix onto a minor release instead of being a blocker. I will update the JIRA accordingly. > On Mar 23, 2017, at 8:58 AM, Hugo Da Cruz Louro > wrote: > > -1 (non binding) > > This blocker bug was just

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread Hugo Da Cruz Louro
-1 (non binding) This blocker bug was just reported - https://issues.apache.org/jira/browse/STORM-2432 Here is the fix: https://github.com/apache/storm/pull/2027 I consider that this is a blocker bug because if the user choses UNCOMITTED_LATEST first poll strategy, no data gets polled at all.

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread Harsha Chintalapani
+1 for documenting and releasing. -Harsha On Thu, Mar 23, 2017 at 7:04 AM Jungtaek Lim wrote: > +1 to the latter. > > I'm in favor of documenting the change to release note, and also docs so > that website can be reflected. The users who are affected to the change > wouldn't

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread Jungtaek Lim
+1 to the latter. I'm in favor of documenting the change to release note, and also docs so that website can be reflected. The users who are affected to the change wouldn't be much, since using dependency management tool (Maven, Gradle, and so on) has been recommended for creating topology jar.

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-23 Thread P. Taylor Goetz
Do we want to cancel this RC in order to better document the changes, or will documenting it in the release announcement suffice for now (provided documentation is added for subsequent releases)? I’m partial to the latter, but am open to others’ opinions. -Taylor > On Mar 22, 2017, at 9:49

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-22 Thread Bobby Evans
+1 I built form the tag and ran using a single node cluster. The examples and external components are excluded because they are huge.  Because of shading they we distribute the same copy of them multiple times. I agree with Alexandre.  We should document this change better, because it is

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-22 Thread Arun Mahadevan
Verified the artifacts. Compiled examples and ran some sample topologies. Looks good. BTW, why are the external modules excluded from the binaries (the .zip and .tar.gz). Isn’t it better if the binary distribution includes them? Maybe it was already discussed but I am missing it. The sql

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-22 Thread Jungtaek Lim
Alexandre, You can download RC3 "source", and build with "mvn clean install" to install artifacts locally, so that Maven recognizes Storm 1.1.0 artifacts from local Maven repo. You may want to remove them from local Maven repo after Storm 1.1.0 is officially released. If you need to copy

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-22 Thread Alexandre Vermeerbergen
Hello, We have our homebrewed tool for compiling our code, and "linking it against" third party JAR files. We have customized this tool to create "big .jar files" corresponding to our storm topologies. The idea is that we checkin all the third party dependencies of a given release of our

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-22 Thread Jungtaek Lim
+1 (binding) > source - verify file (signature, MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 7 -- source, tar.gz : OK - build source dist --

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-21 Thread P. Taylor Goetz
Hi Alexandre, If you don't mind me asking, what is your process for creating your topology jars? Once a release is approved, all artifacts are available in the Maven mirrors and can be downloaded with a curl command or a browser. You will still have to deal with transient dependencies, which

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-21 Thread P. Taylor Goetz
I forgot to say thank you for the feedback on the release candidate! Feedback, positive or negative, is always welcome and a great way to get involved in the project. -Taylor > On Mar 21, 2017, at 6:37 PM, P. Taylor Goetz wrote: > > Hi Alexandre, > > If you don't mind me

Re: [VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-21 Thread Alexandre Vermeerbergen
Hello, Unlike with Storm 1.1.0 RC2, storm-kafka-1.1.0.jar is missing from /external/storm-kafka This directory only contains README.md, which doesn't explains how to get storm-kafka-1.1.0.jar. Would it be possible to have some detailled instructions on how to build storm-kafka-1.1.0.jar

[VOTE] Release Apache Storm 1.1.0 (RC3)

2017-03-21 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 1.1.0 (rc3) Full list of changes in this release: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;h=68fbab3c4f91359bd397d93a157830542839b002;hb=e40d213de7067f7d3aa4d4992b81890d8ed6ff31 The tag/commit to be voted