Re: Question: ways to handle inactive pull requests

2017-09-15 Thread Bobby Evans
Yes I agree it should be on a case by case basis, no need for anything formal, it is just being a nice person and explaining to everyone why you are doing something. - Bobby On Fri, Sep 15, 2017 at 4:19 AM Jungtaek Lim wrote: > Thanks for all your voices. > > Regarding

Re: Question: ways to handle inactive pull requests

2017-09-15 Thread Jungtaek Lim
Thanks for all your voices. Regarding question, I'm not sure we can define the time and frequency for that. I don't mean to build a new item for bylaw. That actually depends on individual, and how much the issue is urgent. For example, we can't just wait author for inactive pull request

Re: Question: ways to handle inactive pull requests

2017-09-14 Thread Hugo Da Cruz Louro
Agree. Question is what is the reasonable time frame for a response, and how many times one should reach out to a person asking for a response. > On Sep 14, 2017, at 8:43 AM, Stig Rohde Døssing > wrote: > > I agree, if the original author is not responding it seems

Re: Question: ways to handle inactive pull requests

2017-09-14 Thread Stig Rohde Døssing
I agree, if the original author is not responding it seems totally fine to me for someone else to finish up a PR. If the new PR is based on the previous effort, I think we should be careful to always preserve authorship information. The easiest way is probably to keep the original commits. Ideally

Re: Question: ways to handle inactive pull requests

2017-09-14 Thread Bobby Evans
I totally agree. If you have reached out to an author and there has been no response for either a bug fix or a feature that you want, then feel free to take it over. Just be polite about it and make sure it is clear to everyone what you are doing. - Bobby On Wed, Sep 13, 2017 at 11:19 PM

Question: ways to handle inactive pull requests

2017-09-13 Thread Jungtaek Lim
Hi devs, I have seen some old pull requests for bugfix and new feature going to be stale. Some of us tried to ping to author several times but not respond in some months. For new feature we may have to wait for authors, but for bugfix waiting authors means we are aware of the bug but we don't fix