[GitHub] storm pull request #2853: STORM-2963 Adding notes on GC to Performance.md

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2853 ---

[GitHub] storm pull request #2858: STORM-3242: Adds "examples" and "externals" profil...

GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/2858 STORM-3242: Adds "examples" and "externals" profiles The existing modules have been moved into like-named Maven profiles that are enabled by default. They can be disabled, for example,

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

Github user d2r commented on the issue: https://github.com/apache/storm/pull/2858 Agree. If there are errors/failures in travis-ci, then I will take a look. ---

[GitHub] storm pull request #2855: STORM-3240 health checks should succeed on exit co...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2855#discussion_r222091724 --- Diff: storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java --- @@ -106,13 +106,13 @@ public void run() {

[GitHub] storm issue #2855: STORM-3240 health checks should succeed on exit code 0

Github user agresch commented on the issue: https://github.com/apache/storm/pull/2855 @revans2 - I am not familiar with previous releases. Can you explain what you mean by something changing in this release? Are you saying this bug also exists in the other lines? ---

[GitHub] storm issue #2855: STORM-3240 health checks should succeed on exit code 0

Github user agresch commented on the issue: https://github.com/apache/storm/pull/2855 @revans2 - took a guess at what you wanted documented. If this isn't what you want, just let me know. ---

[GitHub] storm pull request #2855: STORM-3240 health checks should succeed on exit co...

Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2855#discussion_r222096924 --- Diff: storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java --- @@ -106,13 +106,13 @@ public void run() {

[GitHub] storm issue #2855: STORM-3240 health checks should succeed on exit code 0

Github user agresch commented on the issue: https://github.com/apache/storm/pull/2855 Missed @revans2 last comment. But the String is used here: https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java#L60 ---

[GitHub] storm pull request #2855: STORM-3240 health checks should succeed on exit co...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2855#discussion_r222100110 --- Diff: storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java --- @@ -106,13 +106,13 @@ public void run() {

[GitHub] storm issue #2855: STORM-3240 health checks should succeed on exit code 0

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2855 And if we can get rid of the code returning a string for success or failure, please lets do that, especially since it is thrown away. ---

[GitHub] storm issue #2855: STORM-3240 health checks should succeed on exit code 0

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2855 I am fine with making breaking changes if it is going to make everything cleaner. This was originally based off of how Hadoop does this in hopes of being able to reuse scripts, but that didn't

[GitHub] storm pull request #2855: STORM-3240 health checks should succeed on exit co...

Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2855#discussion_r222100581 --- Diff: storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java --- @@ -106,13 +106,13 @@ public void run() {

[GitHub] storm issue #2855: STORM-3240 health checks should succeed on exit code 0

Github user agresch commented on the issue: https://github.com/apache/storm/pull/2855 @kishorvpatil - thanks for the explanation. I do like this behavior better. ---