[DISCUSS] Release Storm 1.1.0

2016-09-29 Thread Jungtaek Lim
Hi devs, It's been 5 months after releasing Storm 1.0.0, and now 1.x branch has lots of CHANGELOG and also pending reviews. It's also been a long time after 1.1.0 RC1 is canceled. I think it may be good to put some efforts to review and merge pending pull requests (except things which takes time

[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch

2016-09-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1591 Please rebase and force push accordingly. Your PR now has all of the commits from other side. You can give it an another try: 1) create new branch based on recent master or 1.x 2)

[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch

2016-09-29 Thread hsun-cnnxty
GitHub user hsun-cnnxty reopened a pull request: https://github.com/apache/storm/pull/1591 STORM-1038: Upgrade netty to 4.x in 1.x-branch This is to add the feature to 1.x-branch. The original PR for master branch is #728. You can merge this pull request into a Git repository by

[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch

2016-09-29 Thread hsun-cnnxty
Github user hsun-cnnxty closed the pull request at: https://github.com/apache/storm/pull/1591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097

2016-09-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1687 Since it does load the two modules - storm-kafka and storm-kafka-client - but only load kafka-client with `${storm.kafka.client.version}`. Does storm-starter work with both storm-kafka and

[GitHub] storm issue #1685: STORM-2097: Improve logging in trident core and examples

2016-09-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1685 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-09-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1714 Another head up: my patch got merged to Calcite master, and Calcite dev@ is discussing about releasing new minor version soon. --- If your project is set up for it, you can reply to this email

[GitHub] storm issue #1685: STORM-2097: Improve logging in trident core and examples

2016-09-29 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1685 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1668: STORM-2040 Fix bug on assert-can-serialize

2016-09-29 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1668 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1720: STORM-1546: Adding Read and Write Aggregations for...

2016-09-29 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/1720 STORM-1546: Adding Read and Write Aggregations for Pacemaker to make it HA compatible (1.x-branch) 1.x-branch version of Pacemaker-HA You can merge this pull request into a Git repository by

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-29 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r81219539 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -926,10 +926,10 @@ public static final String UI_HTTPS_NEED_CLIENT_AUTH =

Re: [DISCUSS] Plan for merge SQE and Storm SQL

2016-09-29 Thread P. Taylor Goetz
FYI, I’ve merged the SQE code and documentation into the sqe_import branch: https://github.com/apache/storm/tree/sqe_import Note the build will fail on the last component (storm-sqe) due to the compilation issues mentioned earlier. -Taylor >

Re: Error while building locally

2016-09-29 Thread Sonu B
Following is the result of git status command > git status -- On branch master Your branch is up-to-date with 'origin/master'. Untracked files: (use "git add ..." to include in what will be committed)

[GitHub] storm issue #1647: Get rid of compiler plugin setting for external modules

2016-09-29 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1647 @HeartSaVioR Thanks I pulled this into master, 1.x and 1.0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request #1647: Get rid of compiler plugin setting for external mo...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1647: Get rid of compiler plugin setting for external modules

2016-09-29 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1647 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1684: [STORM-2093] Fix permissions in multi-tenant, secure mode

2016-09-29 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1684 I agree with @HeartSaVioR could you please change the commit message to something more like the pull request title? ``` git commit --amend ``` should do it for you. --- If

[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-09-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1714 Just a head up: my patch for Calcite (https://github.com/apache/calcite/pull/283) passes the review and in progress of merging. (handling some comment fixes.) So I'm expecting that we

[GitHub] storm pull request #1716: STORM-2126: fix NPE due to race condition in compu...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] Plan for merge SQE and Storm SQL

2016-09-29 Thread Bobby Evans
Agreed, or if we can find a way to not break compatibility (like perhaps having a common base class for most of the logic and one subclass that uses a string while another that uses the byte array).   - Bobby On Thursday, September 29, 2016 10:05 AM, Jungtaek Lim

Re: [DISCUSS] Plan for merge SQE and Storm SQL

2016-09-29 Thread Jungtaek Lim
The change on storm-redis seems to require breaking backward compatibility, so I would love to see another pull request to integrate it via general review process. If it can be integrated to SQE without changing storm-redis, that would be nice. Does it make sense? - Jungtaek Lim (HeartSaVioR)

[GitHub] storm pull request #1718: Storm 2124 show requested cpu mem for each compone...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1718: Storm 2124 show requested cpu mem for each component 1x

2016-09-29 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1718 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Error while building locally

2016-09-29 Thread Jungtaek Lim
Hi Sonu, if you clone the code, could you check git status and / or git diff to see the change if any? I'm not an Windows user, but showing version as 2.0.0 is strange and I haven't heard similar issues. - Jungtaek Lim