Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86894060
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -0,0 +1,85 @@
+/*
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86846400
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -0,0 +1,85 @@
+/*
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86893341
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,19 +266,22 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86895288
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java
---
@@ -0,0 +1,250 @@
+/*
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86846452
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java
---
@@ -0,0 +1,85 @@
+/*
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86892802
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -479,16 +487,17 @@ public OffsetAndMetadata
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r79797993
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,26 +266,32 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86892941
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,26 +266,32 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r79800258
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -479,16 +482,17 @@ public OffsetAndMetadata
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1765
STORM-2190: reduce contention between submission and scheduling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1764
STORM-2190: reduce contention between submission and scheduling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1757
@harshach @HeartSaVioR I am fine either way. @HeartSaVioR, of all the
alternatives that we discussed, can you please let me know which one you prefer
? It should be an easy fix, and I can either
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1757
@hmcl already +1ed on other PR.
@HeartSaVioR @hmcl we can handle cleaning up examples in another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
@revans2 reviewing this at this moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1759
@HeartSaVioR Are you using harshach's script to merge these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
I worry that making it a priority to have rolling upgrades between major
versions significantly restricts the kinds of changes that we can make,
including some kinds of changes that a major version increment is supposed to
mark. I'm not really in support of trying to do that.
If we can't make
Let's distinguish between wire compatibility changes and API compatibility
changes, along with impact to workers vs impact to clients.
For 3) splitting the classpath up for each daemon wire compatibility is not
impacted, but we are potentially removing a bunch of APIs from the worker and
client
Can you provide a hypothetical example for how #3 might break something for
users?
It seems like most of the cases of backward incompatibility are not
typical/average use cases, and that rolling upgrades would only be affected in
certain edge cases. If that’s the case then I’m fine with the
For all of these we should be able to support a rolling upgrade from 1.x with
some caveats.
1) There are a few possibilities on how to make this happen, but none of them
are ideal. If you feel strongly about a rolling upgrade I might skip this.
2) would work for all workers that do not access
My only concern here is the rolling upgrade of storm cluster. We supported
the rolling upgrade going to 0.10 and broke it because of storm 1.x
release. Users are not inclined to upgrade to a new release if it's not
rolling upgradable. In this case, it looks like we are going to break this.
Correct
Made a mistake and put something on private that never should have been there.
Here is the discussion in full so far.
In response to Jungtake removing the nocamel option will change set_bar/get_bar
in the generated thrift code to setBar/getBar. So any thrift object that
clients interact with
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1759
@knusbaum I merged 1.x and 1.0.x branch. Could you close this PR?
Auto-closing PR doesn't work with PR which is not against master branch.
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@sachingsachin Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1761
+1 KafkaConsumer seems to be initialized for each task (so used from only
one thread), and so as ConsumerNetworkClient in KafkaConsumer.
---
If your project is set up for it, you can reply to
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1759
+1 Commit message should be modified but can be handled while merging.
(Same as PR for master)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1758
+1. Commit message should be modified but can be handled while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1762
I think we need to do this. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1763
Great finding. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86734548
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/CachedSchemas.java
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86734617
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
33 matches
Mail list logo
