[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user ambud commented on the issue: https://github.com/apache/storm/pull/1783 Sure thing, I will add the Guava patch code originally added for this to 1.x and 0.10.x branches --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1783 @ambud Yeah if we add unit test for the feature, unit test will fail on JDK 7 which will be always failing on Travis CI. Nice catch. Could you address this to use Guava for 1.x? --- If

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user ambud commented on the issue: https://github.com/apache/storm/pull/1783 Caffeine is JDK 8 only so won't work for 1.x, since JDK 7 compilation will be tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [ANNOUNCE] New Storm Commiter/PMC Member: Xin Wang

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Congrats! On 11/30/16 8:43 PM, Jungtaek Lim wrote: > Please join me in welcoming Xin Wang as a new Apache Storm > Committer and PMC member. > > Xin Wang has showed strong commitment to the Apache Storm community > via code contributions for a long

[ANNOUNCE] New Storm Commiter/PMC Member: Xin Wang

Please join me in welcoming Xin Wang as a new Apache Storm Committer and PMC member. Xin Wang has showed strong commitment to the Apache Storm community via code contributions for a long time spanning both core and as well as integration components. He also has showed active participation on

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1783 @ambud I'm OK to use Guava for 1.x. IMHO it would be better to provide complete set of features for guaranteed environment (JDK version) instead of leaving 'warn' to documentation. And some

[GitHub] storm pull request #1807: fix NullPointException with acked.get(rtp)

GitHub user cutd opened a pull request: https://github.com/apache/storm/pull/1807 fix NullPointException with acked.get(rtp) acked.get(rtp) maybe null when antocommit is true. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #1805: STORM-2224 Exposed a method to override in computi...

Github user satishd closed the pull request at: https://github.com/apache/storm/pull/1805 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1805: STORM-2224 Exposed a method to override in computing the ...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1805 This PR is merged into master and 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1801: STORM-2220 Added passing cassandra config to individual C...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1801 This PR is merged into master and 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #1801: STORM-2220 Added passing cassandra config to indiv...

Github user satishd closed the pull request at: https://github.com/apache/storm/pull/1801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1765: STORM-2190: reduce contention between submission and sche...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1765 One question about the for loop in WordCountTopology. I'm +1 once that's answered/addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1764 One question about the for loop in WordCountTopology. I'm +1 once that's answered/addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request #1764: STORM-2190: reduce contention between submission a...

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1764#discussion_r90317672 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java --- @@ -90,7 +90,9 @@ public static void main(String[] args) throws

[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1765#discussion_r90317167 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/WordCountTopology.java --- @@ -90,7 +90,9 @@ public static void main(String[] args) throws

[GitHub] storm issue #1786: STORM-1281: LocalCluster, testing4j and testing.clj to ja...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1786 +1. I haven't done any manual testing of this patch, but I reviewed the code and it looks good. I wouldn't mind seeing more javadoc comments in some of the new classes/interfaces, but it

[GitHub] storm pull request #1786: STORM-1281: LocalCluster, testing4j and testing.cl...

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1786#discussion_r90311211 --- Diff: storm-core/src/jvm/org/apache/storm/testing/CompletableSpout.java --- @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation

Re: [DISCUSS] Feature Branch for Apache Beam Runner

Erik is correct, that is the right branch. It was initially unmodified, but I just merged the initial pull request so others are open to create pull requests against that branch now. -Taylor > On Nov 23, 2016, at 1:07 PM, Erik Weathers > wrote: > > Hugo, > >

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r90301167 --- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java --- @@ -45,4 +47,9 @@ * @return the value or defaultValue if no mapping

[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1800 +1. Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user ambud commented on the issue: https://github.com/apache/storm/pull/1783 Added documentation to readme file. Fixed the debug logging by using isDebugEnabled checks Are we going to use Guava caching implementation for 1.x? @HeartSaVioR @revans2 --- If

[GitHub] storm pull request #1745: STORM-2174: Initial Base for Storm Beam Runner

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1801: STORM-2220 Added passing cassandra config to individual C...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1801 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1802: STORM-2209: 1.x-branch Update documents adding new integr...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1802 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1745: STORM-2174: Initial Base for Storm Beam Runner

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1745 @revans2 @arunmahadevan Thanks for the review. I will merge this to the beam runner feature branch so others can submit pull requests against it. @arunmahadevan Yes, the GBK implementation

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1783 +1, but I agree with @HeartSaVioR that the new cache configuration options need to be documented before this is merged. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii thanks for the PR. Merged it to master. Can you also raise a PR for 1.x-branch ? I am getting some merge conflicts while trying to cherry-pick. --- If your project is set up

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user ben-manes commented on the issue: https://github.com/apache/storm/pull/1783 Should fail, e.g. Class version error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1783 @ambud The code looks good except what @vesense commented. Two things more to address: 1. It would be better to document new configurations. Without documentation,

[GitHub] storm pull request #1783: STORM-2204 Adding caching capabilities in HBaseLoo...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1783#discussion_r90260820 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java --- @@ -40,51 +48,81 @@ * */ public class

[GitHub] storm issue #1798: Storm 2203 Add a getAll method to KeyValueState interface

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1798 @aandis Looks great. Could you add tests if possible? You may want to rename the prefix of the title to `STORM-2203` so that it can be linked to JIRA issue automatically. Thanks in

[GitHub] storm pull request #1799: Fixing a bug related to following exception

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1799#discussion_r90252874 --- Diff: storm-core/src/jvm/org/apache/storm/stats/StatsUtil.java --- @@ -1516,7 +1516,7 @@ public static ComponentPageInfo aggCompExecsStats(

[GitHub] storm issue #1801: STORM-2220 Added passing cassandra config to individual C...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1801 Looks good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #1805: STORM-2224 Exposed a method to override in computing the ...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1805 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: moving from storm 0.9.3 to storm 1.0.1

Hi Ohad, You can try setting topology.backpressure.enable: false -Xin Wang (vesense) 2016-11-30 17:58 GMT+08:00 Ohad Edelstein : > We are in the process of upgrading our storm infra from 0.9.3 to 1.0.1 > We are running python in the storm. > We moved for the upgrade from

moving from storm 0.9.3 to storm 1.0.1

We are in the process of upgrading our storm infra from 0.9.3 to 1.0.1 We are running python in the storm. We moved for the upgrade from ubuntu14.04 to ubuntu16.04 What we are seeing are very disappointing results, Out of the box, with about the same basic params set, we see slowness in the new

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90198668 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3729 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90193679 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3729 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90195674 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3729 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90198469 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3729 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90196514 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3729 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r9024 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3729 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90192685 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3640 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r90191719 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -0,0 +1,3640 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1801: STORM-2220 Added passing cassandra config to indiv...

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1801#discussion_r90189064 --- Diff: external/storm-cassandra/src/main/java/org/apache/storm/cassandra/bolt/BaseCassandraBolt.java --- @@ -91,8 +93,12 @@ public

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r90187413 --- Diff: docs/storm-sql-reference.md --- @@ -1312,4 +1313,23 @@ You can use below as working reference for `--artifacts` option, and change depe