[GitHub] storm issue #1835: STORM-2236: Kafka Spout with manual partition management.

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1835 +1 once the merge conflict is resolved. It would probably be good to add some unit tests of the new classes, but I think this can be merged without them. --- If your project is set up for it, you can

[GitHub] storm pull request #1835: STORM-2236: Kafka Spout with manual partition mana...

Github user liurenjie1024 commented on a diff in the pull request: https://github.com/apache/storm/pull/1835#discussion_r93364905 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/fetcher/KafkaRecordsFetchers.java --- @@ -0,0 +1,41 @@

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r93364833 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,252 @@ +/** + * Licensed to the Apache

Request for review: Storm SQL pending PRs

Hi devs, I'd like to ask a request to pending pull requests for Storm SQL. The link refers pull request on Github. Blocker for 1.1.0: - STORM-2200 [Storm SQL] Drop Aggregate & Join support on Trident mode Improvements: - STORM-1446 Compile the Calcite

Re: [DISCUSS] Prioritizing works in progress

Thanks Manu and Taylor for giving your opinions. - Storm SQL improvement There're some huge PRs available but there're all about improvement which shouldn't be blocker for releasing 1.1.0. (I'd like to also include them to 1.1.0 but not sure it can be happen really soon.) I'll send a request for

Re: [DISCUSS] Prioritizing works in progress

Hi Jungtaek, > - Beam runner There’s not been much activity around this, and I haven’t had much time to work on it recently, but there’s a decent foundation to build upon. So it would be fairly easy for others to start contributing to that effort. There’s also interest from the Beam community

[GitHub] storm issue #1816: STORM-2223: PMMLBolt

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1816 @hmcl Do you plan to add unit tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r93312373 --- Diff: storm-dist/binary/final-package/src/main/assembly/binary.xml --- @@ -446,6 +446,29 @@ storm*jar

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 @HeartSaVioR yep. will do in next couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1835: STORM-2236: Kafka Spout with manual partition management.

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1835 @liurenjie1024 once the review is complete and it incorporates the feedback from all the reviewers (I am going through the review now), please squash the commits into one commit, and make sure that

[GitHub] storm pull request #1835: STORM-2236: Kafka Spout with manual partition mana...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1835#discussion_r93294533 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -218,7 +223,11 @@ public void nextTuple() {

[GitHub] storm issue #1818: STORM-2104 1.x

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1818 @HeartSaVioR Thanks, rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r93267533 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,252 @@ +/** + * Licensed to the Apache

Re: [DISCUSS] Prioritizing works in progress

Hi, Please prioritize 2.0.0 release if possible. We have users in China we want it strongly and I think that will also bring in a lot of contributions since the core is Java then. Metrics is another highly valued feature. But if we can only do one thing now, I hope it is 2.0.0 release Thanks,

[GitHub] storm pull request #1836: Merge pull request #2 from apache/master

Github user nilday closed the pull request at: https://github.com/apache/storm/pull/1836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1836: Merge pull request #2 from apache/master

GitHub user nilday opened a pull request: https://github.com/apache/storm/pull/1836 Merge pull request #2 from apache/master merge from origin You can merge this pull request into a Git repository by running: $ git pull https://github.com/nilday/storm master Alternatively you

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r93205875 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,252 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r93205840 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,252 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1764: STORM-2190: reduce contention between submission a...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1764 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1765: STORM-2190: reduce contention between submission a...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1798 @aandis Could you address review comments from @arunmahadevan? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1764 +1 again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm issue #1818: STORM-2104 1.x

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1818 @srdo Could you rebase? I can merge this based on multiple binding +1 after rebasing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub