Re: [DISCUSS] Remove CHANGELOG file

2017-03-09 Thread Jungtaek Lim
This propose will make merge process simpler, so I guess committers/PMCs might not have strong opinions about this. I'm concerning mainly about how it will affect release process. Taylor, I guess you're busy, but could you give your opinion about this as a release manager? Would removing

[DISCUSS] resolving Travis CI build issue

2017-03-09 Thread Jungtaek Lim
Hi team, I found that recent builds from Travis CI just goes pending nearly 1 day. I heard that Travis has max concurrent builds for given account and Apache project all uses same account. And also many Apache projects set up Travis CI. https://travis-ci.org/apache Zeppelin seemed to apply a

Re: [DISCUSS] Remove CHANGELOG file

2017-03-09 Thread Xin Wang
LGTM. I give a +1 for the idea. 2017-03-07 9:29 GMT+08:00 Jungtaek Lim : > Bump. I think it's not that trivial for code merger and release manager, > and even contributors (how to represent their contributions.) > > 2017년 2월 24일 (금) 오전 9:43, Roshan Naik

[GitHub] storm issue #1994: STORM-2403 Fix KafkaBolt test failure: tick tuple should ...

2017-03-09 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1994 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-09 Thread P. Taylor Goetz
I’m fine with dropping connectors from the binary distribution in favor having users use Maven, gradle, etc. handle user dependencies. Building topology jars manually (vs. letting Maven do the heavy lifting) is painful and something to be avoided, specifically for new users. So the “binary

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

2017-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1994: STORM-2403 Fix KafkaBolt test failure: tick tuple ...

2017-03-09 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1994 STORM-2403 Fix KafkaBolt test failure: tick tuple should not be acked * This bug is introduced from [STORM-2387](http://issues.apache.org/jira/browse/STORM-2387) **NOTE: It should be

[GitHub] storm pull request #1993: STORM-2402: KafkaSpout sub-classes should be able ...

2017-03-09 Thread sakanaou
GitHub user sakanaou opened a pull request: https://github.com/apache/storm/pull/1993 STORM-2402: KafkaSpout sub-classes should be able to customize tuple processing We need a `KafkaSpout` that writes unprocessable records to a "dead-letter-topic". For this to function we

[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-09 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1940 Ok, changed the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1940 @ernisv Could you change your commit title to be meaningful? We often set commit title to same as JIRA title. I can take care of other things so you don't need to worry about that. ---

[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-09 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1940 Squashed the commits. About moving to STORM-2296 - I've put the links/relations to STORM-2296. But as the issue itself is already in "resolved" state - not sure how the patch could be added to

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2017-03-09 Thread mazhechao
Github user mazhechao commented on the issue: https://github.com/apache/storm/pull/1136 So is there any update about merging this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request #1935: STORM-2353: Replace kafka-unit by kafka_2.11 and k...

2017-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1935 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1935: STORM-2353: Replace kafka-unit by kafka_2.11 and kafka-cl...

2017-03-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1935 Great! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1940 +1 @ernisv Could you squash commits into one? Btw, I feel this patch should be along with STORM-2296, so if we would want to port this back to 1.0.x, STORM-2296 should be ported back

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

2017-03-09 Thread ernisv
Github user ernisv commented on a diff in the pull request: https://github.com/apache/storm/pull/1940#discussion_r105104946 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java --- @@ -172,6 +187,12 @@ public void fail(Object msgId) {