STORM-2423 for 1.1.0

2017-03-17 Thread Roshan Naik
All, Found a critical issue with JoinBolt that would like to get a fix into 1.1.0. https://issues.apache.org/jira/browse/STORM-2423 -roshan

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

2017-03-17 Thread roshannaik
GitHub user roshannaik opened a pull request: https://github.com/apache/storm/pull/2019 STORM-2423 - Join Bolt should use explicit instead of default window anchoring of emitted tuples Default anchoring will anchor each emitted tuple to every tuple in current window. This requires

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768060 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -84,11 +85,47 @@ public void prepare(Map config,

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768022 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -41,7 +42,8 @@

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768166 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768041 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java --- @@ -84,11 +85,47 @@ public void prepare(Map config,

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768115 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768140 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768148 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768160 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768154 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768176 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java --- @@ -65,77 +57,81 @@ public

[GitHub] storm pull request #1998: Eventhub2

2017-03-17 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1998#discussion_r106768224 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/PartitionManager.java --- @@ -74,8 +74,8 @@ public void ack(String

[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...

2017-03-17 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/2018 STORM-2416: Improve Release Packaging to Reduce File Size This brings the binary distribution file size down from > 200MB to ~79MB. You can merge this pull request into a Git repository by running:

[GitHub] storm pull request #2017: STORM-2416: Release Packaging Improvements

2017-03-17 Thread ptgoetz
Github user ptgoetz closed the pull request at: https://github.com/apache/storm/pull/2017 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2017: STORM-2416: Release Packaging Improvements

2017-03-17 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/2017 STORM-2416: Release Packaging Improvements This reduces the size of the binary distribution from > 200MB to ~79MB. You can merge this pull request into a Git repository by running: $ git pull

Re: Too many threads per bolt instance (as seen with jconsole images)

2017-03-17 Thread Roshan Naik
Can you provide a jstack dump of all the threads in one worker ? -roshan On 3/16/17, 8:40 PM, "S G" wrote: I did not say 3 thds per spout/bolt. I said "When 60 bolts are run per node, there are 1200 total threads/node" That gets me 20 threads/bolt.

[GitHub] storm issue #2016: STORM-2422: Reduce the size of a serialized trident topol...

2017-03-17 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2016 @arunmahadevan yes this is showing up in a real topology (part of monitoring and alerting at Yahoo). And yes some of these topologies are really large. They are machine generated from a number of

[GitHub] storm pull request #2016: STORM-2422: Reduce the size of a serialized triden...

2017-03-17 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2016 STORM-2422: Reduce the size of a serialized trident topology For now I only plan to do this for master. If someone else runs into this issue I am happy to backport it to other versions of storm.

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

2017-03-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r106689294 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -270,17 +272,40 @@ public void

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

2017-03-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r106687999 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java --- @@ -41,31 +41,22 @@

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

2017-03-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r106687191 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java --- @@ -54,21 +55,28 @@

[GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...

2017-03-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1924#discussion_r106685548 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -268,12 +268,12 @@ private Builder(Builder

[GitHub] storm issue #2014: STORM-2038: Disable symlinks with a config option (1.x)

2017-03-17 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2014 @HeartSaVioR could you also take a look at #2015 it is almost identical, except some white space changes in nimbus.clj made it so the cherry-pick was not 100% clean. --- If your project is set up

[GitHub] storm issue #2005: STORM-2414 Skip checking ACL when clearing already remove...

2017-03-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2005 Looking into the logic deeply and realize `deleteBlob` is not that simple as it seems especially with H/A... Investigating more on this. --- If your project is set up for it, you can reply to