Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2502
Congrats @roshannaik great effort and perseverance to get this in and
thanks to @revans2 for reviewing in great detail.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2558
@Ethanlm `Fixing ArrayIndexOutOfBoundsException` is the side effect of
making the behavior back to 1.x version. We already know 1.x version doesn't
have such issue, so it can be placed to side no
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2558
@HeartSaVioR Will this be to long:
[STORM-2950] fix ArrayIndexOutOfBoundsException in
FieldsGrouper.chooseTasks function and make it consistent with 1.x version
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2558
@Ethanlm Thanks for applying review comment so quickly!
Now the meaning of patch would be very different from issue summary &
description (as well as PR's title and commit message) which
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2558#discussion_r168339726
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TupleUtils.java ---
@@ -41,7 +41,7 @@ public static boolean isTick(Tuple tuple) {
}
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2558#discussion_r168331437
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TupleUtils.java ---
@@ -41,7 +41,7 @@ public static boolean isTick(Tuple tuple) {
}
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2558#discussion_r168330302
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TupleUtils.java ---
@@ -41,7 +41,7 @@ public static boolean isTick(Tuple tuple) {
}
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2502
Nice feeling for me to see this merged in and I will look into the CPU
usage issue reported by @HeartSaVioR. Just Wanted to specifically call out and
thank the following folks who have been very h
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2558
[STORM-2950] fix ArrayIndexOutOfBoundsException in
FieldsGrouper.chooseTasks function
https://issues.apache.org/jira/browse/STORM-2950
listHashCode(keys) might return Integer.MIN_VALUE (-21
I'd be okay with just creating the issue and opening PRs. Looking at the
mailing list history, I think we've made do with DISCUSS threads before
making changes many times before. The only non-release VOTE I can find from
the last year was for introducing checkstyle.
2018-02-13 8:55 GMT+01:00 Jungt
Hello Everyone
This is an initial reminder to let you all know that we are holding an
Apache EU Roadshow co-located with FOSS Backstage in Berlin on 13^th and
14^th June 2018. https://s.apache.org/tCHx
The Call for Proposals (CFP) for the Apache EU Roadshow is currently
open and will close a
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2557
[STORM-2948] add -XX:+HeapDumpOnOutOfMemoryError for maven-surefire-plugin
Pretty minor change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2556
What is the expectation for Storm users using different versions of HBase?
Should we have some shim layer to allow using any version?
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2502
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
I want to clarify that my performance tests on the latest code were fairly
simple. I did more exhaustive performance tests on an older version of the
code that looked good to me, but I didn't save a
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2502
Commits Quashed. Thanks. Will use follow up jiras to address any issues
discovered.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2502
Yes I only did the performance test for single node.
Script for running TVL:
* https://gist.github.com/HeartSaVioR/139a1a8ea6a6e285578598095d1c816f (for
4 workers)
* https://gist.
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2502
- Thanks for giving it a spin and posting the numbers. The higher CPU in
multi-worker mode is not something I have seen before. Will take a look. Can
you please share the cmd line that you used ?
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2502
Here's my test result: TVL with rate 85000 and max spout pending 5000.
spouts/splitters/counters are set to same as worker count.
Again, this is just to see if there's clear performance r
19 matches
Mail list logo