[GitHub] storm issue #2622: STORM-3020: fix possible race condition in AsyncLocalizer

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2622 @revans2 Could you elaborate how protection works? At the first time I thought it leverages atomicity of compute*, but reading description of compute* in Map, looks like

[GitHub] storm issue #2591: STORM-2979: WorkerHooks EOFException during run_worker_sh...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2591 @hummelm Btw, we can't merge in this patch without PR for master branch, since master branch is the place which developments take place. Please let me know when you mind taking a look at

[GitHub] storm pull request #2591: STORM-2979: WorkerHooks EOFException during run_wo...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2591#discussion_r179904186 --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj --- @@ -585,6 +588,8 @@ (defserverfn mk-worker [conf shared-mq-context storm-id

Re: New Committer/PMC Member: Roshan Naik

Congratulations Roshan !!! On 2018/04/06 10:59:07, Satish Duggana wrote: > Congratulations Roshan!!> > > > > On Fri, Apr 6, 2018 at 10:06 AM, Erik Weathers <> > eweath...@groupon.com.invalid> wrote:> > > > Congrats Roshan!!> > >> > > On Thu, Apr 5, 2018 at 8:26 PM Ethan Li

[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch

GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2624 STORM-2909 port new metrics to 2.x branch @ptgoetz Ported the new metrics code from 1.2 to 2.x. Verified ConsoleReporter spit out some of the new metrics. You can merge this pull

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179772853 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

Re: New Committer/PMC Member: Roshan Naik

Congratulations Roshan!! On Fri, Apr 6, 2018 at 10:06 AM, Erik Weathers < eweath...@groupon.com.invalid> wrote: > Congrats Roshan!! > > On Thu, Apr 5, 2018 at 8:26 PM Ethan Li wrote: > > > Congratulations! Roshan > > > > Ethan Li > > > > > On Apr 5, 2018, at 21:40,