[GitHub] storm pull request #2625: fix STORM-2979 (master branch)

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2625#discussion_r179931931 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -599,20 +613,16 @@ public WorkerTopologyContext

[GitHub] storm pull request #2625: fix STORM-2979 (master branch)

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2625#discussion_r179931937 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -599,20 +613,16 @@ public WorkerTopologyContext

[GitHub] storm pull request #2625: fix STORM-2979 (master branch)

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2625#discussion_r179931950 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -339,6 +344,15 @@ public WorkerState(Map conf,

[GitHub] storm issue #2622: STORM-3020: fix possible race condition in AsyncLocalizer

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2622 @HeartSaVioR Great catch I forgot to update the normal has Map/HashMap to a ConcurrentHashMap. Yes the guarantees of ConcurrentMap allow for retry and we do have side effects in some of

[GitHub] storm issue #2591: STORM-2979: WorkerHooks EOFException during run_worker_sh...

Github user hummelm commented on the issue: https://github.com/apache/storm/pull/2591 pull request for master branch: [https://github.com/apache/storm/pull/2625](https://github.com/apache/storm/pull/2625) ---

[GitHub] storm pull request #2625: fix STORM-2979 (master branch)

GitHub user hummelm opened a pull request: https://github.com/apache/storm/pull/2625 fix STORM-2979 (master branch) Add in WorkerState an internal list of deserialized workerHooks and use it to start/stop You can merge this pull request into a Git repository by running: $

[GitHub] storm issue #2591: STORM-2979: WorkerHooks EOFException during run_worker_sh...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2591 @hummelm Yes since two branches are diverged so I can't port forward/back. ---

[GitHub] storm issue #2591: STORM-2979: WorkerHooks EOFException during run_worker_sh...

Github user hummelm commented on the issue: https://github.com/apache/storm/pull/2591 for master branch do I have to create a new pull request ? ---

Re: New Committer/PMC Member: Roshan Naik

Thanks to everyone here and on the PMC list ! -Roshan  Sent from Yahoo Mail for iPhone On Friday, April 6, 2018, 3:41 PM, Raghav Kumar Gautam wrote: Congratulations Roshan !!! On 2018/04/06 10:59:07, Satish Duggana wrote: > Congratulations Roshan!!> > >