Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2710
@zd-project Please append "[WIP]" in the title and remove when you finished.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
Iâll make incremental commits to this pull request as it involves
multiple changes, as described in the original apache issue page. Thanks.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2710
Sorry, i didn't see any practical changes for this patch but only some
comment java doc. Can you describe it?
---
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r194212295
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -410,9 +420,11 @@ static DynamicState
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2689
Hi @revans2 Now I'm on vacation. I will add a usage document for RocketMQ
example after I get back next week.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194145119
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194141182
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194140703
--- Diff: storm-client/pom.xml ---
@@ -172,7 +172,7 @@
**/generated/**
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194139729
--- Diff: storm-client/pom.xml ---
@@ -172,7 +172,7 @@
**/generated/**
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194139661
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2704
Rebased, and put in a work around for the flaky test. The test was using
the fact that the client's channel to the server was open as indication that
the channelConnected method must have finished
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2710
STORM-3099: Extend metrics on supervisor and workers
The first commit refactored and commented code in Slot.java
You can merge this pull request into a Git repository by running:
$ git pull
Github user zd-project closed the pull request at:
https://github.com/apache/storm/pull/2709
---
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2709
STORM-3099: Extend metrics on supervisor and workers
The first commit refactored and commented code in Slot.java
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2705
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2708
---
Thanks again!
I'm running this on the v1.2.2 tag. Even after "mvn install -DskipTests",
the test-ns.py script didn't find any tests to run. Have you seen that
before?
I'll try it on the master branch to check.
Regards,
Vivian Kong
Linux on z Systems Open Source Ecosystem
IBM Canada Toronto
17 matches
Mail list logo