[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor and workers

2018-06-08 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2710 @zd-project Please append "[WIP]" in the title and remove when you finished. ---

[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor and workers

2018-06-08 Thread zd-project
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 I’ll make incremental commits to this pull request as it involves multiple changes, as described in the original apache issue page. Thanks. ---

[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor and workers

2018-06-08 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2710 Sorry, i didn't see any practical changes for this patch but only some comment java doc. Can you describe it? ---

[GitHub] storm pull request #2710: STORM-3099: Extend metrics on supervisor and worke...

2018-06-08 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2710#discussion_r194212295 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -410,9 +420,11 @@ static DynamicState

[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates

2018-06-08 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/2689 Hi @revans2 Now I'm on vacation. I will add a usage document for RocketMQ example after I get back next week. ---

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r194145119 --- Diff: shaded-deps/pom.xml --- @@ -251,6 +253,10 @@ org.jboss.netty

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r194141182 --- Diff: shaded-deps/pom.xml --- @@ -251,6 +253,10 @@ org.jboss.netty

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-08 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r194140703 --- Diff: storm-client/pom.xml --- @@ -172,7 +172,7 @@ **/generated/** -

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r194139729 --- Diff: storm-client/pom.xml --- @@ -172,7 +172,7 @@ **/generated/** -

[GitHub] storm pull request #2704: STORM-1038: Upgrade to Netty 4

2018-06-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2704#discussion_r194139661 --- Diff: shaded-deps/pom.xml --- @@ -251,6 +253,10 @@ org.jboss.netty

[GitHub] storm issue #2704: STORM-1038: Upgrade to Netty 4

2018-06-08 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2704 Rebased, and put in a work around for the flaky test. The test was using the fact that the client's channel to the server was open as indication that the channelConnected method must have finished

[GitHub] storm pull request #2710: STORM-3099: Extend metrics on supervisor and worke...

2018-06-08 Thread zd-project
GitHub user zd-project opened a pull request: https://github.com/apache/storm/pull/2710 STORM-3099: Extend metrics on supervisor and workers The first commit refactored and commented code in Slot.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #2709: STORM-3099: Extend metrics on supervisor and worke...

2018-06-08 Thread zd-project
Github user zd-project closed the pull request at: https://github.com/apache/storm/pull/2709 ---

[GitHub] storm pull request #2709: STORM-3099: Extend metrics on supervisor and worke...

2018-06-08 Thread zd-project
GitHub user zd-project opened a pull request: https://github.com/apache/storm/pull/2709 STORM-3099: Extend metrics on supervisor and workers The first commit refactored and commented code in Slot.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #2705: STORM-3096 prevent race condition during topology ...

2018-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2705 ---

[GitHub] storm pull request #2708: STORM-3098: Fixed method filterChangingBlobsFor()

2018-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2708 ---

Re: Running tests via Clojure REPL

2018-06-08 Thread Vivian Kong
Thanks again! I'm running this on the v1.2.2 tag. Even after "mvn install -DskipTests", the test-ns.py script didn't find any tests to run. Have you seen that before? I'll try it on the master branch to check. Regards, Vivian Kong Linux on z Systems Open Source Ecosystem IBM Canada Toronto