GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/675
[STORM-949] On the topology summary UI page, added Elapsed time since error
column.
Current on the topology summary UI page and tells you the last error and
highlights it red if it happened
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130084456
Not sure why travis is failing again. I just built and ran all tests on my
local machine and everything was fine
---
If your project is set up for it, you can reply
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36867859
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
/th
th class=headerLast error
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130327785
---
If your project
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-130347080
fixed the formating issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/675#issuecomment-132891659
Just modified the UI to have error time shown as a time and date. If you
hover over that time a tooltip will pop up displaying the elapsed time.
 based on the comments
You can merge this pull request
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/807#discussion_r42919770
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -375,7 +401,7 @@ public static void validateField(String name, Class
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/807#issuecomment-150704659
@HeartSaVioR thanks for your review. I just modified the PR to address
your comments
---
If your project is set up for it, you can reply to this email and have your
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/807#discussion_r42770783
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -247,6 +253,7 @@
*
* Defaults to false.
*/
+@Deprecated
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/807#discussion_r42770893
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -1215,6 +1254,7 @@
* to be equal to the number of workers configured
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/807#issuecomment-150280561
@revans2 thanks for your review! I have modified the PR to address your
comments
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r44554614
--- Diff: storm-core/src/ui/public/templates/index-page-template.html ---
@@ -215,6 +215,26
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-154914534
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r44579118
--- Diff: storm-core/src/ui/public/templates/index-page-template.html ---
@@ -215,6 +215,26
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-155897894
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-155932528
@redsanket good point! the ui should still be compatible if RAS is not used
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-155933049
Can we just not show any of the columns that deal with resources if the
scheduler used is not RAS
---
If your project is set up for it, you can reply to this email
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/850
[STORM-1158] -Storm metrics to profile various storm functions
It would be nice to have mechanism that would user to collect performance
stats on various storm internal actions such as thrift API
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/851
[YSTORM-1433] - normalize the scales of CPU/Mem/Net when choosing the best
node
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/854#issuecomment-153838740
thanks for the explanation and clarification everybody
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/850#issuecomment-154122052
@revans2 and @kishorvpatil thank you for your reviews. I just made pushed
another commit that hopefully address all of your comments
---
If your project is set up
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r44038817
--- Diff: docs/documentation/storm-metrics-profiling-internal-actions.md ---
@@ -0,0 +1,70 @@
+# Storm Metrics for Profiling Various Storm Internal
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r44036412
--- Diff: docs/documentation/storm-metrics-profiling-internal-actions.md ---
@@ -0,0 +1,70 @@
+# Storm Metrics for Profiling Various Storm Internal
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r44036638
--- Diff: storm-core/pom.xml ---
@@ -602,6 +612,42 @@
org.eclipse.jetty
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/850#issuecomment-154121467
@kishorvpatil will add the two metrics
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/859#issuecomment-154126288
+1 @zhuoliu thanks for fixing this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-154127417
@knusbaum the functionality of ConfigValidation has not changed, but this
PR adds support for validating configs submitted with a topology. This allows
storm to do
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/667#issuecomment-154126726
any updates on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/825#discussion_r43807074
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -18,6 +18,7 @@
package backtype.storm;
import java.io.File
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-153488321
@d2r thanks for your review, I just pushed a commit that I think addressed
your comments
---
If your project is set up for it, you can reply to this email and have
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-153490830
@d2r thanks again! Just push a commit to fix the one nit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/856
[STORM-1165] - normalize the scales of CPU/Mem/Net when choosing the best
node for Resource Aware Scheduler
You can merge this pull request into a Git repository by running:
$ git pull
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/857#issuecomment-153800087
+1 nice fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/856#issuecomment-153797453
@zhuoliu thanks for your thorough review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/856#discussion_r43907913
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -209,18 +209,18 @@ private WorkerSlot
Github user jerrypeng closed the pull request at:
https://github.com/apache/storm/pull/851
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/854#issuecomment-153816194
Topology names are not unique. Users can submit topologies with the same
name, but the their auto generated topology ids will be unique. I am not sure
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/863
[STORM-1182] - Removing and wrapping some exceptions in ConfigValidation to
make code cleaner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/865#discussion_r44159502
--- Diff: conf/storm.yaml.example ---
@@ -19,7 +19,7 @@
# - "server1"
# - "server2"
#
-#
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148098193
@d2r upmerged and added functionality. Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42014597
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42030910
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42033497
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42032492
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,216 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42042786
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42045972
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42048224
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42045456
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,216 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148442586
@revans2 Thanks! You are right that piece of code involving the try catch
statement is useless. I have removed it
---
If your project is set up for it, you can reply
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42145138
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,570 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148425413
@d2r @revans2 I just pushed some updates based on what we discussed. Can
you guys look at it again? thanks!
---
If your project is set up for it, you can reply
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/805#issuecomment-149334480
+1 this is going to be very useful when attempting to profile storm
performance and underlying hardware performance
---
If your project is set up for it, you can
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/806#issuecomment-149334001
+1 nicely done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148473108
@revans2 @d2r Thank you for spending the time to review my PR! Much
appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/807
[STORM-] - Fix Validation for lots of different configs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-147414223
@revans2 any other suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r41399786
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,359 @@
+package backtype.storm.validation;
+
+import
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r41399571
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,359 @@
+package backtype.storm.validation;
--- End diff
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146272172
@revans2 your suggestion are great, but the parameters passed into java
annotations have to declared to be a specific type thus we could not have:
@MapType
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41412262
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -438,6 +451,35 @@ public SupervisorDetails getSupervisorById(String
nodeId
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41409816
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41410090
--- Diff:
storm-core/src/jvm/backtype/storm/networktopography/DNSToSwitchMapping.java ---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146248606
Well for some for annotations I call a common validator and just pass in
the type that needs to be validated, such as @String @Boolean validators.
---
If your
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41347393
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41347451
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -18,10 +18,7 @@
package backtype.storm.utils;
import
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146066442
@zhuoliu Thanks for your review. I think just push a commit that I think
address all your comments
---
If your project is set up for it, you can reply to this email
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146266179
@erikdw thank you for your review. I reformated some of the files based on
your suggestions
---
If your project is set up for it, you can reply to this email
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-147752280
@knusbaum @d2r @zhuoliu @rfarivar Can review this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41347349
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -0,0 +1,478 @@
+/**
+ * Licensed
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/785
[STORM-1084] - Improve Storm config validation process to use java
annotations instead of *_SCHEMA format
So currently we specify validators:
public static final String
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r41898760
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r41898751
--- Diff: storm-core/test/jvm/backtype/storm/TestConfigValidate.java ---
@@ -0,0 +1,137 @@
+package backtype.storm;
+
+import
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146880546
@revans2 Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146875059
I have two +1s now, can we merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146949595
the java annotation spec was written that way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146948299
@revans2 I don't think you solution will work either. I don't think we can
get recursion and java annotations to work, since fields in annotations cannot
default
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/790#issuecomment-146891371
Looks good but probably should wait until the resource scheduler actually
goes in before we merge this PR
---
If your project is set up for it, you can reply
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/780#issuecomment-146895513
non trivial fail in the unit tests that need to be investigated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/890
making small fixes in RAS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm RAS_small_fixes
Alternatively you can review
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/885#issuecomment-157831515
just a quick question. where is outputStreamId set?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/881#discussion_r45250004
--- Diff: storm-core/src/clj/backtype/storm/stats.clj ---
@@ -335,30 +358,21 @@
(defn- agg-bolt-streams-lat-and-count
"Aggregates number exe
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/890#issuecomment-157843989
@revans2 will fill a JIRA to track
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157827199
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-144111799
@HeartSaVioR
@revans2
Can I get a review for my PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40732961
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -442,4 +444,36 @@ public static String submitJar(Map conf, String
localJar
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40734280
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -31,41 +42,47 @@
StormTopology topology;
Map
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40730558
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -167,6 +167,16 @@
public static final Object STORM_CLUSTER_MODE_SCHEMA = String.class
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40732462
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -442,4 +444,36 @@ public static String submitJar(Map conf, String
localJar
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40734496
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -79,11 +96,304 @@ public StormTopology getTopology
1 - 100 of 619 matches
Mail list logo
