Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/746#issuecomment-146896112
@revans2 thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146948299
@revans2 I don't think you solution will work either. I don't think we can
get recursion and java annotations to work, since fields in annotations cannot
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-146949595
the java annotation spec was written that way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-147414223
@revans2 any other suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-147752280
@knusbaum @d2r @zhuoliu @rfarivar Can review this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r41898760
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r41898751
--- Diff: storm-core/test/jvm/backtype/storm/TestConfigValidate.java ---
@@ -0,0 +1,137 @@
+package backtype.storm;
+
+import
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148098193
@d2r upmerged and added functionality. Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42014597
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42028053
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42028131
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42030910
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42032492
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,216 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42033497
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42042650
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42042786
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42045456
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidationAnnotations.java
---
@@ -0,0 +1,216 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42045972
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42048224
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148425413
@d2r @revans2 I just pushed some updates based on what we discussed. Can
you guys look at it again? thanks!
---
If your project is set up for it, you can reply to
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/785#discussion_r42145138
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -0,0 +1,570 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148442586
@revans2 Thanks! You are right that piece of code involving the try catch
statement is useless. I have removed it
---
If your project is set up for it, you can reply
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/785#issuecomment-148473108
@revans2 @d2r Thank you for spending the time to review my PR! Much
appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/807
[STORM-] - Fix Validation for lots of different configs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/807#issuecomment-149309782
unrelated kafka messaging test failed in travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/806#issuecomment-149334001
+1 nicely done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/805#issuecomment-149334480
+1 this is going to be very useful when attempting to profile storm
performance and underlying hardware performance
---
If your project is set up for it, you can
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/808#issuecomment-149974237
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/807#discussion_r42770783
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -247,6 +253,7 @@
*
* Defaults to false.
*/
+@Deprecated
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/807#discussion_r42770893
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -1215,6 +1254,7 @@
* to be equal to the number of workers configured for this
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/807#issuecomment-150280561
@revans2 thanks for your review! I have modified the PR to address your
comments
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/807#discussion_r42919770
--- Diff:
storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java ---
@@ -375,7 +401,7 @@ public static void validateField(String name, Class
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/807#issuecomment-150704659
@HeartSaVioR thanks for your review. I just modified the PR to address
your comments
---
If your project is set up for it, you can reply to this email and have your
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/820
fixing some config validation annotations
Some configs that is declared as @isPositiveNumber should be
@isPositiveNumber(includeZero=true) based on the comments
You can merge this pull request
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/825
Validate topology Configs during topology submission
adding config validation during the topology submission process so that
incorrect configs can be detected early
You can merge this pull
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-152252726
non related failure in travis for jdk7. Tests for jdk 8 passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/828#issuecomment-152610714
LGTM +1 but probably should update this doc with more current information
in the near future
---
If your project is set up for it, you can reply to this email and
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-153488321
@d2r thanks for your review, I just pushed a commit that I think addressed
your comments
---
If your project is set up for it, you can reply to this email and have
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/825#discussion_r43807074
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -18,6 +18,7 @@
package backtype.storm;
import java.io.File
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-153490830
@d2r thanks again! Just push a commit to fix the one nit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-153511753
Tests passed for java 8. Unrelated test failure for java 7 build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/850
[STORM-1158] -Storm metrics to profile various storm functions
It would be nice to have mechanism that would user to collect performance
stats on various storm internal actions such as thrift API
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/851
[YSTORM-1433] - normalize the scales of CPU/Mem/Net when choosing the best
node
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng
Github user jerrypeng closed the pull request at:
https://github.com/apache/storm/pull/851
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/856
[STORM-1165] - normalize the scales of CPU/Mem/Net when choosing the best
node for Resource Aware Scheduler
You can merge this pull request into a Git repository by running:
$ git pull
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/856#discussion_r43907913
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/ResourceAwareStrategy.java
---
@@ -209,18 +209,18 @@ private WorkerSlot
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/856#issuecomment-153797453
@zhuoliu thanks for your thorough review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/858#issuecomment-153798058
LGTM +1 thanks for doing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/857#issuecomment-153800087
+1 nice fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/854#issuecomment-153816194
Topology names are not unique. Users can submit topologies with the same
name, but the their auto generated topology ids will be unique. I am not sure
this is the
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/854#issuecomment-153838740
thanks for the explanation and clarification everybody
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r44036412
--- Diff: docs/documentation/storm-metrics-profiling-internal-actions.md ---
@@ -0,0 +1,70 @@
+# Storm Metrics for Profiling Various Storm Internal
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/850#issuecomment-154121467
@kishorvpatil will add the two metrics
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r44036638
--- Diff: storm-core/pom.xml ---
@@ -602,6 +612,42 @@
org.eclipse.jetty
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/850#issuecomment-154122052
@revans2 and @kishorvpatil thank you for your reviews. I just made pushed
another commit that hopefully address all of your comments
---
If your project is set up
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/850#discussion_r44038817
--- Diff: docs/documentation/storm-metrics-profiling-internal-actions.md ---
@@ -0,0 +1,70 @@
+# Storm Metrics for Profiling Various Storm Internal
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/859#issuecomment-154126288
+1 @zhuoliu thanks for fixing this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/667#issuecomment-154126726
any updates on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/825#issuecomment-154127417
@knusbaum the functionality of ConfigValidation has not changed, but this
PR adds support for validating configs submitted with a topology. This allows
storm to do
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/863
[STORM-1182] - Removing and wrapping some exceptions in ConfigValidation to
make code cleaner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/865#discussion_r44159502
--- Diff: conf/storm.yaml.example ---
@@ -19,7 +19,7 @@
# - "server1"
# - "server2"
#
-#
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-154914534
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r44554614
--- Diff: storm-core/src/ui/public/templates/index-page-template.html ---
@@ -215,6 +215,26
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r44554722
--- Diff: storm-core/src/ui/public/templates/index-page-template.html ---
@@ -215,6 +215,26
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r44579118
--- Diff: storm-core/src/ui/public/templates/index-page-template.html ---
@@ -215,6 +215,26
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-155897894
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-155932528
@redsanket good point! the ui should still be compatible if RAS is not used
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-155933049
Can we just not show any of the columns that deal with resources if the
scheduler used is not RAS
---
If your project is set up for it, you can reply to this email
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/890
making small fixes in RAS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm RAS_small_fixes
Alternatively you can review and
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-157827199
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/885#issuecomment-157831515
just a quick question. where is outputStreamId set?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/881#discussion_r45250004
--- Diff: storm-core/src/clj/backtype/storm/stats.clj ---
@@ -335,30 +358,21 @@
(defn- agg-bolt-streams-lat-and-count
"Aggregates number exe
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/890#issuecomment-157843989
@revans2 will fill a JIRA to track
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r45491671
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -461,6 +466,75 @@ public SupervisorDetails getSupervisorById(String
nodeId
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r45491725
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -461,6 +466,75 @@ public SupervisorDetails getSupervisorById(String
nodeId
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r45491709
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -461,6 +466,75 @@ public SupervisorDetails getSupervisorById(String
nodeId
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-158481188
Just tested the UI, resource numbers look right. Good Stuff +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/890#issuecomment-158968474
@kishorvpatil can we merge it now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/921
[STORM-898] - Add priorities and per user resource guarantees to Resource
Aware Scheduler
In a multi-tenant environment we would like to be able to give individual
users a guarantee of how much
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/921#issuecomment-161882261
unrelated test failure only for storm-core java 8 build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/918#issuecomment-161979869
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/923
[STORM-1370] - Bug fixes for MultitenantScheduler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-1370
Alternatively
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/923#issuecomment-162010840
@d2r can you take a look thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46701142
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46701322
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/923#issuecomment-162014757
unrelated travis failure only for java 8 storm-core build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46719386
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -2070,4 +2109,21 @@ public void setTopologyWorkerMaxHeapSize(Number
size
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46719645
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -90,6 +92,23 @@ public Cluster(INimbus nimbus, Map supervisors, Map newAssignments
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46719825
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Topologies.java ---
@@ -67,4 +67,17 @@ public TopologyDetails getByName(String topologyName
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46720084
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -433,4 +461,49 @@ private void initConfigs() {
public Double
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46720776
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -433,4 +461,49 @@ private void initConfigs() {
public Double
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46720892
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -138,7 +144,7 @@ private void validateSlot(WorkerSlot ws
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46721030
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -230,6 +241,61 @@ public void freeTopology(String topId, Cluster
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46721248
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46721490
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46721540
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -28,94 +32,272 @@
import
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46721806
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/SchedulingResult.java ---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46722794
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/SchedulingResult.java ---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46722836
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/SchedulingResult.java ---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r46724385
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/User.java ---
@@ -0,0 +1,344 @@
+/**
+ * Licensed to the Apache Software Foundation
501 - 600 of 655 matches
Mail list logo
