[GitHub] storm pull request: Update PartitionManager.java

2015-02-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/405 Update PartitionManager.java fix bug [STORM-643] KafkaUtils repeat fetch messages which offset is out of range You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-83840369 +1 looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: STORM-638:UI should show up process-id of the ...

2015-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-83920789 unnecessary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-689. SimpleACLAuthorizer should provide ...

2015-03-12 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/445#issuecomment-78814683 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-02-26 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-76148389 @ptgoetz can you please review this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-02-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-75902724 Hi Michael, Thank you for your improvement. It would be better to skip all the outdated failed offsets in one step and I have extended the pull request

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-03-23 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-85306274 @longdafeng GOOD JOB! it's simple and efficient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: STORM-561: Add flux as an external module

2015-05-10 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/546#issuecomment-100625034 Good job! We also developed a componet like FLUX. I'm happy to try. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: Update pom.xml

2015-06-19 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/599 Update pom.xml add flux-wrappers scope You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-1 Alternatively you can review

[GitHub] storm pull request: [STORM-958] adds config for group.mapping.serv...

2015-08-16 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/649#issuecomment-131648237 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-22 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-123581897 Maybe you compile your project including the storm-kafka. So, add {code}scopeprovided/scope{code} to POM(storm-kafka dependency). And just try again

[GitHub] storm pull request: using the latest javadocs

2015-07-25 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/643#issuecomment-124851746 Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-15 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121808744 @HeartSaVioR Thanks. I have created a new PR(https://github.com/apache/storm/pull/635) for 0.9.x-branch. Can this be merged into the apache branch now? --- If your

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-15 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/635 [STORM-643] KafkaUtils repeatedly fetches messages whose offset is out of range STORM-643 fixing for 0.9.x-branch You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121473865 @HeartSaVioR @tedxia This PR is for branch 0.9.x. 0.9.x is very different from 0.10.x and master, so when we go the cherry-pick there are a lot of conflicts. In branch

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121473131 @miguno Sorry I took so long to respond. Like @tpiscitell already explained, this problem are not solved by STORM-586 and STORM-511. --- If your project is set up

[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...

2015-07-16 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/615#issuecomment-122147057 -0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-16 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122184898 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-122193841 @HeartSaVioR Could you take a look? Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122479359 @HeartSaVioR Yeah, you are right. We can reproduce the issue with 0.10.x branch too. And I will make a new PR based on master branch. --- If your project is set up

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122479965 @HeartSaVioR I have created a new PR(https://github.com/apache/storm/pull/642) based on master branch. Could you take a look? Thx. --- If your project is set up

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/642 [STORM-643] KafkaUtils repeatedly fetches messages whose offset is out of range STORM-643 fixing based on master branch You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122467741 Thanks for reminding. Yes, I'm working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense closed the pull request at: https://github.com/apache/storm/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-122466082 Will do. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/642#issuecomment-122669976 @HeartSaVioR I have completed the optimization. Could you take a look? Thx. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-20 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/642#issuecomment-122872920 @lazyval Thank you for pointing out my mistake. I'm sorry for that. It won't happen next time. Thanks again. --- If your project is set up for it, you can reply

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-20 Thread vesense
Github user vesense closed the pull request at: https://github.com/apache/storm/pull/642 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-20 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/642#issuecomment-123132069 @HeartSaVioR OK. thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: using the latest javadocs

2015-07-21 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/643 using the latest javadocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-5 Alternatively you can review and apply

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-10-28 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/743#issuecomment-152083005 @harshach Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-10-28 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/743#discussion_r43349319 --- Diff: external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java --- @@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-11-04 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/743#discussion_r43970097 --- Diff: external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java --- @@ -83,8 +81,8 @@ public void updateState(List tuples, TridentCollector

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/865#discussion_r44204593 --- Diff: conf/storm.yaml.example --- @@ -19,7 +19,7 @@ # - "server1" # - "server2" # -# nimbus.host: "ni

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-135248186 +1 Looks very exciting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: STORM-851: Storm Solr Connector

2015-08-25 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/665#issuecomment-134782918 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-09-18 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/743 [STORM-1052] TridentKafkaState uses new Kafka Producer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-6 Alternatively

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-09-20 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/743#issuecomment-141853555 @HeartSaVioR Can you please review this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-18 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/744 [STORM-1053] Correct storm-kafka readme file because of using new kafka-clients api correct readme file: new producer link & configs You can merge this pull request into a Git repository by run

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161149466 @unsleepy22 Thanks. I will fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/909 [STORM-1359] change kryo links from google code to github You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-10 Alternatively

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161152398 Done.Since files are not in the same branch, I have created a new PR (https://github.com/apache/storm/pull/909) for backtype.storm.Config. --- If your project is set up

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-02 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161491178 +1 Great work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: Update storm download link in storm.py

2015-12-16 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/953 Update storm download link in storm.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-12 Alternatively you can review

[GitHub] storm pull request: [STORM-1387] workers-artifacts directory confi...

2015-12-10 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/942#issuecomment-163860313 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1388] Fix url and email links in README...

2015-12-10 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/943 [STORM-1388] Fix url and email links in README file You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-11 Alternatively you

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-06 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/977#issuecomment-169265399 Respond to @dossett comments: > I am not familiar with all the ways that bolts can receive tick tuples, but does SolrBolt also need a way to specify that it sho

[GitHub] storm pull request: [STORM-1415] Some improvements for trident map...

2016-01-05 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/973#issuecomment-169233427 comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-05 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/972#discussion_r48928397 --- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java --- @@ -33,20 +33,24 @@ import org.json.simple.JSONValue; import

[GitHub] storm pull request: Update pom.xml

2016-01-05 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/599#issuecomment-169224710 Sorry I took so long to respond. It is convenient for multi-lang user to use FLUX just in one jar. As a minor issue, now, It is OK for me. In the past, I wanted

[GitHub] storm pull request: [STORM-1414] Some improvements for multilang J...

2016-01-05 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/972#issuecomment-169228054 comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1415] Some improvements for trident map...

2016-01-05 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/973#discussion_r48929303 --- Diff: storm-core/src/jvm/storm/trident/state/map/MapCombinerAggStateUpdater.java --- @@ -33,24 +33,25 @@ import

[GitHub] storm pull request: [STORM-1415] Some improvements for trident map...

2016-01-05 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/973#discussion_r48929312 --- Diff: storm-core/src/jvm/storm/trident/state/map/MapReducerAggStateUpdater.java --- @@ -34,39 +34,38 @@ import

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-07 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49157386 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -59,16 +64,24 @@ public SolrUpdateBolt(SolrConfig

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-07 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49157240 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -131,6 +155,26 @@ private void failQueuedTuples(List

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-07 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49157203 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -92,9 +108,17 @@ private void ack(Tuple tuple) throws

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-07 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/977#issuecomment-169894466 @hmcl comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-07 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49157210 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -92,9 +108,17 @@ private void ack(Tuple tuple) throws

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-09 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49264374 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -92,9 +108,12 @@ private void ack(Tuple tuple) throws

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-09 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49264392 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -131,6 +150,21 @@ private void failQueuedTuples(List

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-09 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49264396 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/config/SolrConfig.java --- @@ -39,4 +40,13 @@ public SolrConfig(String zkHostString

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-09 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49264394 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -59,15 +63,24 @@ public SolrUpdateBolt(SolrConfig

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-09 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/977#issuecomment-170254404 @hmcl all comments addressed. but I met some conficts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: [STORM-1462] Upgrade HikariCP to 2.4.3

2016-01-09 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1002 [STORM-1462] Upgrade HikariCP to 2.4.3 https://issues.apache.org/jira/browse/STORM-1462 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense

[GitHub] storm pull request: remove unused local variable

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/974 remove unused local variable You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-21 Alternatively you can review and apply

[GitHub] storm pull request: [STORM-1409] Removes StormClientErrorHandler, ...

2015-12-23 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/965#issuecomment-166898038 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1418] improve debug logs for HBaseBolt&...

2015-12-25 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/976 [STORM-1418] improve debug logs for HBaseBolt You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-22 Alternatively you can

[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...

2015-12-25 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/978 [STORM-1420] solr CountBasedCommit should reset count=0 after commited https://issues.apache.org/jira/browse/STORM-1420 You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request: Remove broken example from the tutorial

2015-12-26 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/979#issuecomment-167328906 Thanks @sethgrid Can you file a JIRA for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1425] Tick tuples must be acked like no...

2015-12-28 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/982 [STORM-1425] Tick tuples must be acked like normal tuples https://issues.apache.org/jira/browse/STORM-1425 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm pull request: Fix blobstore log class

2015-12-21 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/962 Fix blobstore log class You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-13 Alternatively you can review and apply

[GitHub] storm pull request: [STORM-1407] fix authorize issue for daemon lo...

2015-12-21 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/961#issuecomment-166507378 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1413] remove unused variables for local...

2015-12-23 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/971#issuecomment-167018639 @harshach Thanks. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: Add 'public' for windowing EventImpl class

2015-12-23 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/968#issuecomment-167022720 @arunmahadevan Thanks. I will fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: [STORM-1411] some fixes for storm-windowing

2015-12-23 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/969#issuecomment-167060100 @arunmahadevan Thanks. I have rebased the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1411] some fixes for storm-windowing

2015-12-24 Thread vesense
Github user vesense closed the pull request at: https://github.com/apache/storm/pull/968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [STORM-1411] some fixes for storm-windowing

2015-12-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/968#issuecomment-167114767 Since the change is included in https://github.com/apache/storm/pull/969, I will close this PR. --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: [STORM-1413] remove unused variables for some ...

2015-12-24 Thread vesense
Github user vesense closed the pull request at: https://github.com/apache/storm/pull/971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [STORM-1411] some fixes for storm-windowing

2015-12-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/969#issuecomment-167114263 @arunmahadevan OK. Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1413] remove unused variables for some ...

2015-12-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/971#issuecomment-167115960 @harshach Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1413] remove unused variables for some ...

2015-12-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/971#issuecomment-167116302 Since the change is included in #974, I will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: [STORM-1413] remove unused variables for some ...

2015-12-24 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/974#issuecomment-167118042 @harshach @zhuoliu I have rebased the PR. Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: [STORM-1414] refactor multilang JsonSerializer

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/972 [STORM-1414] refactor multilang JsonSerializer You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-19 Alternatively you can

[GitHub] storm pull request: [STORM-1415] refactor trident map StateUpdater

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/973 [STORM-1415] refactor trident map StateUpdater https://issues.apache.org/jira/browse/STORM-1415 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request: [STORM-1412] null check should be done in the ...

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/970 [STORM-1412] null check should be done in the first place https://issues.apache.org/jira/browse/STORM-1412 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm pull request: [STORM-1411] make windowing EvictionPolicy typ...

2015-12-23 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/969#issuecomment-166838975 The Travis CI failed build seems unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1413] remove unused variables for local...

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/971 [STORM-1413] remove unused variables for localizer test You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-18 Alternatively

[GitHub] storm pull request: Remove repeated semicolon

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/967 Remove repeated semicolon You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-14 Alternatively you can review and apply

[GitHub] storm pull request: Add 'public' for EventImpl class

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/968 Add 'public' for EventImpl class You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-15 Alternatively you can review and apply

[GitHub] storm pull request: [STORM-1411] make windowing EvictionPolicy typ...

2015-12-23 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/969 [STORM-1411] make windowing EvictionPolicy type safety You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-16 Alternatively you

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/908 [STORM-1359] change kryo links from google code to github You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-9 Alternatively

[GitHub] storm pull request: [STORM-1419] Solr bolt should handle tick tupl...

2016-01-12 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/977#issuecomment-171195222 @revans2 @hmcl Conflicts resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...

2016-01-13 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/978#issuecomment-171244000 Thanks @revans2 @hmcl for your explaining. These changes are not necessary. I will close this issue as 'Not A Problem'. --- If your project is set up for it, you can

[GitHub] storm issue #1463: Fixed help message for set_log_level command

2016-06-07 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1463 LGTM Can you please file a jira for this? https://issues.apache.org/jira/browse/STORM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request #1471: STORM-1865: update command line client document

2016-06-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1471 STORM-1865: update command line client document This can be cherry-picked to 1.x-branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense

[GitHub] storm pull request #1472: STORM-1888: add description for shell command

2016-06-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1472 STORM-1888: add description for shell command This can be cherry-picked to 1.x-branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense

[GitHub] storm pull request: STORM-1778: scheme extension framework for Kaf...

2016-05-25 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1410#discussion_r64682353 --- Diff: external/sql/storm-sql-kafka/src/jvm/org/apache/storm/sql/kafka/CsvScheme.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2016-06-21 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1136 @HeartSaVioR Agree with you. We should have a discussion about multi-lang support. (Can open a thread on dev@ mailing list) --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request #1472: STORM-1888: add description for shell command

2016-06-22 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1472#discussion_r68058773 --- Diff: bin/storm.py --- @@ -485,6 +485,11 @@ def kill_workers(*args): extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, &quo

[GitHub] storm issue #1472: STORM-1888: add description for shell command

2016-06-22 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1472 @HeartSaVioR Updated and rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

  1   2   3   4   5   6   >