[GitHub] storm pull request: [STORM-1232] port backtype.storm.scheduler.Def...

2016-03-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1108#discussion_r56285602 --- Diff: storm-core/test/clj/org/apache/storm/scheduler_test.clj --- @@ -262,20 +262,15 @@ (deftest test-sort-slots ;; test supervisor2 has

[GitHub] storm pull request: [STORM-1232] port backtype.storm.scheduler.Def...

2016-03-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1108#discussion_r56285608 --- Diff: storm-core/test/clj/org/apache/storm/scheduler_test.clj --- @@ -262,20 +262,15 @@ (deftest test-sort-slots ;; test supervisor2 has

[GitHub] storm pull request: [STORM-1232] port backtype.storm.scheduler.Def...

2016-03-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1108#discussion_r56285598 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/EvenScheduler.java --- @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-1232] port backtype.storm.scheduler.Def...

2016-03-15 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1108#issuecomment-197168827 @revans2 Thanks for your review. I think I have addressed all of your comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-1483: add storm-mongodb connector

2016-03-15 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1219 STORM-1483: add storm-mongodb connector for 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1483-1.x

[GitHub] storm pull request: [STORM-1483] add storm-mongodb connector

2016-03-15 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1038#issuecomment-197184879 @harshach Done. -> https://github.com/apache/storm/pull/1219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-1483: add storm-mongodb connector

2016-03-16 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1219#issuecomment-197188155 cc @harshach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1549: [master] Add support for resetting...

2016-03-16 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1174#issuecomment-197194723 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1565] Multi-Lang Performance Improvemen...

2016-03-18 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1136#issuecomment-197343790 cc @HeartSaVioR You might be interested in this improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1228#issuecomment-198353000 The bug has been fixed by https://github.com/apache/storm/pull/1231 @HeartSaVioR Could you close this PR? --- If your project is set up for it, you can reply to

[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1215#issuecomment-197637925 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-198366541 Could you take a look at this please, @harshach ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: STORM-1483: add storm-mongodb connector

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1219#issuecomment-197335297 The build error is unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-198152770 This PR can be merged to both master and 1.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: hotfix: parent version for pom.xml in storm-mo...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1228#issuecomment-197857053 +1 Good catch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-19 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1230 [STORM-1573] Add batch support for MongoInsertBolt https://issues.apache.org/jira/browse/STORM-1573 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm pull request: STORM-1637: Correct the master version of stor...

2016-03-19 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1231#issuecomment-198389354 BTW, I think @revans2 's main concern is **why JDK7 builds pass while JDK8 builds fail with** in JIRA [STORM-1637](https://issues.apache.org/jira/browse/STORM

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-25 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-201271418 ping @harshach --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-1659:Add documents for external projects

2016-03-27 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1264 STORM-1659:Add documents for external projects You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1659-DOCS Alternatively you

[GitHub] storm pull request: STORM-1659:Add documents for external projects

2016-03-27 Thread vesense
Github user vesense closed the pull request at: https://github.com/apache/storm/pull/1264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1659:Add documents for external projects

2016-03-27 Thread vesense
GitHub user vesense reopened a pull request: https://github.com/apache/storm/pull/1264 STORM-1659:Add documents for external projects You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1659-DOCS Alternatively

[GitHub] storm pull request: STORM-1659:Add documents for external projects

2016-03-27 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1264#issuecomment-202014901 @HeartSaVioR OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-1659:Add documents for external projects

2016-03-27 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1265 STORM-1659:Add documents for external projects for 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1659-1.x

[GitHub] storm pull request: STORM-1659:Add documents for external projects

2016-03-27 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1264#issuecomment-202016176 @HeartSaVioR Done. see https://github.com/apache/storm/pull/1265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-1573 (1.x): Add batch support for MongoI...

2016-03-27 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1266 STORM-1573 (1.x): Add batch support for MongoInsertBolt You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1573-1.x

[GitHub] storm pull request: STORM-1660: remove flux gitignore file and mov...

2016-03-27 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1267 STORM-1660: remove flux gitignore file and move rules to top level gitignore refactor gitignore You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request: STORM-1573 (1.x): Add batch support for MongoI...

2016-03-27 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1266#issuecomment-202079469 master: https://github.com/apache/storm/pull/1230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: STORM-1660: remove flux gitignore file and mov...

2016-03-27 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1267#issuecomment-202183403 This PR can be merged to both master and 1.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-28 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-202743567 @HeartSaVioR Thanks for your reply. I planed to handle tick tuples in a follow up JIRA. But I'm OK for adding these changes in one JIRA, in order to provide sta

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-29 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-202755952 @HeartSaVioR OK. I will add the change later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-29 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-202906803 @HeartSaVioR Updated. also 1.x-branch: https://github.com/apache/storm/pull/1266 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-1660 (1.x): remove flux gitignore file a...

2016-03-29 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1275 STORM-1660 (1.x): remove flux gitignore file and move rules to top level gitignore for 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-30 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-203708568 @HeartSaVioR Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-30 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1230#discussion_r57993615 --- Diff: external/storm-mongodb/src/main/java/org/apache/storm/mongodb/bolt/MongoInsertBolt.java --- @@ -99,6 +107,29 @@ public MongoInsertBolt withOrdered

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-30 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1230#discussion_r57993862 --- Diff: external/storm-mongodb/src/main/java/org/apache/storm/mongodb/bolt/MongoInsertBolt.java --- @@ -99,6 +107,29 @@ public MongoInsertBolt withOrdered

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-30 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1230#discussion_r57995833 --- Diff: external/storm-mongodb/src/main/java/org/apache/storm/mongodb/bolt/MongoInsertBolt.java --- @@ -99,6 +107,29 @@ public MongoInsertBolt withOrdered

[GitHub] storm pull request: STORM-1669: Fix SolrUpdateBolt flush bug

2016-03-30 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1283 STORM-1669: Fix SolrUpdateBolt flush bug https://issues.apache.org/jira/browse/STORM-1669 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request: STORM-1669 (1.x): Fix SolrUpdateBolt flush bug

2016-03-30 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1284 STORM-1669 (1.x): Fix SolrUpdateBolt flush bug for 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1669-1.x

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-03-30 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-203751499 @HeartSaVioR Done. rebased both master and 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-1573 (1.x): Add batch support for MongoI...

2016-03-30 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1266#issuecomment-203751537 @HeartSaVioR Done. rebased both master and 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-1678: abstract batch processing to commo...

2016-04-02 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1303 STORM-1678: abstract batch processing to common api `BatchHelper` You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1678

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-04-02 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-204890305 >Btw, totally agreed about abstracting batch process to something common. @HeartSaVioR I have created a PR for abstracting batch process. see https://github.

[GitHub] storm pull request: STORM-1678 (1.x): abstract batch processing to...

2016-04-03 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1304 STORM-1678 (1.x): abstract batch processing to common api `BatchHelper` You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM

[GitHub] storm pull request: STORM-1677 Test resource files are excluded fr...

2016-04-03 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1300#issuecomment-204941160 @HeartSaVioR I'm not sure whether it is caused by `*.log` rule in gitignore. If *true*, we can apply your patch(`d5e1112 `), or create another patch just chang

[GitHub] storm pull request: STORM-1679: add storm Scheduler documents

2016-04-03 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1305 STORM-1679: add storm Scheduler documents You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1679 Alternatively you can

[GitHub] storm pull request: STORM-1679: add storm Scheduler documents

2016-04-03 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1305#issuecomment-204981901 Now the link to IsolationScheduler(org/apache/storm/scheduler/IsolationScheduler.java) is unavailable. This will be OK after JIRA STORM-1239 "

[GitHub] storm pull request: STORM-1679: add storm Scheduler documents

2016-04-03 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1306 STORM-1679: add storm Scheduler documents for 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1679-1.x

[GitHub] storm pull request: STORM-1679 (1.x): add storm Scheduler document...

2016-04-03 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1306#discussion_r58318583 --- Diff: docs/Storm-Scheduler.md --- @@ -0,0 +1,27 @@ +--- +title: Scheduler +layout: documentation +documentation: true

[GitHub] storm pull request: STORM-1679 (1.x): add storm Scheduler document...

2016-04-03 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1306#discussion_r58319009 --- Diff: docs/Storm-Scheduler.md --- @@ -0,0 +1,27 @@ +--- +title: Scheduler +layout: documentation +documentation: true

[GitHub] storm pull request: STORM-1679 (1.x): add storm Scheduler document...

2016-04-03 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1306#discussion_r58319012 --- Diff: docs/Storm-Scheduler.md --- @@ -0,0 +1,27 @@ +--- +title: Scheduler +layout: documentation +documentation: true

[GitHub] storm pull request: STORM-1679 (1.x): add storm Scheduler document...

2016-04-03 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1306#issuecomment-205071397 @zhuoliu Thanks for your reply. I have updated the document, also master branch. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [STORM-1573] Add batch support for MongoInsert...

2016-04-03 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1230#issuecomment-205119142 @HeartSaVioR Could you take a look at https://github.com/apache/storm/pull/1303 ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-1658: documents improvements and links f...

2016-04-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1317 STORM-1658: documents improvements and links fixes (for master) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1658

[GitHub] storm pull request: STORM-1658: documents improvements and links f...

2016-04-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1318 STORM-1658: documents improvements and links fixes (for 1.x) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1658-1.x

[GitHub] storm pull request: STORM-1658: documents improvements and links f...

2016-04-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1319 STORM-1658: documents improvements and links fixes (for 0.10.x) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1658-0.10.x

[GitHub] storm pull request: STORM-1658: documents improvements and links f...

2016-04-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1321 STORM-1658: documents improvements and links fixes (for 0.9.x) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1658-0.9.x

[GitHub] storm pull request: STORM-1679 (1.x): add storm Scheduler document...

2016-04-12 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1306#issuecomment-208823640 @HeartSaVioR Updated, also master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1711] Kerberos principals gets mixed up...

2016-04-14 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1339#issuecomment-210235936 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1713: Replace NotImplementedException wi...

2016-04-15 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/1341#issuecomment-210480476 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-10-28 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/743#discussion_r43349319 --- Diff: external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java --- @@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-10-28 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/743#discussion_r43349321 --- Diff: external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java --- @@ -72,27 +73,27 @@ public void prepare(Map stormConf

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-10-28 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/743#issuecomment-152083005 @harshach Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-11-04 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/743#discussion_r43970097 --- Diff: external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java --- @@ -83,8 +81,8 @@ public void updateState(List tuples, TridentCollector

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-05 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/865 [STORM-1185] replace nimbus.host with nimbus.seeds You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-8 Alternatively you can

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/865#discussion_r44204593 --- Diff: conf/storm.yaml.example --- @@ -19,7 +19,7 @@ # - "server1" # - "server2" # -# nimbus.host: "ni

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/908 [STORM-1359] change kryo links from google code to github You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-9 Alternatively

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161149466 @unsleepy22 Thanks. I will fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/909 [STORM-1359] change kryo links from google code to github You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-10 Alternatively

[GitHub] storm pull request: [STORM-1359] change kryo links from google cod...

2015-12-01 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/908#issuecomment-161152398 Done.Since files are not in the same branch, I have created a new PR (https://github.com/apache/storm/pull/909) for backtype.storm.Config. --- If your project is set up

[GitHub] storm pull request: STORM-1040. SQL support for Storm.

2015-12-02 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/914#issuecomment-161491178 +1 Great work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1638: minor: fix tooltip style

2016-08-31 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1638 hi @HeartSaVioR Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] storm issue #1603: STORM-2012: Upgrade Kafka to 0.8.2.2

2016-08-31 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1603 @darionyaphet two important fixes for snappy compression. please take a look the above link first, thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-08-31 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 @abhishekagarwal87 is this should be continue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-08-31 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1665 STORM-2074: fix storm-kafka-monitor NPE bug https://issues.apache.org/jira/browse/STORM-2074 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-08-31 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 this should be merged into 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-08-31 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1665#discussion_r77106883 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java --- @@ -89,6 +89,10 @@ public static void main

[GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-08-31 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1665#discussion_r77107687 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java --- @@ -373,16 +377,20 @@ private static Options

[GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-08-31 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1665#discussion_r77109600 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java --- @@ -373,16 +377,20 @@ private static Options

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-08-31 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 Thanks @priyank5485 @abellina I think I have addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1565: STORM-1970: external project examples refator

2016-09-01 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1565#discussion_r77186650 --- Diff: examples/storm-mqtt-examples/pom.xml --- @@ -24,18 +24,24 @@ storm-mqtt-examples - -org.apache.storm -storm

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-09-01 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 hi @HeartSaVioR Of course, we should make sure that all examples are 'runnable'. >profile trick to change scope of 'storm-core' : other modules use 'intellij&#

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 Thanks @HeartSaVioR I see. Will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1665#discussion_r77310159 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java --- @@ -89,6 +89,10 @@ public static void main

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @HeartSaVioR Can we merge this in? and, it's very easy to cherry-pick to 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @HeartSaVioR OK, have a good time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-02 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 Oh, I missed it. Will update. Thanks @priyank5485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug

2016-09-04 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @priyank5485 Updated. Can you take a look again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-09-04 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 Updated. the travis-ci build error is because that `Network is unreachable` for https://clojars.org. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #1672: STORM-2081:create external directory for storm-sql...

2016-09-04 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1672 STORM-2081:create external directory for storm-sql various data sourc… …es and move storm-sql-kafka to it You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm issue #1672: [STORM-2081][SQL] create external directory for storm-sql...

2016-09-04 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1672 ci build failure is unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-09-06 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 @HeartSaVioR Could you take a look again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77604642 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,212 @@ +package

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77604777 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,212 @@ +package

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77605020 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,212 @@ +package

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77605127 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,212 @@ +package

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77605365 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,182 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77605544 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,182 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r77605825 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/DefaultBlacklistStrategy.java --- @@ -0,0 +1,142 @@ +/** + * Licensed

[GitHub] storm issue #1674: STORM-2083: Blacklist scheduler

2016-09-06 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1674 Agree with @revans2 's opinion. Especially, make this feature as a part of nimbus and show the blacklist nodes on the UI. For the third point, I feel we can add a task(eg: `ping` the st

[GitHub] storm pull request #1678: [STORM-2086][SQL] use DefaultTopicSelector instead...

2016-09-07 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1678 [STORM-2086][SQL] use DefaultTopicSelector instead of creating a new one You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM

<    1   2   3   4   5   6   >