[GitHub] storm pull request #2108: STORM-2508:storm-solr enhancement: update solrj to...

2017-08-12 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/2108#discussion_r132823455 --- Diff: external/storm-solr/pom.xml --- @@ -67,13 +67,13 @@ org.apache.solr solr-core

[GitHub] storm pull request #2108: STORM-2508:storm-solr enhancement: update solrj to...

2017-08-12 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/2108#discussion_r132823446 --- Diff: external/storm-solr/pom.xml --- @@ -46,13 +46,13 @@ org.apache.solr solr-solrj

[GitHub] storm issue #1961: Storm 2290: Upgrading zookeeper to 3.4.9 for stability

2017-02-25 Thread sachingsachin
Github user sachingsachin commented on the issue: https://github.com/apache/storm/pull/1961 @harshach - Created https://github.com/apache/storm/pull/1967 and https://github.com/apache/storm/pull/1968 --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request #1968: STORM-2290: Upgrade zookeeper to get some critical...

2017-02-25 Thread sachingsachin
GitHub user sachingsachin opened a pull request: https://github.com/apache/storm/pull/1968 STORM-2290: Upgrade zookeeper to get some critical upgrades Complements https://github.com/apache/storm/pull/1967 You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request #1967: STORM-2290: Upgrade zookeeper to get some critical...

2017-02-25 Thread sachingsachin
GitHub user sachingsachin opened a pull request: https://github.com/apache/storm/pull/1967 STORM-2290: Upgrade zookeeper to get some critical upgrades You can merge this pull request into a Git repository by running: $ git pull https://github.com/sachingsachin/storm STORM

[GitHub] storm pull request #1961: Storm 2290: Upgrading zookeeper to 3.4.9 for stabi...

2017-02-25 Thread sachingsachin
Github user sachingsachin closed the pull request at: https://github.com/apache/storm/pull/1961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1961: Storm 2290: Upgrading zookeeper to 3.4.9 for stabi...

2017-02-23 Thread sachingsachin
GitHub user sachingsachin opened a pull request: https://github.com/apache/storm/pull/1961 Storm 2290: Upgrading zookeeper to 3.4.9 for stability You can merge this pull request into a Git repository by running: $ git pull https://github.com/sachingsachin/storm STORM-2290

[GitHub] storm issue #1751: [STORM-2172][SQL] Support Avro as input / output format

2016-11-08 Thread sachingsachin
Github user sachingsachin commented on the issue: https://github.com/apache/storm/pull/1751 @vesense - The pull request looks good. Thank you. Could you also add a small note on the JIRA STORM-2172 why you are trying to support avro? It would help to track it better in the future

[GitHub] storm pull request #1751: [STORM-2172][SQL] Support Avro as input / output f...

2016-11-06 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/1751#discussion_r86680426 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/AvroSerializer.java --- @@ -0,0 +1,72

[GitHub] storm pull request #1751: [STORM-2172][SQL] Support Avro as input / output f...

2016-11-06 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/1751#discussion_r86680392 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/CachedSchemas.java --- @@ -0,0 +1,37

[GitHub] storm pull request #1751: [STORM-2172][SQL] Support Avro as input / output f...

2016-11-02 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/1751#discussion_r86188870 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/AvroScheme.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] storm pull request #1751: [STORM-2172][SQL] Support Avro as input / output f...

2016-11-02 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/1751#discussion_r86189092 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java --- @@ -0,0 +1,100 @@ +/* + * Licensed

[GitHub] storm pull request #1751: [STORM-2172][SQL] Support Avro as input / output f...

2016-11-02 Thread sachingsachin
Github user sachingsachin commented on a diff in the pull request: https://github.com/apache/storm/pull/1751#discussion_r86189208 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java --- @@ -0,0 +1,100 @@ +/* + * Licensed

[GitHub] storm pull request: Addresses network flood from KafkaSpout to kaf...

2016-03-31 Thread sachingsachin
Github user sachingsachin commented on the pull request: https://github.com/apache/storm/pull/1287#issuecomment-204216287 Very useful observation @moesol Comparing the [KafkaConfig.java](https://github.com/apache/storm/blob/a4f9f8bc5b4ca85de487a0a868e519ddcb94e852/external/storm

[GitHub] storm pull request: KafkaSpout - Improve "_lostMessageCount" metri...

2016-03-31 Thread sachingsachin
GitHub user sachingsachin opened a pull request: https://github.com/apache/storm/pull/1288 KafkaSpout - Improve "_lostMessageCount" metric for failed tuples Improve "_lostMessageCount" metric if a failed offset is beyond the configured "_spoutConfig.maxOff