Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
This should be closed after #2805 is resolved.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
@zd-project I think the Enum idea sounds nice, but I'm not sure whether it
will be so easy to implement. Some metrics depend on state in the class they're
declared, e.g. the two gauges in Container.
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Another thought on improvement of StormMetricsRegistry in general. We
should have something that works better with dependency as well. In the latest
commit to #2710 that addresses metric of
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Looks like StormMetricRegistry has already had filtering by daemon type
feature that we need. It also supports report at different intervals and such.
Apart from the injection suggestion, do you
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Dropwizard Metrics seems to have
[MetricFilter](https://metrics.dropwizard.io/3.1.0/apidocs/com/codahale/metrics/MetricFilter.html)
built-in. I think we can leverage so for filtering out unwanted
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2714
We have 4 separate metrics APIs right now
2 for daemons
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/metric/api/IClusterMetricsConsumer.java
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2714
@srdo Yeah, this is a valuable promotion for storm metrics and the
implementation will be much cleaner.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
@danny0405 Okay, thanks. I think the MetricRegistryImpl class looks nice
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2714
@srdo
Sorry, it's MetricGroup and Metric.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
@danny0405 A quick search for Role or MetricsGroup in the flink repo didn't
turn up anything. Could you elaborate on what you mean, and why/how we could
use Flink's mechanism here?
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2714
@srdo
I kind of saw the Apache Flink metrics system, is has a internal metrics
layer on top of the Yammer Metrics, every Role in Flink has a MetricsGroup, one
MetricsGroup has many Metrics
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
It might be good to consider whether we could move away from `static` for
metrics, and consider if we could do dependency injection instead? The cause of
the issue you mention on JIRA (accidentally
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Another implementation would be to require all metrics to be registered
when at least one instance of a class has been instantiated. This will
disqualify the final property of all metrics
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2714
Talked with @zd-project offline, I now have a better understand of the
problem he is trying to solve as explained in
https://issues.apache.org/jira/browse/STORM-3101. It's a really good catch.
14 matches
Mail list logo
