Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-193485875
Closing this. Feel free to reopen with updates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r42055642
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -155,7 +155,9 @@
(or (not (contains? approved-ids id))
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-148202852
The code still looks good. It needs to be upmerged because the heartbeats
have moved to use thrift. I would love to see this go in.
---
If your project is set up for i
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-148184473
@caofangkun, @revans2, @kishorvpatil, @xiaokang
Any movement on this?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r26581260
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -392,6 +392,15 @@
(.addArgument command a))
(.execute (DefaultExecutor.) command
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r26362192
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -392,6 +392,15 @@
(.addArgument command a))
(.execute (DefaultExecutor.) comm
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-78341357
For the most part it seems fine. My manual attempts to kill workers all
are foiled very quickly, but I would like to not have the supervisor be so
noisy with the ps comma
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r26240829
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -392,6 +392,15 @@
(.addArgument command a))
(.execute (DefaultExecutor.) command
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-77296982
@kishorvpatil
I have resolved merge conflicts , please review the PR again. Thank you .
---
If your project is set up for it, you can reply to this email and have
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-76745378
@caofangkun, could you please upmerge this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-72706534
The code change looks OK, but I am seeing test failures in
supervisor_test.clj. I also would prefer to have us cache the Process that we
used to launch the external proce
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-71582734
UT Tests passed and Ready for reivew.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r20565435
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
nam
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r20535744
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
name)))
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r20528140
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
nam
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r20450306
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
name)))
Github user caofangkun closed the pull request at:
https://github.com/apache/storm/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/293#issuecomment-60419007
@caofangkun If this pull request has been superseded by #296 would you mind
closing this?
---
If your project is set up for it, you can reply to this email and have your
Github user xiaokang commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-59948431
Supervisor and workers needed to be restarted if we change the
WorkerHeartbeat data structure by adding a process-id field. It may be more
easy to read worker and its chi
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/293#issuecomment-59499800
Hi @caofangkun. Could you then close this pull request?
Please see my comments in #296
---
If your project is set up for it, you can reply to this email and have
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r19012098
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
nam
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r19007702
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
name
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r19003251
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: "
nam
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18949050
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -356,6 +356,10 @@
(first split)
))
+ (defn exists-process?
--- En
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18947137
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -356,6 +356,10 @@
(first split)
))
+ (defn exists-process?
--- E
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/293#issuecomment-59339694
@itaifrenkel
Thank you for your comments
I have fixed with your suggestion, in
https://github.com/apache/storm/pull/296
---
If your project is set up for i
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/296
STORM-532:Supervisor should restart worker immediately, if the worker pr...
...ocess does not exist any more
You can merge this pull request into a Git repository by running:
$ git pull https
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18945173
--- Diff:
storm-core/src/jvm/backtype/storm/spout/SleepSpoutWaitStrategy.java ---
@@ -33,7 +33,7 @@ public void prepare(Map conf) {
@Override
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18944932
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -114,6 +114,8 @@
:disallowed
Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/293#discussion_r18943315
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -356,6 +356,10 @@
(first split)
))
+ (defn exists-process?
--- E
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/293
STORM-532,Supervisor should restart worker immediately, if the worker pr...
https://issues.apache.org/jira/browse/STORM-532
For now
if the worker process does not exist any more
32 matches
Mail list logo
