[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2018-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1515 ---

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1515#discussion_r68347350 --- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -113,6 +113,15 @@ public StormTopology createTopology() {

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1515#discussion_r68280266 --- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -339,8 +353,13 @@ public SpoutDeclarer setSpout(String id, IRichSpout

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1515#discussion_r68280207 --- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -179,8 +188,13 @@ public BoltDeclarer setBolt(String id, IRichBolt bolt)

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1515#discussion_r68279943 --- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -113,6 +113,15 @@ public StormTopology createTopology() {

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1515 [STORM-1929] Check when create topology [STORM-1929](https://issues.apache.org/jira/browse/STORM-1929) Add some check when create topology : 1. Spout and Bolt id shouldn't