Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70856636
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -391,9 +388,13 @@ public static void addEventLogger(Map conf,
StormTopology
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70809388
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/MetricsConsumerBolt.java ---
@@ -43,19 +44,21 @@
OutputCollector _collector;
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70808499
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/MetricsConsumerBolt.java ---
@@ -43,19 +44,21 @@
OutputCollector _collector;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70804467
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/api/IMetricsConsumer.java ---
@@ -54,6 +54,25 @@ public String toString() {
}
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70801243
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/api/IMetricsConsumer.java ---
@@ -54,6 +54,25 @@ public String toString() {
}
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70800983
--- Diff: conf/storm.yaml.example ---
@@ -45,6 +45,10 @@
## - when none of configuration for metric filter are specified, it'll be
treated as 'pass
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70801003
--- Diff: conf/storm.yaml.example ---
@@ -45,6 +45,10 @@
## - when none of configuration for metric filter are specified, it'll be
treated as 'pass
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70800924
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70800633
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70800422
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
+
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70787294
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70787174
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70787070
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70787015
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
@@ -0,0 +1,61 @@
+package org.apache.storm.metric.util;
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70786519
--- Diff: conf/storm.yaml.example ---
@@ -45,6 +45,10 @@
## - when none of configuration for metric filter are specified, it'll be
treated as
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70786482
--- Diff: conf/storm.yaml.example ---
@@ -45,6 +45,10 @@
## - when none of configuration for metric filter are specified, it'll be
treated as
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70786295
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/api/IMetricsConsumer.java ---
@@ -54,6 +54,25 @@ public String toString() {
}
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1560
STORM-1966 Expand metric having Map type as value into multiple metrics
based on entries
* populate metric before applying filter so that filter can play with
populated metrics
* add
19 matches
Mail list logo
