[GitHub] storm pull request #2409: STORM-2796: Flux: Provide means for invoking stati...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2409


---

[GitHub] storm pull request #2409: STORM-2796: Flux: Provide means for invoking stati...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2409#discussion_r150422396
  
--- Diff: 
flux/flux-core/src/test/resources/configs/config-methods-test.yaml ---
@@ -70,8 +70,17 @@ bolts:
 - "foo"
 - "bar"
 - "baz"
+  - id: "bolt-2"
+className: "org.apache.storm.flux.test.TestBolt"
+factory: "newInstance"
+parallelism: 1
 
-
+  - id: "bolt-3"
+className: "org.apache.storm.flux.test.TestBolt"
+factory: "newInstance"
+#factoryArgs:
--- End diff --

What if we don't comment this two lines? If it just works, I think this two 
lines should not be commented out. If it doesn't work, we may need to make it 
work, cause it is not actual tested.


---

[GitHub] storm pull request #2409: STORM-2796: Flux: Provide means for invoking stati...

[ptgoetz]

GitHub user ptgoetz opened a pull request:

https://github.com/apache/storm/pull/2409

STORM-2796: Flux: Provide means for invoking static factory methods

Note: The guts of this change are in the first commit. The last commit 
simply addresses check style violations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptgoetz/storm flux_factory_methods

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2409


commit f0abe4757076f78d987cd266e6ce4d4bd847cfb2
Author: P. Taylor Goetz 
Date:   2017-11-04T03:17:46Z

STORM-2796: Implement support for static factory methods

commit fd0d10feff3ff3beae29276c7a942a3617154658
Author: P. Taylor Goetz 
Date:   2017-11-10T18:10:03Z

add test for factory args

commit 5a6be5fb4a1bce4b7a9ddb332533aa4167ec543b
Author: P. Taylor Goetz 
Date:   2017-11-10T20:51:24Z

Address checkstyle errors.




---