Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2906
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233963942
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java
---
@@ -27,12 +27,15 @@
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233734291
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java
---
@@ -27,12 +27,15 @@
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233734900
--- Diff: storm-core/src/jvm/org/apache/storm/utils/TopologySpoutLag.java
---
@@ -68,14 +77,38 @@
commands.add((String)
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233733766
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -692,11 +692,28 @@ public String toString() {
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2906
STORM-3123 - add support for Kafka security config in storm-kafka-monitor
You can merge this pull request into a Git repository by running:
$ git pull