Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Vlad
When I see OGNL classes in exceptions stack trace, I believe it is not as fast as 2+2. But I have never thought to replace ww:property tags with %= % scriplets. ww:property performance is enough for me, for now. WebWork form tags could be really slow. After I have moved templates out of

Re: [S2] [VOTE] Struts 2.0.7 Quality

2007-03-24 Thread Pedro Herrera
+1 (GA) too Herrera Nate Drake wrote: +1 (GA) On 3/23/07, Ted Husted [EMAIL PROTECTED] wrote: There's not an actual drop-dead date. Like merit, quality votes never expire. The 72-hour clause just means that if we had 3 +1s by then, and nothing seemed awry, we might go ahead

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Ted Husted
To avoid such long threads in future, probably it makes sense to add some performance benchmark page in struts examples distribution. Would it be possible to contribute the test page you've already started? We have a ticket open. * https://issues.apache.org/struts/browse/WW-1560 I'm also

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Claus Ibsen
From the performance tuning page: Copy the /template directory from the Struts 2 jar in your WEB_APP root. Freemarker fails to properly cache templates when they are retrieved from the classpath. Copying them to the WEB_APP root allows Freemarker to cache them correctly. Freemarker looks at

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Tom Schneider
I wrote a struts2 caching implementation of the freemarker templates: https://issues.apache.org/struts/browse/WW-1661 Freemarker wouldn't know how to cache the templates as well as struts2 does since we know how the templates are being used and whether or not it is safe to cache them. Tom

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Musachy Barroso
Any reason why this shouldn't be applied on the 2.0 branch instead of 2.1? musachy On 3/24/07, Tom Schneider [EMAIL PROTECTED] wrote: I wrote a struts2 caching implementation of the freemarker templates: https://issues.apache.org/struts/browse/WW-1661 Freemarker wouldn't know how to cache

Re: XWork build failing

2007-03-24 Thread Claus Ibsen
Is it just me or is surefire not a bit strange on the xwork project? Could you try this: mvn clean mvn surefire-report:report And then look in target/site/surefire-report.html. Then click on the first test - ActionContextTest. It should have only 8 tests. but the list is much bigger on my

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Tom Schneider
Well, there is a small risk of things being cached and a developer relying on the behavior of not caching the templates. However, I think those cases will be rare and it would benefit many people. Tom Musachy Barroso wrote: Any reason why this shouldn't be applied on the 2.0 branch instead of

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Musachy Barroso
We could enable the cache when devMode is false. musachy On 3/24/07, Tom Schneider [EMAIL PROTECTED] wrote: Well, there is a small risk of things being cached and a developer relying on the behavior of not caching the templates. However, I think those cases will be rare and it would benefit

Re: XWork build failing

2007-03-24 Thread Claus Ibsen
Damm surefire seems to be a bit buggy. Just browsed it's JIRA. Created a minor bug: http://jira.codehaus.org/browse/SUREFIRE-312 - Posted via Jive Forums

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Ted Husted
As I believe the Ajax/Dojo plugin is ready, if we could mop-up the portlet plugin ticket, we could apply the caching patch to the HEAD, and get started on the 2.1.x series. Having AJAX as a plugin rather than a theme will also benefit many people :) -Ted. On 3/24/07, Tom Schneider [EMAIL

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Musachy Barroso
Yeah, I still need to confirm nothing is broken in core, except the tooltips which I know are not working. By the way Dojo 0.4.2 was released, how was the upgrade made last time? Drop the dojo files and add the new ones? musachy On 3/24/07, Ted Husted [EMAIL PROTECTED] wrote: As I believe the

Re: XWork build failing

2007-03-24 Thread James Mitchell
When I run it, here's what's in my ActionContextTest.txt --- Test set: com.opensymphony.xwork2.ActionContextTest --- Tests run: 8,

Re: Japan Sites Rules

2007-03-24 Thread SafeFromSites
Addicted to porn? Help Yourself, with out risk of embarrassment. Affordable, No software for people to see. Keep your same Internet provider. No text based filtering to interfere. http://www.safefromsites.com/help.html Life is like a video game. Where you start, the characters you will meet,