[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-173117164 @aleksandr-m I'm ok with that and I agree with @swiftelan - let's follow standards --- If your project is set up for it, you can reply to this email and have your r

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/75#discussion_r50221451 --- Diff: core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java --- @@ -777,11 +777,21 @@ protected Class verifyResul

Build failed in Jenkins: Struts-JDK8-master #78

See Changes: [cnenning] Adds new result 'JSONActionRedirectResult' to json-plugin. Contains [cnenning] made methods non static and private, javadoc updates [cnenning] increased visibilty of methods and constants for better extensibil

[GitHub] struts pull request: WW-4589 do not overwrite explicit method name

GitHub user rpii opened a pull request: https://github.com/apache/struts/pull/81 WW-4589 do not overwrite explicit method name Lukasz, here is a proposed fix for WW-4589. This makes sure a url specified method name is not overwritten by an implied method name. It passes t

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user aleksandr-m commented on a diff in the pull request: https://github.com/apache/struts/pull/75#discussion_r50173826 --- Diff: core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java --- @@ -777,11 +777,21 @@ protected Class verifyResult

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-172982203 @swiftelan So you are proposing to change only type? The name of the attribute will stay the same i.e `name`, right? There is still some chance that something going t

Re: [GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

I can't see a reason not to support both. (*Chris*) On Tue, Jan 19, 2016 at 12:06 PM, swiftelan wrote: > Github user swiftelan commented on the pull request: > > https://github.com/apache/struts/pull/75#issuecomment-172970495 > > @aleksandr-m > > An annotation attribute that is def

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user swiftelan commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-172970495 @aleksandr-m An annotation attribute that is defined as an array does not have to have the curly braces to define a single value for that attribute. Ba

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/75#discussion_r50163270 --- Diff: core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java --- @@ -777,11 +777,21 @@ protected Class verifyResul

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-172947410 @swiftelan I was thinking about that too, BUT: * It will break backward compatibility * I kind of like that annotation attributes looks the same as in xml

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user aleksandr-m commented on a diff in the pull request: https://github.com/apache/struts/pull/75#discussion_r50153311 --- Diff: core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java --- @@ -777,11 +777,21 @@ protected Class verifyResult

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

Github user swiftelan commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-172880314 Annotations allow multivalued attributes in the form of arrays. Using this makes it obvious that you can supply multiple result names for a single result configuration.

[GitHub] struts pull request: Locale aware converters

Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Struts 2.5 BETA3

I see no objections, starting with BETA3 2016-01-18 15:58 GMT+01:00 Lukasz Lenart : > If no objections I am going prepare BETA3 release > > 2016-01-11 14:53 GMT+01:00 Christoph Nenning : >>> @Christoph I was able to resolve the issue with that warning about >>> Custom EL ... also fixed the problem

[GitHub] struts pull request: WW-4412 Context started without being closed

Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/79#issuecomment-172878561 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] struts pull request: WW-4412 Context started without being closed

Github user victorsosa closed the pull request at: https://github.com/apache/struts/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] struts pull request: WW-4412 Context started without being closed

Github user victorsosa commented on a diff in the pull request: https://github.com/apache/struts/pull/79#discussion_r50120845 --- Diff: plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java --- @@ -110,7 +110,9 @@ public void doExecute(String location, ActionI

[GitHub] struts pull request: WW-4412 Context started without being closed

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/79#discussion_r50108754 --- Diff: plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java --- @@ -110,7 +110,9 @@ public void doExecute(String location, Actio

[GitHub] struts pull request: WW-4456 Got NPE when File Upload Limitation e...

GitHub user victorsosa opened a pull request: https://github.com/apache/struts/pull/80 WW-4456 Got NPE when File Upload Limitation exceeds in portal env HI Lukasz, This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation exceeds in portal env.

[GitHub] struts pull request: WW-4412 Context started without being closed

GitHub user victorsosa opened a pull request: https://github.com/apache/struts/pull/79 WW-4412 Context started without being closed Patch for WW-4412 Context started without being closed You can merge this pull request into a Git repository by running: $ git pull http

[GitHub] struts pull request: New result 'JSONActionRedirectResult' in json...

Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/72#issuecomment-172772942 > Merged #72. Yay, I got it landed :) This Email was scanned by Sophos Anti Virus --- If your project is set up for it, you can reply t