Github comments and pull request emails

2016-04-04 Thread Paul Benedict
Why aren't they going to our issues list? I don't think they should be going to our "dev" list. Can we submit a ticket with infrastructure to change the destination? Cheers, Paul

Re: Upgrade to tiles 3 jcl-over-slf4j

2016-01-29 Thread Paul Benedict
I could be wrong, but I thought log4j2 provides the equivalent bridging functionality to other logging frameworks. Cheers, Paul On Fri, Jan 29, 2016 at 11:14 AM, Greg Huber wrote: > Yes, if you are logging directly to log4j2 but if other jars use slf4j you > need to delegate the logging (create

Re: Upgrade to tiles 3 jcl-over-slf4j

2016-01-29 Thread Paul Benedict
Why not log4j2? Cheers, Paul On Fri, Jan 29, 2016 at 10:48 AM, Martin Gainty wrote: > Hi Greg- > > can you confirm these dependencies for log4j? > > > org.apache.logging.log4j > log4j-api 2.5 > > org.apache.logging.log4j > log4j-core 2.5 > junit > junit

Re: Secure parameters

2015-10-20 Thread Paul Benedict
I think the class name is very confusing. Can it just be StrutsParameters? The "secure" thing I don't think is accurate. On Oct 8, 2015 8:31 AM, "Christoph Nenning" wrote: > > From: Lukasz Lenart > > To: Struts Developers List , > > Date: 06.10.2015 08:28 > > Subject: Secure parameters > > > > H

Re: Secure parameters

2015-10-06 Thread Paul Benedict
Can you explain the "secure" aspect? I don't follow what this is trying to accomplish. This is not a criticism; just a question. Cheers, Paul On Tue, Oct 6, 2015 at 1:28 AM, Lukasz Lenart wrote: > Hi, > > I have started on introducing typed parameters instead of a Map of > objects as we have r

Re: [VOTE] Struts 2.5 BETA2

2015-10-01 Thread Paul Benedict
+1 Cheers, Paul On Thu, Oct 1, 2015 at 1:30 PM, Lukasz Lenart wrote: > 2015-09-28 22:53 GMT+02:00 Lukasz Lenart : > > [ ] Leave at test build > > [ ] Alpha > > [X] Beta > > [ ] General Availability (GA) > > +1 (binding) > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ >

Re: Struts 2.5-BETA1

2015-07-27 Thread Paul Benedict
I love votes to start a vote! Cheers, Paul On Mon, Jul 27, 2015 at 2:13 AM, Johannes Geppert wrote: > +1 for starting the vote. > > Johannes > Am 27.07.2015 08:06 schrieb "Lukasz Lenart" : > > > 2015-07-24 21:49 GMT+02:00 Johannes Geppert : > > > Is there a reason why we don't publish the java

Re: Struts 2.5-BETA1

2015-07-20 Thread Paul Benedict
tter: http://twitter.com/jogep > > > 2015-07-19 3:03 GMT+02:00 Paul Benedict : > > > Do we have any published 2.5 javadocs? > > > > > > Cheers, > > Paul > > > > On Fri, Jul 17, 2015 at 4:13 AM, Lukasz Lenart > > wrote: > > > >

Re: Struts 2.5-BETA1

2015-07-18 Thread Paul Benedict
Do we have any published 2.5 javadocs? Cheers, Paul On Fri, Jul 17, 2015 at 4:13 AM, Lukasz Lenart wrote: > Hi, > > Please take a time and test the bits - any help is appreciated. Please > report any problems back. I'll call for vote in a week if no problems > will be spotted. > > Staging Mave

Re: Starting work on 2.5

2015-05-26 Thread Paul Benedict
+1 JDK 7 Cheers, Paul On Tue, May 26, 2015 at 8:39 AM, Aaron Johnson wrote: > The best place for big changes is early in the release cycle. I haven't had > any runtime issues with JDK7 and Struts. > > On Tue, May 26, 2015 at 3:51 AM, Christoph Nenning < > christoph.nenn...@lex-com.net> wrote:

Re: Few ideas related to Struts 3

2014-12-21 Thread Paul Benedict
+1 to get rid of "do" support. Cheers, Paul On Mon, Dec 22, 2014 at 12:34 AM, Lukasz Lenart wrote: > 2014-12-21 23:19 GMT+01:00 Paul Benedict : > > Why do we support the "do" prefix at all? I don't know the answer. I'd > just > > like to know

Re: Few ideas related to Struts 3

2014-12-21 Thread Paul Benedict
Why do we support the "do" prefix at all? I don't know the answer. I'd just like to know how it came to be. PS: I am in favor of simplifying the internals of Struts. I don't like having multiple ways of naming an execution method. Cheers, Paul On Sun, Dec 21, 2014 at 1:24 PM, Lukasz Lenart wro

Re: Few ideas related to Struts 3

2014-12-15 Thread Paul Benedict
Why do you guys find it bad to access the raw request/response? I haven't found a problem doing that as a fallback. I'd like to know what you think. Cheers, Paul On Mon, Dec 15, 2014 at 10:23 AM, Ken McWilliams wrote: > > +1 for the request/response wrappers. Have you had a chance to check out:

Re: Struts 3 and namespaces

2014-12-12 Thread Paul Benedict
gt; > To me it's valuable for keeping an interceptor stack separate for api > > requests. > > > > /api/v1/people/list > > Json result > > > > Vs > > > > /listpeople.action > > Web / template result > >> On Dec 9, 2014 2:52 PM, "

Re: MNG-1683: Zip packaging

2014-12-10 Thread Paul Benedict
Sorry guys. Wrong list. :-)

MNG-1683: Zip packaging

2014-12-10 Thread Paul Benedict
Recently I needed to create zip artifacts for overlays into WAR. Maven doesn't have support for "zip" packaging type projects, but MNG-1683 wants to introduce it. I am curious why this issue has been ignored. Is it just a lack of time or interest? Or is there a philosophical issue behind? For the

Re: Struts 3 and namespaces

2014-12-09 Thread Paul Benedict
ered for > your case. > > There of course is room for improvement, perhaps considering > interceptor-stacks something like templates? That is parts of templates can > be changed out, without needing a full redefinition. > > On Tue, Dec 9, 2014 at 2:14 PM, Paul Benedict > wrote:

Re: Struts 3 and namespaces

2014-12-09 Thread Paul Benedict
t sure that counts as "really > valuable". > > On Tue, Dec 9, 2014 at 3:52 PM, Paul Benedict > wrote: > > > One concept I never really liked in S2 are namespaces. I never found a > good > > reason to logically group actions together with common interceptor

Struts 3 and namespaces

2014-12-09 Thread Paul Benedict
One concept I never really liked in S2 are namespaces. I never found a good reason to logically group actions together with common interceptor setup. Rather I always find myself in the situation where the interceptor stack is globally set and actions have one-off changes. And I also never liked how

Re: Site re-organisation

2014-12-02 Thread Paul Benedict
Yes, yes, and yes. Searching for Struts 2 help is so difficult because old documentation always floats to the top of search engine results. Finding out what's the latest solution is not easy. When a new version introduces functional changes, we will just note it on the respective page. Cheers, Pa

Re: [VOTE] Apache Struts 2.3.20

2014-12-02 Thread Paul Benedict
+1 binding On Dec 2, 2014 3:32 AM, "Christoph Nenning" wrote: > +1, non binding > > [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) > > > regards, > Christoph > > > > > > > > > > The Apache Struts 2.3.20 test build is now available. With this release: > > - merg

Re: Struts 3 request/response processing

2014-11-25 Thread Paul Benedict
n wrote: > On Tue, Nov 25, 2014 at 10:24 AM, Paul Benedict wrote: > > For example, there is no easy way in S2 to customize which action will be > > selected -- or which method on the action will be invoked. > > Customize in what way? > > Wouldn't most situa

Struts 3 request/response processing

2014-11-25 Thread Paul Benedict
I added this to the wiki [1] and would like this to have a general discussion. S1 and S2 have different infrastructure to process a request/response. They overlap to some degree in concept but each has a strength and weakness: S2 is superior by allowing the user to configure processing with "inte

Forms with PUT and DELETE

2014-11-24 Thread Paul Benedict
FYI, I came across this in my research. There's a working draft by W3C that is laying out the addition of PUT and DELETE in some future version of HTML [1]. Bookmark this to stay current. Obviously, this will be a great benefit to RESTful applications. [1] http://www.w3.org/TR/form-http-extensions

Re: Start developing on Struts3

2014-11-20 Thread Paul Benedict
I agree with the step by step approach. With GIT, each step can be a deveopment branch. It wouldn't make sense for all us all to do major refactoring in one branch. We need to lay out milestones on the wiki and merge in our work to the official struts3 branch when ready. Cheers, Paul On Thu, Nov

Re: Start developing on Struts3

2014-11-19 Thread Paul Benedict
I hope Lukasz agrees. First order of business for me is updating the package name to struts3 and updating the POM versions. Cheers, Paul On Wed, Nov 19, 2014 at 12:32 PM, Dave Newton wrote: > I'm good with this, although I'm struggling to find time for anything > these days. > > I'd like to do

@ConversionErrorFieldValidator and short circuiting

2014-11-13 Thread Paul Benedict
This validator is really primordial. If this validation error is triggered, it makes no sense to process any other validators on the same field. Besides, if the conversion fails, the field itself can't even be stored. I think we should mark this in 2.5 as shortCircuit=true because of that. Thought

Conversion errors and json

2014-11-13 Thread Paul Benedict
"jsonValidationWorkflowStack" includes "basicStack" which includes "conversionError" interceptor... An unintended consequence is that conversion error messages cannot be customized because ConversionErrorInteceptor runs before ValidationInterceptor and, thus, will automatically report the field co

Re: Is ModelDriven validation broken?

2014-11-13 Thread Paul Benedict
The answer is no, but I had to dig for the answer. http://struts.apache.org/release/2.3.x/docs/visitorfieldvalidator-annotation.html We need to link to this document from the former. Cheers, Paul On Thu, Nov 13, 2014 at 12:14 PM, Paul Benedict wrote: > From the docs: "Validation will

Is ModelDriven validation broken?

2014-11-13 Thread Paul Benedict
>From the docs: "Validation will also be performed on this model object, instead of the action." [1] The validation is not performed on the model object with annotations. I stepped through the (Annotation)ValidationInterceptor and neither test for ModelDriven and look into the model for annotations

Re: Ideas for 3.0 (aka let's branch)

2014-11-09 Thread Paul Benedict
Whatever we choose to do, I would like to first work on rearranging the packages to make the api clear. On Nov 9, 2014 8:11 AM, "Lukasz Lenart" wrote: > 2014-11-09 3:23 GMT+01:00 Paul Benedict : > > We should whiteboard on the wiki. Here are some things I had in mind: > >

Ideas for 3.0 (aka let's branch)

2014-11-08 Thread Paul Benedict
We should whiteboard on the wiki. Here are some things I had in mind: * Target Java 7 and EE 6 minimum * Refactor to clearly delineate framework externals (apis) and framework internals * Replace XWork annotations with Beans Validation annotations * Replace XWork injection with CDI injection * Ful

Re: @required attribute

2014-11-07 Thread Paul Benedict
I'd rather break everything at once. That's how I feel about it. I don't want to keep on telling users migration plans from 2.3 to 2.5 and 2.5 to 3.0 Cheers, Paul On Fri, Nov 7, 2014 at 8:59 AM, Lukasz Lenart wrote: > 2014-11-07 15:56 GMT+01:00 Paul Benedict : > >

Re: @required attribute

2014-11-07 Thread Paul Benedict
next large-ish > release. > > > > On Fri, Nov 7, 2014 at 12:25 AM, Lukasz Lenart > wrote: > > 2014-11-07 6:15 GMT+01:00 Paul Benedict : > >> I noticed our free marker templates are outputting required="true" into > the > >> HTML fields. This is invali

@required attribute

2014-11-06 Thread Paul Benedict
I noticed our free marker templates are outputting required="true" into the HTML fields. This is invalid HTML. It needs to be required (name with no value) or required="required" for XHTML. Cheers, Paul

Re: [VOTE] Struts 2.3.18

2014-11-05 Thread Paul Benedict
+1 binding. Cheers, Paul On Wed, Nov 5, 2014 at 5:52 AM, i...@flyingfischer.ch wrote: > +1 not binding. > > Markus Fischer > > Am 04.11.2014 um 20:28 schrieb Lukasz Lenart: > >> Should I cancel this vote and prepare new one? If we cannot release >> what was tested and verified the whole proces

Re: Announcing the new "Powered By Apache" logo

2014-10-02 Thread Paul Benedict
Do we have a new "Struts" word art? Cheers, Paul On Thu, Oct 2, 2014 at 7:51 AM, Dave Newton wrote: > Seems reasonable > > On Thu, Oct 2, 2014 at 8:31 AM, Lukasz Lenart > wrote: > > > Should we prepare the same "Powered by..." logo? > > > > > > -- Forwarded message -- > > From

Re: Struts 2.5

2014-09-19 Thread Paul Benedict
Lots of work to write a line? Cheers, Paul On Fri, Sep 19, 2014 at 9:58 AM, Lukasz Lenart wrote: > 2014-09-19 16:50 GMT+02:00 Paul Benedict : > > Well... we can also bind the plugin to the appropriate minimum version of > > Struts. That shouldn't be hard to do. Either

Re: Struts 2.5

2014-09-19 Thread Paul Benedict
hould document it on the plugin site. Cheers, Paul On Fri, Sep 19, 2014 at 6:38 AM, Lukasz Lenart wrote: > 2014-09-18 16:03 GMT+02:00 Paul Benedict : > > You do it just like Maven does it. You document it. :-) > > Problem is with guys that don't use Maven... > > > Re

Re: New logo

2014-09-19 Thread Paul Benedict
13:07, schrieb Lukasz Lenart: > >>>> > >>>> Next version of website > >>>>> > >>>>> Main page > >>>>> https://copy.com/BhaCZtoewOYV > >>>>> Documentation pages > >>>>> https://copy.com/S2Dc0SCoHyv3 &g

Re: Struts 2.5

2014-09-18 Thread Paul Benedict
You do it just like Maven does it. You document it. :-) Cheers, Paul On Thu, Sep 18, 2014 at 3:31 AM, Lukasz Lenart wrote: > 2014-09-17 16:25 GMT+02:00 Paul Benedict : > > PS: When 3.0 comes around, I recommend we split off all plugins into > > independent release cycles lik

Re: Struts 2.5

2014-09-17 Thread Paul Benedict
MO it implies > support. > > People still ask questions about the Dojo plugin on Stack Overflow, running > in S2.3. The plugin must die. > > On Wed, Sep 17, 2014 at 10:17 AM, Paul Benedict > wrote: > > > Ah, struts-extras... how time comes full circle. Struts 1 had it

Re: Struts 2.5

2014-09-17 Thread Paul Benedict
Ah, struts-extras... how time comes full circle. Struts 1 had its extra package too: http://struts.apache.org/development/1.x/struts-extras/ What does creating the new project buy us? or an end-user? Just curious. Not criticizing; just wanting to learn your plan. Cheers, Paul On Wed, Sep 17, 20

Re: MVC 1.0: JSR 371

2014-08-29 Thread Paul Benedict
There is always talk of the mythical Struts 3.0 :-) Cheers, Paul On Fri, Aug 29, 2014 at 10:23 AM, Frans Thamura wrote: > hi all > MVC 1.0 > > will we have Struts JavaMVC spec implementation? > > > https://jcp.org/en/jsr/detail?id=371 > > > F > > --

Re: [jax-rs-spec users] [jsr339-experts] MVC 1.0 JSR

2014-08-19 Thread Paul Benedict
I never heard of a JSR that codifies an "official" MVC solution. If you have the JSR number for what you're speaking about, let me know. Cheers, Paul On Tue, Aug 19, 2014 at 12:06 PM, Frans Thamura wrote: > anyone know this? > > MVC become JSR. > > F > > > > -- Forwarded message -

Re: dynamic interceptor insertion

2014-07-02 Thread Paul Benedict
Most of the time, if not 99% of the time, all I want to do is add an interceptor before or after some known interceptor. As I've gone on record before, I want this feature too :-) Cheers, Paul On Wed, Jul 2, 2014 at 7:16 PM, Ken McWilliams wrote: > Thank you Lukasz I'll put it on my todo lis

Re: Do we still sign releases?

2014-06-24 Thread Paul Benedict
at 8:55 AM, Paul Benedict wrote: > Thanks everyone. I am just breaking the rust off of my release manager > skills. I'll see what I can do. > > > Cheers, > Paul > > > On Tue, Jun 24, 2014 at 8:52 AM, Christian Grobmeier > wrote: > >> Its actually

Re: Do we still sign releases?

2014-06-24 Thread Paul Benedict
repository.apache.org/content/groups/public/org/ >>> apache/struts/struts2-core/2.3.16/ >>> >>> and this is verified by Nexus during Closing repository (I think) >>> >>> 2014-06-24 3:20 GMT+02:00 Paul Benedict : >>> >>>> Back in t

Do we still sign releases?

2014-06-23 Thread Paul Benedict
Back in the 1.x days, we signed releases (the jars, zips, etc.). I don't know if we always did, but I did when I was release manager. Is that practice still in force? ... And do we do that for Struts 2 as well? Cheers, Paul

Lost JIRA admin rights to STR & WW

2014-06-20 Thread Paul Benedict
Who, so mighty and powerful, can grant me the karma back? Cheers, Paul

Re: does not accept expressions?

2014-06-18 Thread Paul Benedict
truts. I do what I can do make > sure > > > my > > > > > JSP > > > > > > usage sticks with the EE standard. > > > > > > > > > > > > > > > > > > > > > > > > > > &

Re: does not accept expressions?

2014-06-18 Thread Paul Benedict
; > replace > > > > > OGNL with EL? There doesn't seem to be much of a community around > > > updating > > > > > OGNL. The newer versions of EL have improved support for usage > outside > > > of > > > > > the

Re: does not accept expressions?

2014-06-17 Thread Paul Benedict
of a community around > updating > > > OGNL. The newer versions of EL have improved support for usage outside > of > > > the JSP environment. Is it possible to use EL in the other templates > > > (Velocity, Freemarker, etc)? It is very confusing to have to work with >

Re: does not accept expressions?

2014-06-17 Thread Paul Benedict
JSP environment. Is it possible to use EL in the other templates > (Velocity, Freemarker, etc)? It is very confusing to have to work with > multiple expression contexts (ValueStack lookups and JSTL) when authoring > JSPs. > > > On Mon, Jun 16, 2014 at 11:12 AM, Paul Benedict >

Re: does not accept expressions?

2014-06-16 Thread Paul Benedict
Maybe we should have two versions of the tags? One that accepts EL (and never executes OGNL) and another one that does. Quite honestly, I have no use for OGNL inside of JSP. Cheers, Paul On Mon, Jun 16, 2014 at 11:05 AM, Paul Benedict wrote: > That's disappointing that we're

Re: does not accept expressions?

2014-06-16 Thread Paul Benedict
x/docs/why-cant-i-use-jstl-style-el-expressions-in-struts-tags.html > > > On Mon, Jun 16, 2014 at 11:26 AM, Paul Benedict > wrote: > > > Is this a bug? I cannot use an EL expression to set the "value" > attribute. > > I don't understand why such a restric

does not accept expressions?

2014-06-16 Thread Paul Benedict
Is this a bug? I cannot use an EL expression to set the "value" attribute. I don't understand why such a restriction exists. Thoughts? Cheers, Paul

Re: Re: Less boilerplate in code

2014-05-16 Thread Paul Benedict
Christoph, I don't think the problem is in using SLF4J in itself. The problem is it's not appropriate to switch logging frameworks in a patch release. Adding a dependency is going to cause major upgrade headaches -- especially logging dependencies. If anything is done, this will be on the 2.5 or 3.

Re: Merging XWork into Struts Core

2014-05-11 Thread Paul Benedict
On Sun, May 11, 2014 at 6:10 AM, Lukasz Lenart wrote: > Basically we have two "core"s - and what I want to do is to merge them > to be the real core (not divided), thus should also remove some clumsy > code which exists in XWork-Core just to satisfy Struts-Core's needs. > And also reduce some dupl

Re: Merging XWork into Struts Core

2014-05-11 Thread Paul Benedict
Instead of merging, perhaps what you really need to do is modify the XWork API to make it more extensible. It does seem a bit crazy you need to constantly change both. XWork should be as un-struts as possible, I think. Cheers, Paul On Fri, May 9, 2014 at 1:00 AM, Lukasz Lenart wrote: > Hi, > >

Re: Merging XWork into Struts Core

2014-05-10 Thread Paul Benedict
should think about where XWork fits into there. Is XWork really part of the Struts API? Because maybe more of Struts needs to move into XWork than the other way around. Cheers, Paul On Sat, May 10, 2014 at 6:15 PM, Paul Benedict wrote: > Instead of merging, perhaps what you really need to do

Re: [struts-dev] Re: Ultimate way to solve problems with Ognl

2014-05-04 Thread Paul Benedict
On Sun, May 4, 2014 at 12:57 PM, Jason Pyeron wrote: > This begs the question (only spent a minute reviewing) should the call to > com.sun.GoingToHackYourBox be a silent denial or a "big" stacktrace error? > I don't think we want a stack trace for user input. That is a vector for a DoS attack be

Re: [VOTE][FASTTRACK] Struts 2.3.16.3

2014-05-02 Thread Paul Benedict
+1 Cheers, Paul On Fri, May 2, 2014 at 4:16 PM, Don Brown wrote: > +1 > > > On Fri, May 2, 2014 at 1:58 PM, Dave Newton wrote: > > > +1 > > On May 2, 2014 3:52 PM, "Lukasz Lenart" wrote: > > > > > The Struts 2.3.16.3 test build is now available. It includes the > > > latest security patch w

Re: [VOTE][FASTTRACK] Struts 2.3.16.2

2014-04-25 Thread Paul Benedict
+1 On Fri, Apr 25, 2014 at 3:59 PM, Lukasz Lenart wrote: > +1 GA (binding) > > 2014-04-24 23:13 GMT+02:00 Lukasz Lenart : > > The Struts 2.3.16.2 test build is now available. It includes the > > latest security patch which fixes two possible vulnerabilities: > > - Improves excluded params to avo

Re: Let's introduce a Maven BOM POM

2014-04-15 Thread Paul Benedict
e included/excluded in the > BOM > > > > > umbrella? > > > > > > > > > > > > > > > ideas on where the source might be ? > > > > > > > > > > Thanks > > > > > Martin- > > > > > &g

Re: Let's introduce a Maven BOM POM

2014-04-15 Thread Paul Benedict
gt; > > > > Thanks > > > Martin- > > > > > > > > > > > > > From: lukaszlen...@apache.org > > > > Date: Tue, 15 Apr 2014 12:25:59 +0200 > > > > Subject: Re: Let's introduce a Maven BOM POM > > > > To:

Re: Let's introduce a Maven BOM POM

2014-04-15 Thread Paul Benedict
> project first - we have got some comment about that and introducing > > BOM doesn't help those newbies ;-) > > > > 2014-04-14 23:23 GMT+02:00 Paul Benedict : > > > Quite frankly, I am tired of repeating Maven version numbers and/or > > > property subs

Let's introduce a Maven BOM POM

2014-04-14 Thread Paul Benedict
Quite frankly, I am tired of repeating Maven version numbers and/or property substitutions in my Struts 2 applications. I just want to import the right POM and forgo all the version tricks. See my inspiration here: http://docs.spring.io/spring/docs/4.0.0.RELEASE/spring-framework-reference/html/ove

Re: Param names with spaces

2014-03-27 Thread Paul Benedict
Spaces cannot exist for names of JavaBean properties. It doesn't make sense to have those. On Thu, Mar 27, 2014 at 1:54 AM, Lukasz Lenart wrote: > Hi, > > I have applied patch attached to WW-4250 [1] to support Chinese > characters as param names, but I figured out that I forgot to test > that p

Re: New logo

2014-03-21 Thread Paul Benedict
I think the website looks great with the new design and logo. On Fri, Mar 21, 2014 at 8:11 AM, Lukasz Lenart wrote: > Camel cased version > https://copy.com/jC4OWepdqrvP > > 2014-03-21 12:59 GMT+01:00 Lukasz Lenart : > > She's working on new layout, first attempt: > > > > https://copy.com/Ly91R3

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Paul Benedict
Wouldn't it make more sense for github requests to be sent to the commits list than dev? On Wed, Feb 19, 2014 at 12:20 AM, Lukasz Lenart wrote: > The final test > > 2014-02-18 16:09 GMT+01:00 Humbedooh : > > Github user Humbedooh commented on the pull request: > > > > https://github.com/apac

Re: HTTP PUT request with message body

2014-02-11 Thread Paul Benedict
that http put method is not enabled in its > Tomcat by default, so the "name=test" > is not put into the requestParamterMap by the container and struts2 core > actions do not handle parsing the msg body and put it into the Map for the > PUT req. > > Thank you > > &g

Re: HTTP PUT request with message body

2014-02-11 Thread Paul Benedict
Dong, how are you issuing your HTTP PUT request? You can't do it through HTML since HTML does not support those verbs. Are you doing it in Javascript? On Tue, Feb 11, 2014 at 5:06 AM, Dave Newton wrote: > My initial guess would be because the additional HTTP verbs besides get and > post don't u

Re: Possible Bug When Using default-action-ref?

2014-01-16 Thread Paul Benedict
The string being shown in the email is: & So that means the output should be a literal "&" but why? Why would you want to output that? I think the error is the extra "amp;" On Thu, Jan 16, 2014 at 12:39 PM, Chris Pratt wrote: > It's apparently being double-XML-encoded. The first time chang

Re: Svn to Git migration

2014-01-16 Thread Paul Benedict
gt; > process where such move happens as a part of an Apache policy. So moving > > something to something called "attic" makes me shout out "I'm not dead > > yet!" spontaneously :) > > > > So far, I would really tend to go into read-only mode

Re: Svn to Git migration

2014-01-15 Thread Paul Benedict
We suppose to cut off the wire - as moving the repos showed that we > still have a problem with DTDs. And published POMs shouldn't be a > problem, there are links in ciManagement section only or do I miss > something? > > > Regards > -- > Łukasz > + 48 606 323 122 htt

Re: Svn to Git migration

2014-01-14 Thread Paul Benedict
> > > I think it isn't needed. I'm going to move everything to 'attic' > > > folder to be backed up and create README about migration > > > > > > 2014/1/14 Paul Benedict : > > >> Can you request to turn it read only? > >

Re: Svn to Git migration

2014-01-14 Thread Paul Benedict
Can you request to turn it read only? On Jan 14, 2014 11:58 AM, "Lukasz Lenart" wrote: > Migration to Git is almost done! Please DON'T use Subversion anymore! > > https://issues.apache.org/jira/browse/INFRA-7174 > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > 2014/1/9

Re: Re-organise docs

2013-12-16 Thread Paul Benedict
ce code will contain only source code and JavaDocs, > >> the rest will be outside it. > >> > >> > >> Regards > >> -- > >> Łukasz > >> + 48 606 323 122 http://www.lenart.org.pl/ > >> > >> 2013/12/11 Paul Benedict

Re: Re-organise docs

2013-12-11 Thread Paul Benedict
m Confluence and will put them under /docs > > 2. used after release to update JavaDocs (regenerate from tag) and > > Docs (copy from /docs to /release/2.3.x/docs) > > > > WDYT? > > > > https://issues.apache.org/jira/browse/INFRA-6350 > > > > > > R

Re: [VOTE] Struts 2.3.16

2013-12-05 Thread Paul Benedict
For any early adopters, please try out the new "postback" result. I'd like to hear any feedback. The primary use case is to take the current request parameters and allow it to be POST-ed to another URL. On Thu, Dec 5, 2013 at 10:46 AM, Volker Krebs wrote: > If I may vote, I'll give it a +1 for

Re: Re-organise docs

2013-11-05 Thread Paul Benedict
I usually find it a life-saver to see the docs of previous versions. Not everyone upgrades and it's impossible to compare latest syntax and features to what was before. I think we definitely need to keep the docs of the previously published versions around. If you don't want to do that, then I thi

Re: Work in progress - 2.3.16

2013-10-24 Thread Paul Benedict
Yasser, do you know why it doesn't work in Jetty ... like an exception is thrown? On Thu, Oct 24, 2013 at 3:19 PM, Yasser Zamani wrote: > Congrats :) > > I'm not sure how much is important but " works now with Jetty" > is not mentioned @ https://cwiki.apache.org/** > confluence/display/WW/Versio

Re: Html5 theme

2013-10-18 Thread Paul Benedict
BTW, this was regarding the tag attributes: "We should at least put in the TLD the HTML version the spec belongs to so IDE completion can inform the user." On Fri, Oct 18, 2013 at 9:19 AM, Paul Benedict wrote: > The notion of theme is about a kind of stylistic output -- not spec

Re: Html5 theme

2013-10-18 Thread Paul Benedict
er. I believe the HTML 4 spec simply ignores unknown elements and attributes. So, there may not be anything "special" for us to do programming wise. Paul On Fri, Oct 18, 2013 at 1:55 AM, Lukasz Lenart wrote: > 2013/10/17 Paul Benedict : > > HTML is now a living spec. T

Re: Security judges

2013-10-17 Thread Paul Benedict
Throw an exception instead. If Struts has a default exception handler, translate the exception into a 403; but the goal is to give the user a chance to customize the response. On Thu, Oct 17, 2013 at 6:46 AM, Lukasz Lenart wrote: > 2013/10/10 Lukasz Lenart : > > 2013/10/10 Steven Benitez : > >>

Re: Html5 theme

2013-10-17 Thread Paul Benedict
HTML is now a living spec. Their plan is to have 5.0 finished in 2014 and spin off a new version every two years: http://dev.w3.org/html5/decision-policy/html5-2014-plan.html So I don't think it's good we come up with a new theme since 5.1, 5.2, etc. will be out in sort-of rapid pace. I believe th

Re: Security judges

2013-10-10 Thread Paul Benedict
Sounds like what Spring Security has: http://docs.spring.io/spring-security/site/docs/2.0.x/apidocs/org/springframework/security/vote/AuthenticatedVoter.html Each request goes through a list of voters. Paul On Thu, Oct 10, 2013 at 2:50 AM, Lukasz Lenart wrote: > 2013/10/10 Steven Benitez : > >

Re: Strict DMI

2013-10-10 Thread Paul Benedict
ot;method:" prefix seems to indicate that > the Action Class is the "action" and that it is somehow convenient to be > able to address another method of the _action_. Why not just do it > directly? That is why I ask: What am I missing? > > > On Wed, Oct 9, 2013 at

Re: Security judges

2013-10-09 Thread Paul Benedict
I like the idea except the Judge name. I think Authenticator is fine. On Wed, Oct 9, 2013 at 3:21 PM, Steven Benitez wrote: > Can you clarify how this would affect custom action mappers? > > > On Wed, Oct 9, 2013 at 4:05 PM, Lukasz Lenart >wrote: > > > Hi, > > > > Another idea is to add some lo

Re: DeprecationInterceptor

2013-10-09 Thread Paul Benedict
Okay, good. Document it as such as no one else will wonder. :-) On Wed, Oct 9, 2013 at 3:08 PM, Lukasz Lenart wrote: > 2013/10/9 Maurizio Cucchiara : > > Hi Lukasz, > > sounds good, but what happen when they use a custom stack? > > don't they see any warning message? > > I was planning to enable

Re: Strict DMI

2013-10-09 Thread Paul Benedict
down DMI. The upside to a > > > separate annotation was that it was completely compatible with XML > > > configuration (which I use). It also had a nice benefit of being > > > documentation, as well. No ambiguity as to whether an method was an > > > invocable ac

Re: Strict DMI

2013-10-04 Thread Paul Benedict
I like that WAY better. Instead of using opaque strings in @Action, use @ActionMethod on the destination methods. +1 On Fri, Oct 4, 2013 at 4:31 AM, Lukasz Lenart wrote: > 2013/10/3 Steven Benitez : > > Why not just have an @ActionMethod annotation? If its on the action > method, > > you can inv

Re: We are live :-)

2013-09-17 Thread Paul Benedict
Nice work. On Tue, Sep 17, 2013 at 3:15 PM, Philip Luppens wrote: > On Tue, Sep 17, 2013 at 9:11 PM, Christian Grobmeier >wrote: > > > Hey all, > > > > we have a new main site, I just pulled the trigger :-) > > > > http://struts.apache.org > > > > Thanks to all who corrected a lot of things whe

Re: Docs: Working on Struts main

2013-09-13 Thread Paul Benedict
Where can I see the "new" website before it goes live? On Fri, Sep 13, 2013 at 2:22 AM, Rene Gielen wrote: > As this a major change, a formal vote might be a valid option. > Am 12.09.2013 11:26 schrieb "Lukasz Lenart" : > > > Can we go live? > > > > 2013/9/11 Lukasz Lenart : > > > I think we c

Re: Doubting OGNL

2013-09-04 Thread Paul Benedict
Although Freemarker/Velocity doesn't have a JSP container, I think you can somehow bridge the two. Check out this blog post: http://illegalargumentexception.blogspot.com/2008/04/java-using-el-outside-j2ee.html On Wed, Sep 4, 2013 at 1:19 PM, Steven Benitez wrote: > I prefer EL over OGNL, but t

Re: Something to think about maybe

2013-09-04 Thread Paul Benedict
Christian, I agree on the "awful" documentation part. The S1 documentation is better organized than S2. I thank everyone who wrote S2 documentation, but it is incredibly difficult to sift through to find an answer. The wiki may not be the right tool for the documentation although I don't have an al

Re: Doubting OGNL

2013-09-04 Thread Paul Benedict
;http://struts.apache.org/release/2.3.x/docs/s2-012.html> > - S2-015 <http://struts.apache.org/release/2.3.x/docs/s2-015.html> > - S2-016 <http://struts.apache.org/release/2.3.x/docs/s2-016.html> > > > On Wed, Sep 4, 2013 at 9:31 AM, Paul Benedict > wrote: > >

Re: Doubting OGNL

2013-09-04 Thread Paul Benedict
IMO, I see no use for OGNL outside of the view layer. What good use cases are there to evluate OGNL in anything else? I also don't think it should be used inside of struts.xml either. On Wed, Sep 4, 2013 at 9:50 AM, Cameron Morris wrote: > I'm an outsider here, but I thought I'd chime in on thi

Re: Doubting OGNL

2013-09-04 Thread Paul Benedict
lification of the templates (and potential speedups). > I found Struts-Tags often rely on the com.opensymphony.xwork2.ognl > package (accessing the valuestack). My guess is, everything which access > the value stack is done with with OGNL. I think Validation bases on OGNL > too. >

  1   2   3   4   5   6   7   8   >