Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-25 Thread Greg Huber
RC3 seems build OK now.  Thanks. On 24/02/2022 11:23, Lukasz Lenart wrote: czw., 24 lut 2022 o 10:16 Greg Huber napisał(a): ..the rc3 branch (from github) looks great! 😁😁 Great! I've prepared another test build but didn't publish it yet as I have a problem accessing a SSH server to transfer f

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-24 Thread Lukasz Lenart
czw., 24 lut 2022 o 10:16 Greg Huber napisał(a): > > ..the rc3 branch (from github) looks great! 😁😁 Great! I've prepared another test build but didn't publish it yet as I have a problem accessing a SSH server to transfer files between https://repository.apache.org and https://dist.apache.org/repo

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-24 Thread Greg Huber
..the rc3 branch (from github) looks great! 😁😁 On 23/02/2022 09:18, Lukasz Lenart wrote: OSM!!! śr., 23 lut 2022 o 08:53 Greg Huber napisał(a): I tested the usecase struts.date.formatter=dateTimeFormatter >> Too many pattern letters: a struts.date.formatter=simpleDateFormatter >> Wednesda

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-23 Thread Lukasz Lenart
OSM!!! śr., 23 lut 2022 o 08:53 Greg Huber napisał(a): > > I tested the usecase > > > > struts.date.formatter=dateTimeFormatter >> Too many pattern letters: a > > struts.date.formatter=simpleDateFormatter >> Wednesday, 23 Feb 12:00 PM > > Looks good to me. > > roll RC3😁 > > On 23/02/2022 06:19,

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-22 Thread Greg Huber
I tested the usecase struts.date.formatter=dateTimeFormatter >> Too many pattern letters: a struts.date.formatter=simpleDateFormatter >> Wednesday, 23 Feb 12:00 PM Looks good to me. roll RC3😁 On 23/02/2022 06:19, Lukasz Lenart wrote: wt., 22 lut 2022 o 15:07 Greg Huber napisał(a): Date i

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-22 Thread Lukasz Lenart
wt., 22 lut 2022 o 15:07 Greg Huber napisał(a): > > Date is fine. > > The org.apache.struts2.components.Date class can handle other types ie > LocalDateTime, LocalDate, Instant bean types, I can only test the > java.util.Date variant. > > (..saying that, it would most probably work as LocalDate is

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-22 Thread Greg Huber
Date is fine. The org.apache.struts2.components.Date class can handle other types ie LocalDateTime, LocalDate, Instant bean types, I can only test the java.util.Date variant. (..saying that, it would most probably work as LocalDate is the only new variant introduced on this change.) It wor

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-22 Thread Lukasz Lenart
wt., 22 lut 2022 o 09:53 Greg Huber napisał(a): > Checking my beans, all of my dates are of type java.sql.Timestamp > (datetime on mariadb) > > On class > > Date.end(Writer writer, String body) > > matches java.util.Date > > Object dateObject = findValue(name); > if (dateObject instanceof

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-22 Thread Greg Huber
Great, one less call to hungry TextProvider😉. Passes my tests, and screen wise, for me, each formatter matches exactly struts.date.formatter=dateTimeFormatter struts.date.formatter=simpleDateFormatter ## Checking my beans, all of my dates are of type java.sql.Timestamp (datetime on mariadb)

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-21 Thread Lukasz Lenart
pon., 21 lut 2022 o 09:29 Greg Huber napisał(a): > > When using branch : WW-5016-uses-proper-format > > struts.date.formatter=simpleDateFormatter > > I get lots of these warnings > > 2022-02-21 08:21:36,677 WARN > com.opensymphony.xwork2.util.AbstractLocalizedTextProvider > AbstractLocalizedTextPr

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-21 Thread Greg Huber
When using branch : WW-5016-uses-proper-format struts.date.formatter=simpleDateFormatter I get lots of these warnings 2022-02-21 08:21:36,677 WARN com.opensymphony.xwork2.util.AbstractLocalizedTextProvider AbstractLocalizedTextProvider:findDefaultText - Missing key [struts.date.format] in bu

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
pon., 21 lut 2022 o 08:44 Greg Huber napisał(a): > > is it ready to test? I can do a merge on a rc2 branch and see what happens. Yes, it's ready. You can test different formatters by defining constant: struts.date.formatter=dateTimeFormatter // new Java 8 API or struts.date.formatter=simpleDat

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
is it ready to test? I can do a merge on a rc2 branch and see what happens. On 21/02/2022 07:37, Lukasz Lenart wrote: pon., 21 lut 2022 o 08:36 Greg Huber napisał(a): which pr? https://github.com/apache/struts/pull/529 Cheers Łukasz --

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
pon., 21 lut 2022 o 08:36 Greg Huber napisał(a): > > which pr? https://github.com/apache/struts/pull/529 Cheers Łukasz - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
which pr? On 21/02/2022 07:35, Lukasz Lenart wrote: Great! The one PR left and we are good :) pon., 21 lut 2022 o 08:30 Greg Huber napisał(a): Yes, thanks 😁 On 20/02/2022 16:29, Lukasz Lenart wrote: Is that ok? https://cwiki.apache.org/confluence/display/WW/Struts+2.5+to+6.0.0+migration#Str

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
Great! The one PR left and we are good :) pon., 21 lut 2022 o 08:30 Greg Huber napisał(a): > > Yes, thanks 😁 > > On 20/02/2022 16:29, Lukasz Lenart wrote: > > Is that ok? > > https://cwiki.apache.org/confluence/display/WW/Struts+2.5+to+6.0.0+migration#Struts2.5to6.0.0migration-JavatemplateCheckbo

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
Yes, thanks 😁 On 20/02/2022 16:29, Lukasz Lenart wrote: Is that ok? https://cwiki.apache.org/confluence/display/WW/Struts+2.5+to+6.0.0+migration#Struts2.5to6.0.0migration-JavatemplateCheckboxtag niedz., 20 lut 2022 o 16:45 Greg Huber napisał(a): yes, looks ok. On Sun, 20 Feb 2022 at 12:32, L

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
Is that ok? https://cwiki.apache.org/confluence/display/WW/Struts+2.5+to+6.0.0+migration#Struts2.5to6.0.0migration-JavatemplateCheckboxtag niedz., 20 lut 2022 o 16:45 Greg Huber napisał(a): > > yes, looks ok. > > On Sun, 20 Feb 2022 at 12:32, Lukasz Lenart wrote: > > > niedz., 20 lut 2022 o 13:0

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
yes, looks ok. On Sun, 20 Feb 2022 at 12:32, Lukasz Lenart wrote: > niedz., 20 lut 2022 o 13:07 Greg Huber napisał(a): > > > > Yes, I know this was not in the original rc, but its worth including in > > this release if possible (to keep the plugin insync with the freemarker). > > > > The defaul

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
niedz., 20 lut 2022 o 13:07 Greg Huber napisał(a): > > Yes, I know this was not in the original rc, but its worth including in > this release if possible (to keep the plugin insync with the freemarker). > > The default is now to hide the hidden field, so a review of tags might > be necessary. Sur

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
Yes, I know this was not in the original rc, but its worth including in this release if possible (to keep the plugin insync with the freemarker). The default is now to hide the hidden field, so a review of tags might be necessary. On 20/02/2022 11:57, Lukasz Lenart wrote: niedz., 20 lut 2022

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
niedz., 20 lut 2022 o 11:11 Greg Huber napisał(a): > can we include the java templates stuff for submitUnchecked? There must > be a few users using the plugin. You mean this PR [1] and your comment [2] to add it to the guideline? [1] https://github.com/apache/struts/pull/531 [2] https://github.c

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
can we include the java templates stuff for submitUnchecked? There must be a few users using the plugin. On 20/02/2022 09:38, Lukasz Lenart wrote: niedz., 20 lut 2022 o 10:23 Lukasz Lenart napisał(a): Yes, there were a small refactoring around this and all those interfaces have been moved int

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
niedz., 20 lut 2022 o 10:23 Lukasz Lenart napisał(a): > Yes, there were a small refactoring around this and all those > interfaces have been moved into org.apache.struts2.action.* package to > indicates that they should be used with actions > https://issues.apache.org/jira/browse/WW-4963 I extend

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Greg Huber
Ok thanks, they seem to work :-) On 20/02/2022 09:23, Lukasz Lenart wrote: pt., 18 lut 2022 o 11:46 Greg Huber napisał(a): Noticed these are now marked as depreciated. Is this part of v6 stuff? org.apache.struts2.interceptor.ServletRequestAware; org.apache.struts2.interceptor.SessionAware;

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-20 Thread Lukasz Lenart
pt., 18 lut 2022 o 11:46 Greg Huber napisał(a): > > Noticed these are now marked as depreciated. Is this part of v6 stuff? > > org.apache.struts2.interceptor.ServletRequestAware; > org.apache.struts2.interceptor.SessionAware; > > > Interface ServletRequestAware Yes, there were a small refact

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-18 Thread Greg Huber
Noticed these are now marked as depreciated.  Is this part of v6 stuff? org.apache.struts2.interceptor.ServletRequestAware; org.apache.struts2.interceptor.SessionAware; Interface ServletRequestAware On 29/01/2022 16:49, Lukasz Lenart wrote: Hello, This is a second RC of incoming Struts 6.

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-06 Thread Łukasz Lenart
tion including path '/WEB-INF/jsp/my.jsp'. > >> 3. ... > >> > >> *File*: java/time/format/DateTimeFormatterBuilder.java > >> *Line number*: 1,774 > >> > >> > >> although if I test ' dd, hh:mm aa' using Si

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-06 Thread Greg Huber
-- Forwarded Message Subject: Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready Date: Fri, 4 Feb 2022 09:30:47 + From: Greg Huber To: dev@struts.apache.org I have noticed that the date format only now wants a single a. I get an error when using two. err

Re: Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-06 Thread Lukasz Lenart
number*: 1,774 > > > although if I test ' dd, hh:mm aa' using SimpleDateFormat it works > > Tuesday February 22, 12:00 PM > > > > -------- Forwarded Message > Subject:Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready > Dat

Fwd: Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-04 Thread Greg Huber
dd, hh:mm aa' using SimpleDateFormat it works Tuesday February 22, 12:00 PM Forwarded Message Subject: Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready Date: Fri, 4 Feb 2022 09:30:47 + From: Greg Huber To: dev@struts.apache.org I have n

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-04 Thread Greg Huber
I have noticed that the date format only now wants a single a. I get an error when using two. error works Checking previous commits it's always been aa ie two. On 29/01/2022 16:49, Lukasz Lenart wrote: Hello, This is a second RC of incoming Struts 6.x with tons of changes. Please take a t

Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-03 Thread Lukasz Lenart
czw., 3 lut 2022 o 17:26 Eduardo Guadalupe napisał(a): > I tried to build the Project but i am having an error. Any tips about how > to solve it? > > Failed to execute goal on project struts2-jasperreports-plugin: Could not > resolve dependencies for project > org.apache.struts:struts2-jasperrepo

RE: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-02-03 Thread Eduardo Guadalupe
Hi, I tried to build the Project but i am having an error. Any tips about how to solve it? Failed to execute goal on project struts2-jasperreports-plugin: Could not resolve dependencies for project org.apache.struts:struts2-jasperreports-plugin:jar:6.0.0-RC2: Could not find artifact com.lowag

[TEST] Struts 2 ver. 6.0.0-RC2 test build is ready

2022-01-29 Thread Lukasz Lenart
Hello, This is a second RC of incoming Struts 6.x with tons of changes. Please take a time and test the bits - any help is appreciated. Please report any problems you will spot. Staging Maven repo https://repository.apache.org/content/groups/staging/ Standalone artifacts https://dist.apache.org/